1259219 - Top-level mozconfig is ignored (while .mozconfig works)

Status: RESOLVED FIXED

(Thunderbird :: Build Config, defect)

Description

[aleth [:aleth]]

A mozconfig in the c-c dir is ignored, while a .mozconfig is read. 

Most common symptom: "Cannot find project browser".

Regression from the configure changes in bug 1259174.

Comment 1

[aleth [:aleth]]

(In reply to aleth [:aleth] from comment #0)
> Regression from the configure changes in bug 1259174.

Sorry, bug 1254987 of course.

Comment 2

[aleth [:aleth]]

Attachment: Support both mozconfig and .mozconfig

Comment 3

[aleth [:aleth]]

Comment on attachment 8734540 [details] [diff] [review]
Support both mozconfig and .mozconfig

Review of attachment 8734540 [details] [diff] [review]:
-----------------------------------------------------------------

Bump.

Comment 4

[Patrick Cloke [:clokep]]

Comment on attachment 8734540 [details] [diff] [review]
Support both mozconfig and .mozconfig

Review of attachment 8734540 [details] [diff] [review]:
-----------------------------------------------------------------

Seems sane. I'm not sure how this worked before?

Comment 5

[aleth [:aleth]]

https://hg.mozilla.org/comm-central/rev/0e1299ac02ccbd74c33a0f63099056de7319a634
Bug 1259219 - Support both mozconfig and .mozconfig. r=clokep

Comment 6

[aleth [:aleth]]

(In reply to Patrick Cloke [:clokep] from comment #4)
> Seems sane. I'm not sure how this worked before?

It's fallout from the move of configure to python. There's code to find the mozconfig, but it finds the mozilla/ mozconfig. Making this fully split-build-system-aware seems like overkill given that cypress is coming (hopefully).

Comment 7

[:aceman]

And what are the uses for the different files? I always had a .mozconfig so what feature am I missing?

Comment 8

[aleth [:aleth]]

(In reply to :aceman from comment #7)
> And what are the uses for the different files? I always had a .mozconfig so
> what feature am I missing?

I don't think there is any difference. Likely historic reasons...

Comment 9

[Richard Marti (:Paenglab)]

Windows is a bit stupid with dot files. For example you can't rename the file because Windows wants something before the dot. OS X can't show the hidden files in some folders only. You have to enable this for the whole system (or is there a possibility, aleth?).

The question could also be, why should this mozconfig be a hidden file?

Comment 10

[Magnus Melin [:mkmelin]]

(In reply to Richard Marti (:Paenglab) from comment #9)
> The question could also be, why should this mozconfig be a hidden file?

Just a unix convention that configurable state lives in dot files. Like .thunderbird/