Closed Bug 1259186 Opened 8 years ago Closed 8 years ago

Send DOM event when feedback page is automatically loaded, instead of custom URL params

Categories

(Firefox for Android Graveyard :: General, defect)

defect
Not set
normal

Tracking

(firefox47 verified, firefox48 verified)

VERIFIED FIXED
Firefox 48
Tracking Status
firefox47 --- verified
firefox48 --- verified

People

(Reporter: Margaret, Assigned: Margaret)

References

Details

Attachments

(1 file)

I tested this locally with this test page:
http://people.mozilla.org/~mleibovic/feedback.html

Justin, here's a build you can use to test this out:
http://people.mozilla.org/~mleibovic/feedback-event.apk
Flags: needinfo?(hoosteeno)
Comment on attachment 8734062 [details]
MozReview Request: Bug 1259186 - Send DOM event when feedback page is automatically loaded, instead of custom URL params. r=grisha

https://reviewboard.mozilla.org/r/42071/#review39285

Looks good, but see my comment RE your comment :)

::: mobile/android/chrome/content/Feedback.js:30
(Diff revision 1)
>      let browser = BrowserApp.selectOrAddTab(url, { parentId: BrowserApp.selectedTab.id }).browser;
> +
>      browser.addEventListener("FeedbackClose", this, false, true);
>      browser.addEventListener("FeedbackMaybeLater", this, false, true);
> +
> +    // Dispatch a custom event to the page content when feedback is prompted by the browser.

I would perhaps clarify this comment, to explicitly state that this custom event will be used by the page to determine that it's being loaded from fennec's menus, vs from history. It'll be easier to remember what this is for in a couple of months :)
Attachment #8734062 - Flags: review?(gkruglov) → review+
Just poking this bug... hoosteeno is this still something you're working on? I'd like to verify this before landing.
It deserves a poke. I intend to hack on it during the week of 4/11. Keeping the needinfo as evidence of my good intentions. :)
https://hg.mozilla.org/integration/fx-team/rev/c7985389034d03f3e13db28dcd31c94912af550a
Bug 1259186 - Send DOM event when feedback page is automatically loaded, instead of custom URL params. r=grisha
https://hg.mozilla.org/mozilla-central/rev/c7985389034d
Status: NEW → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 48
The web parts of this landed in staging and prod just now: https://bugzilla.mozilla.org/show_bug.cgi?id=1225676
Blocks: 1271910
Comment on attachment 8734062 [details]
MozReview Request: Bug 1259186 - Send DOM event when feedback page is automatically loaded, instead of custom URL params. r=grisha

Approval Request Comment
[Feature/regressing bug #]: There is a change on the server side that requires this change on the client.

[User impact if declined]: "Maybe later" and "No Thanks" are missing from Firefox feedback page (bug 1271910)

[Describe test coverage new/current, TreeHerder]: Baked on Nightly/Aurora

[Risks and why]: Low-risk, only affects feedback page.

[String/UUID change made/needed]: None.
Attachment #8734062 - Flags: approval-mozilla-beta?
Comment on attachment 8734062 [details]
MozReview Request: Bug 1259186 - Send DOM event when feedback page is automatically loaded, instead of custom URL params. r=grisha

Recent regression, Beta47+
Attachment #8734062 - Flags: approval-mozilla-beta? → approval-mozilla-beta+
has problems uplifting to beta:

Tomcats-MacBook-Pro-2:mozilla-central Tomcat$ hg graft --edit -r c7985389034d
grafting 340568:c7985389034d "Bug 1259186 - Send DOM event when feedback page is automatically loaded, instead of custom URL params. r=grisha"
merging mobile/android/chrome/content/Feedback.js
warning: conflicts while merging mobile/android/chrome/content/Feedback.js! (edit, then use 'hg resolve --mark')
abort: unresolved conflicts, can't continue
(use 'hg resolve' and 'hg graft --continue')
Flags: needinfo?(margaret.leibovic)
As per comment 3 in Bug 1271910
Status: RESOLVED → VERIFIED
Product: Firefox for Android → Firefox for Android Graveyard
You need to log in before you can comment on or make changes to this bug.