1259238 - [fxos-sunset] Firefox not launching as expected on Pine for Gij tests.

Status: RESOLVED FIXED

(Testing Graveyard :: JSMarionette, defect)

Comment 1

[Aus Lacroix [:aus]]

Thanks to the work on bug 1259094 the tests now launch as expected as seen here -- https://treeherder.mozilla.org/#/jobs?repo=try&revision=8104c4a15b32&filter-tier=1&filter-tier=2&filter-tier=3&selectedJob=18569897

When the fix for 1259094 gets pushed to pine we will be able to close this out.

Comment 2

[Aus Lacroix [:aus]]

This now works as expected. Gij tests are running and reporting results.

See https://treeherder.mozilla.org/#/jobs?repo=pine&revision=ccddb6dcc121&filter-tier=1&filter-tier=2&filter-tier=3.

Comment 3

[Kartikaya Gupta (email:[e-mail])]

Attachment: Bug 1259238 - Remove code that displays visibility visualization on the APZ minimap.

This code was originally added to debug the frame visibility code.
However it wasn't architected correctly and makes the compositor use an
untrusted layers id from content. Instead of fixing this I'd rather just
delete it, since it's a big pile of code that is basically a debugging
tool that nobody owns anymore.

Review commit: https://reviewboard.mozilla.org/r/227110/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/227110/

Comment 4

[Matt Woodrow (:mattwoodrow)]

Comment on attachment 8958159 [details]
Bug 1259238 - Remove code that displays visibility visualization on the APZ minimap.

https://reviewboard.mozilla.org/r/227110/#review232912

Comment 5

[Kartikaya Gupta (email:[e-mail])]

Uh whoops, I put that patch on the wrong bug. It's supposed to go on bug 1258238.

Comment 6

[Kartikaya Gupta (email:[e-mail])]

Comment on attachment 8958159 [details]
Bug 1259238 - Remove code that displays visibility visualization on the APZ minimap.

Obsoleting the patch here