1259094 - Registering chrome gaia content should not be hardcoded

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Runtime, defect)

Description

[:gerard-majax]

Right now we need to change b2g/components/B2GComponents.manifest to change where Gaia content chrome URLs points to.

Comment 1

[Thomas Zimmermann [:tzimmermann] [:tdz]]

On eng builds, apps are located in /data/local/apps. I have to symlink /system/b2g/apps there to load Gaia.

Comment 2

[:gerard-majax]

Attachment: Remove harcoded path to Gaia chrome package

This is WIP but it works for me on Mulet and device. On mulet, picks "apps"
within the selected profile directory. On device, only picks from
/system/b2g/apps (for now).

Comment 3

[:gerard-majax]

That might help you getting tests running with Mulet, if you want to try this on try :)

Comment 4

[Aus Lacroix [:aus]]

Oh yes, this TOTALLY works! Thank you so much for figuring this out!

https://treeherder.mozilla.org/#/jobs?repo=try&revision=8104c4a15b32&filter-tier=1&filter-tier=2&filter-tier=3&selectedJob=18569897

We are obviously now seeing the real test failures, which is EXACTLY what we want! \o/!!!

Comment 5

[:gerard-majax]

Attachment: Remove harcoded path to Gaia chrome package

MozReview-Commit-ID: KbOjcgzqs1C

Comment 6

[:gerard-majax]

Fabrice, do you think it is too much hacky or we can move on with this?

Comment 7

[:gerard-majax]

Attachment: Remove harcoded path to Gaia chrome package

Fixing build on GCC 4.9

Comment 8

[[:fabrice] Fabrice Desré]

Comment on attachment 8734783 [details] [diff] [review]
Remove harcoded path to Gaia chrome package

Review of attachment 8734783 [details] [diff] [review]:
-----------------------------------------------------------------

Hm, no way to do that from an app-startup observer with all the code under b2g/ ?

Comment 9

[:gerard-majax]

(In reply to [:fabrice] Fabrice Desré from comment #8)
> Comment on attachment 8734783 [details] [diff] [review]
> Remove harcoded path to Gaia chrome package
> 
> Review of attachment 8734783 [details] [diff] [review]:
> -----------------------------------------------------------------
> 
> Hm, no way to do that from an app-startup observer with all the code under
> b2g/ ?

As far as I can tell, I have not been able to find any interface usable from JS. So we need some C++ executed on both Mulet and B2G, and this was the best I could find. I don't think |b2g/app/nsBrowserApp.cpp| is being used.

Comment 10

[:gerard-majax]

(In reply to [:fabrice] Fabrice Desré from comment #8)
> Comment on attachment 8734783 [details] [diff] [review]
> Remove harcoded path to Gaia chrome package
> 
> Review of attachment 8734783 [details] [diff] [review]:
> -----------------------------------------------------------------
> 
> Hm, no way to do that from an app-startup observer with all the code under
> b2g/ ?

I have a preliminary (hacked) XPCOM written in C++ and triggered by "profile-after-change" that is able to register a chrome gaia package. So I can rewrite this in a nicer way and avoid hacking around toolkit/xre/nsAppRunner.cpp.

Comment 11

[:gerard-majax]

Attachment: Remove harcoded path to Gaia chrome package

WIP with start of XPCOM C++

Comment 12

[:gerard-majax]

Attachment: Remove harcoded path to Gaia chrome package

Comment 13

[:gerard-majax]

Attachment: Remove harcoded path to Gaia chrome package r?fabrice

MozReview-Commit-ID: D52LOzYMDkF

Comment 14

[:gerard-majax]

https://hg.mozilla.org/try/rev/57c1535c4d97

Comment 15

[[:fabrice] Fabrice Desré]

Comment on attachment 8735152 [details] [diff] [review]
Remove harcoded path to Gaia chrome package r?fabrice

Review of attachment 8735152 [details] [diff] [review]:
-----------------------------------------------------------------

r=me with comments addressed.

::: b2g/components/moz.build
@@ +90,5 @@
> +
> +XPIDL_MODULE = 'gaia_chrome'
> +
> +UNIFIED_SOURCES += [
> +    'nsGaiaChrome.cpp'

nit: no need for a `ns` prefix.

::: b2g/components/nsGaiaChrome.cpp
@@ +66,5 @@
> +  locationDetection->Append(mAppsDir);
> +  nsresult appsInSystem = EnsureIsDirectory(locationDetection);
> +  locationDetection->InitWithPath(mDataRoot);
> +  locationDetection->Append(mAppsDir);
> +  nsresult appsInData   = EnsureIsDirectory(locationDetection);

nit: too many spaces after appsInData

@@ +89,5 @@
> +  return NS_OK;
> +}
> +
> +nsresult
> +nsGaiaChrome::EnsureIsDirectory(nsIFile* aPath)

I don't see any reason to not return a boolean.

Comment 16

[:gerard-majax]

Attachment: Remove harcoded path to Gaia chrome package

MozReview-Commit-ID: D52LOzYMDkF

Comment 17

[:gerard-majax]

https://hg.mozilla.org/projects/pine/rev/ccddb6dcc121