1259282 - Update rust mp4parse to v0.3.0

Status: RESOLVED INCOMPLETE

(Core :: Audio/Video: Playback, defect, P2)

Description

[Ralph Giles (:rillian)]

Sync with recent changes. Mainly this adds stream reader callback support through the new mp4parse_io struct.

Comment 1

[Ralph Giles (:rillian)]

Attachment: Update script to import v0.3.0

Comment 2

[Ralph Giles (:rillian)]

Attachment: Part 2 - Result of running the script

Comment 3

[Ralph Giles (:rillian)]

Attachment: Part 3 - Update gecko code

Comment 4

[Ralph Giles (:rillian)]

Attachment: Part 4 - Update tests (WIP)

Reader implementation needs to be a little more sophisticated.

Comment 5

[Ralph Giles (:rillian)]

BTW, this has been stalled while I work on bug 1240413 which will probably result in an 0.3.1.

Comment 6

[Ralph Giles (:rillian)]

Attachment: Part 1 - Update script for mp4parse v0.3.0

Comment 7

[Ralph Giles (:rillian)]

Attachment: Part 2 - Update mp4parse to v0.3.0

Comment 8

[Ralph Giles (:rillian)]

Attachment: Part 3 - Update gecko code

Might as well get this out of my queue now that merge day has passed. How does this look, Matthew?

Comment 9

[Ralph Giles (:rillian)]

Attachment: Part 4 - Update tests (WIP)

This one still needs some work:

/home/giles/firefox/media/libstagefright/gtest/TestMP4Rust.cpp:32: Failure
Value of: nullptr
  Actual: 8-byte object <00-00 00-00 00-00 00-00>
Expected: context
Which is: 0x7f3b04335820

Comment 10

[Matthew Gregan [:kinetik]]

Comment on attachment 8745793 [details] [diff] [review]
Part 3 - Update gecko code

Review of attachment 8745793 [details] [diff] [review]:
-----------------------------------------------------------------

::: media/libstagefright/binding/MP4Metadata.cpp
@@ +520,4 @@
>  {
>    static LazyLogModule sLog("MP4Metadata");
>  
> +//  mRustParser = mp4parse_new(&mRustIo);

Drop this line

Comment 11

[Ralph Giles (:rillian)]

This is superceded by landing v0.4.0 in bug 1267887.