Closed Bug 1259291 Opened 4 years ago Closed 2 years ago

Remove -wd4312 from dom/canvas/moz.build

Categories

(Core :: Canvas: 2D, defect, P3)

defect

Tracking

()

RESOLVED FIXED
mozilla59
Tracking Status
firefox59 --- fixed

People

(Reporter: gps, Assigned: gerald)

References

Details

(Whiteboard: gfx-noted)

Attachments

(1 file)

-wd4312 was added to CXXFLAGS in dom/canvas/moz.build in bug 1124033 to unblock VS2015 building in warnings as errors mode. This bug tracks removing it.

I can't recall which warning this is masking. Should be easy to reproduce locally.
Whiteboard: gfx-noted
See Also: → 1259293
Comment on attachment 8932756 [details]
Bug 1259291 - Remove -wd4312, as the issue was fixed in bug 1259291 -

https://reviewboard.mozilla.org/r/203796/#review209276
Attachment #8932756 - Flags: review?(jacheng) → review+
Thank you for the review, James.
Assignee: nobody → gsquelart
Pushed by gsquelart@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/1493f4aa499a
Remove -wd4312, as the issue was fixed in bug 1259291 - r=JamesCheng
https://hg.mozilla.org/mozilla-central/rev/1493f4aa499a
Status: NEW → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla59
You need to log in before you can comment on or make changes to this bug.