Remove -wd4312 from dom/canvas/moz.build

RESOLVED FIXED in Firefox 59

Status

()

Core
Canvas: 2D
P3
normal
RESOLVED FIXED
2 years ago
5 months ago

People

(Reporter: gps, Assigned: gerald)

Tracking

unspecified
mozilla59
Points:
---

Firefox Tracking Flags

(firefox59 fixed)

Details

(Whiteboard: gfx-noted)

MozReview Requests

()

Submitter Diff Changes Open Issues Last Updated
Loading...
Error loading review requests:

Attachments

(1 attachment)

(Reporter)

Description

2 years ago
-wd4312 was added to CXXFLAGS in dom/canvas/moz.build in bug 1124033 to unblock VS2015 building in warnings as errors mode. This bug tracks removing it.

I can't recall which warning this is masking. Should be easy to reproduce locally.
Whiteboard: gfx-noted
(Assignee)

Updated

2 years ago
See Also: → bug 1259293
Priority: -- → P3
Comment hidden (mozreview-request)

Comment 2

5 months ago
mozreview-review
Comment on attachment 8932756 [details]
Bug 1259291 - Remove -wd4312, as the issue was fixed in bug 1259291 -

https://reviewboard.mozilla.org/r/203796/#review209276
Attachment #8932756 - Flags: review?(jacheng) → review+
(Assignee)

Comment 3

5 months ago
Thank you for the review, James.
Assignee: nobody → gsquelart

Comment 4

5 months ago
Pushed by gsquelart@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/1493f4aa499a
Remove -wd4312, as the issue was fixed in bug 1259291 - r=JamesCheng

Comment 5

5 months ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/1493f4aa499a
Status: NEW → RESOLVED
Last Resolved: 5 months ago
status-firefox59: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla59
You need to log in before you can comment on or make changes to this bug.