1259291 - Remove -wd4312 from dom/canvas/moz.build

Status: RESOLVED FIXED

(Core :: Graphics: Canvas2D, defect, P3)

Description

[Gregory Szorc [:gps]]

-wd4312 was added to CXXFLAGS in dom/canvas/moz.build in bug 1124033 to unblock VS2015 building in warnings as errors mode. This bug tracks removing it.

I can't recall which warning this is masking. Should be easy to reproduce locally.

Comment 1

[Gerald Squelart (he/him) (not at Mozilla since 2022-09-15)]

Attachment: Bug 1259291 - Remove -wd4312, as the issue was fixed in bug 1259291 -

Review commit: https://reviewboard.mozilla.org/r/203796/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/203796/

Comment 2

[James Cheng[:JamesCheng]]

Comment on attachment 8932756 [details]
Bug 1259291 - Remove -wd4312, as the issue was fixed in bug 1259291 -

https://reviewboard.mozilla.org/r/203796/#review209276

Comment 3

[Gerald Squelart (he/him) (not at Mozilla since 2022-09-15)]

Thank you for the review, James.

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/1493f4aa499a
Remove -wd4312, as the issue was fixed in bug 1259291 - r=JamesCheng

Comment 5

[Bogdan Tara[:bogdan_tara | bogdant]]

https://hg.mozilla.org/mozilla-central/rev/1493f4aa499a