Closed
Bug 1259325
Opened 9 years ago
Closed 9 years ago
Improve retries for retrieving SETA config
Categories
(Release Engineering :: General, defect)
Release Engineering
General
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: nthomas, Assigned: nthomas)
References
Details
Attachments
(1 file)
|
1.86 KB,
patch
|
kmoir
:
review+
kmoir
:
checked-in+
|
Details | Diff | Splinter Review |
We've been hitting socket.error exceptions when getting SETA data (see bug 1176784) but they're not getting caught by the retry logic we already have. This leaves the masters in a bad state where they consume jobs rapidly and fail on them, after raising
exceptions.TypeError: unbound method __init__() must be called with C instance as first argument (got MockCommand instance instead)
in buildbot's Build.setupBuild.
|
Assignee | |
Comment 1•9 years ago
|
||
Does moves all the connection, reading, and decoding inside the try block with the retries. Adds handling for JSON decode exceptions too. If this is r+ could you get it landed too ?
Attachment #8734227 -
Flags: review?(kmoir)
|
||
Updated•9 years ago
|
Attachment #8734227 -
Flags: review?(kmoir) → review+
|
|
||
Comment 2•9 years ago
|
||
Comment on attachment 8734227 [details] [diff] [review]
[buildbot-configs] Retry harder
thanks Nick!
Attachment #8734227 -
Flags: checked-in+
|
|
Assignee | |
Comment 3•9 years ago
|
||
Landed at http://hg.mozilla.org/build/buildbot-configs/rev/3a24d5fe45b9 at Thu, 24 Mar 2016 09:39:31 -0400 (5 days ago), with merge to production.
Status: NEW → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
|
||
Updated•7 years ago
|
Component: General Automation → General
You need to log in
before you can comment on or make changes to this bug.
Description
•