1247286 - add retry logic to config_seta.py

Status: RESOLVED FIXED

(Infrastructure & Operations Graveyard :: CIDuty, task)

Description

[Kim Moir [:kmoir] ET]

in case seta server in intermittently unavailable

Comment 1

[Kim Moir [:kmoir] ET]

Attachment: bug247286.patch

Comment 2

[Kim Moir [:kmoir] ET]

Attachment: bug247286.patch

Comment 3

[Justin Wood (:Callek)]

Comment on attachment 8717960 [details] [diff] [review]
bug247286.patch

Review of attachment 8717960 [details] [diff] [review]:
-----------------------------------------------------------------

::: mozilla-tests/config_seta.py
@@ +57,5 @@
> +        if retries < 1:
> +            raise Exception("Could not fetch url '%s'" % url)
> +        retries -= 1
> +        print("Retrying")
> +        time.sleep(60)

I've never been a big fan of `while True` in code thats not meant to live forever. Too easy to accidentally break the assumptioned logic at some point.

That said, I'm not going to r- for it since this is relatively clean code and leave it up to you.

@@ +71,1 @@
>      data = json.loads(response.read())

I'm more likely to have wanted the retry logic out here, due to possible cases of severed pipe/abnormal socket termination that merely causes invalid json and not the innability to read SETA. But either way this is an improvement I'm happy to take.

Comment 4

[Kim Moir [:kmoir] ET]

in production