1259381 - Move --with-ccache and --with-compiler-wrapper to moz.configure

Status: RESOLVED FIXED

(Firefox Build System :: General, defect)

Comment 1

[Mike Hommey [:glandium]]

Attachment: MozReview Request: Bug 1259381 - Don't add --with-ccache in mozconfigs doing --disable-compile-environment or --enable-artifact-builds. r=chmanchester

While moving the ccache flag, we're going to make it disappear when the
compiler environment is not enabled, so adding --with-ccache will fail.

Review commit: https://reviewboard.mozilla.org/r/42639/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/42639/

Comment 2

[Mike Hommey [:glandium]]

Attachment: MozReview Request: Bug 1259381 - Move --with-ccache and --with-compiler-wrapper to moz.configure. r=chmanchester

Review commit: https://reviewboard.mozilla.org/r/42641/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/42641/

Comment 3

[Chris Manchester (limited bugmail, email directly)]

Comment on attachment 8735181 [details]
MozReview Request: Bug 1259381 - Don't add --with-ccache in mozconfigs doing --disable-compile-environment or --enable-artifact-builds. r=chmanchester

https://reviewboard.mozilla.org/r/42639/#review39243

Comment 4

[Chris Manchester (limited bugmail, email directly)]

Comment on attachment 8735182 [details]
MozReview Request: Bug 1259381 - Move --with-ccache and --with-compiler-wrapper to moz.configure. r=chmanchester

https://reviewboard.mozilla.org/r/42641/#review39251

::: build/moz.configure/toolchain.configure:102
(Diff revision 1)
> +def using_compiler_wrapper(compiler_wrapper):
> +    return True
> +
> +set_config('MOZ_USING_COMPILER_WRAPPER', using_compiler_wrapper)

These "using" functions might work as well as lambdas in the set_config calls.

Comment 5

[Mike Hommey [:glandium]]

https://reviewboard.mozilla.org/r/42641/#review39251

> These "using" functions might work as well as lambdas in the set_config calls.

You mean a depends_if-wrapped lambda. I'd rather live them there for now, they're easier to identify by introspection (I want to identify some patterns "automatically" and do some bikeshedding on them later)

Comment 6

[Chris Manchester (limited bugmail, email directly)]

https://reviewboard.mozilla.org/r/42641/#review39251

> You mean a depends_if-wrapped lambda. I'd rather live them there for now, they're easier to identify by introspection (I want to identify some patterns "automatically" and do some bikeshedding on them later)

Yes, I mean that. That sounds fine.

Comment 7

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/bd956b7718c9
https://hg.mozilla.org/integration/mozilla-inbound/rev/352568360a61

Comment 8

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/bd956b7718c9
https://hg.mozilla.org/mozilla-central/rev/352568360a61

Comment 9

[(not currently active) Ted Mielczarek]

https://reviewboard.mozilla.org/r/42641/#review40653

::: build/moz.configure/toolchain.configure:79
(Diff revision 1)
> +        return value
> +    # If --with-ccache was given without an explicit value, we default to
> +    # 'ccache'.
> +    return 'ccache'
> +
> +ccache = check_prog('CCACHE', progs=(), input=ccache)

This is confusing, reusing the same name for the results of check_prog and the handler for the argument.