1259495 - mailnews/local/src/nsLocalUndoTxn.cpp:553:15: error: ‘class nsIAtom’ has no member named ‘EqualsUTF8'

Status: RESOLVED FIXED

(MailNews Core :: Backend, defect)

Description

[ISHIKAWA, Chiaki]

It is great to see C-C build working again, but
when I refreshed the source a few hours ago,
I got a compilation bug.

mailnews/local/src/nsLocalUndoTxn.cpp:553:15: error: ‘class nsIAtom’ has no member named ‘EqualsUTF8’
       aEvent->EqualsUTF8(NS_LITERAL_CSTRING("FolderLoaded")))
               ^
Probably a method was decprecated or something.

Comment 1

[Richard Marti (:Paenglab)]

I suppose, it's bug 1257128.

Comment 2

[Nicholas Nethercote [inactive]]

Sorry for the breakage! I think you can fix it by (a) changing the NS_LITERAL_CSTRING to NS_LITERAL_STRING, and (b) calling ScriptableEquals() instead of EqualsUTF8().

Comment 3

[Richard Marti (:Paenglab)]

This: aEvent->ScriptableEquals(NS_LITERAL_STRING("FolderLoaded")))

ends in this error: z:/Mozilla/comm-central/mailnews/local/src/nsLocalUndoTxn.cpp(553) : error C2660: 'nsIAtom::ScriptableEquals' : function does not take 1 arguments

I have zero knowledge of c++

As I understand, EqualsUTF8 was this

AtomImpl::EqualsUTF8(const nsACString& aString)
{
  return CompareUTF8toUTF16(aString,
                            nsDependentString(mString, mLength)) == 0;
}

Would it work, using CompareUTF8toUTF16 somehow?

Comment 4

[Jorg K (CEST = GMT+2)]

Attachment: This might work.

Comment 5

[Hartmut Figge]

(In reply to Jorg K (GMT+1) from comment #4)
> Created attachment 8734533 [details] [diff] [review]
> This might work.

SM:
/home/hafi/moz-work/src/mailnews/local/src/nsLocalUndoTxn.cpp:554:32: error: ‘NS_LITERAL_STRING’ was not declared in this scope
       aEvent->ScriptableEquals(NS_LITERAL_STRING("FolderLoaded", &isEqual));
                                ^
   (deps)  /home/hafi/moz-work/src/mozilla/intl/icu/source/i18n/collationcompare.cpp
/home/hafi/moz-work/src/mozilla/config/rules.mk:918: recipe for target 'nsLocalUndoTxn.o' failed
make[4]: *** [nsLocalUndoTxn.o] Error 1

Comment 6

[Frank-Rainer Grahl (:frg)]

Are just the braces wrong and it should be:


aEvent->ScriptableEquals(NS_LITERAL_STRING("FolderLoaded"), &isEqual)

?

Comment 7

[Jorg K (CEST = GMT+2)]

Attachment: This might work, take 2.

Oops, sorry.

Comment 8

[Frank-Rainer Grahl (:frg)]

Suite seems to compile but now hits a VS2015 char16_t error. Unrelated to this one. Someone goofed in mozilla code so can't test right now.

Comment 9

[Hartmut Figge]

My SM-Trunk Linux x86_64 builds successfully now. Because $OBJDIR is always deleted before compiling?

Comment 10

[Kent James (:rkent)]

Comment on attachment 8734538 [details] [diff] [review]
This might work, take 2.

Review of attachment 8734538 [details] [diff] [review]:
-----------------------------------------------------------------

OK LGTM.

Comment 11

[Jorg K (CEST = GMT+2)]

https://hg.mozilla.org/comm-central/rev/ed69d0332588