Reader mode omits opening paragraph on CNN articles

RESOLVED FIXED

Status

()

Toolkit
Reader Mode
P3
normal
RESOLVED FIXED
2 years ago
10 months ago

People

(Reporter: abr, Assigned: evanxd)

Tracking

(Blocks: 3 bugs)

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: [reader-mode-readability-algorithm])

(Reporter)

Description

2 years ago
Articles on CNN frequently have an opening paragraph that is styled differently than others. Reader mode does not include this lead paragraph in its view.

See, for example, http://money.cnn.com/2016/02/01/news/economy/poverty-inequality-united-states/index.html

Comment 1

2 years ago
Thanks for the report. This sounds like an issue with the Readability library, so I filed an issue here: https://github.com/mozilla/readability/issues/281

Updated

a year ago
Priority: -- → P3

Updated

a year ago
Whiteboard: [reader-mode-readability-algorithm]

Updated

a year ago
Blocks: 1286221
(Assignee)

Comment 2

a year ago
Cannot reproduce anymore. The webpage[1] seems already changed. There is no opening paragraph there and the reader mode result is good.

[1]: http://money.cnn.com/2016/02/01/news/economy/poverty-inequality-united-states/index.html
Status: NEW → RESOLVED
Last Resolved: a year ago
Resolution: --- → WORKSFORME

Comment 3

a year ago
(In reply to Evan Tseng [:evanxd][:愛聞插低] from comment #2)
> Cannot reproduce anymore. The webpage[1] seems already changed. There is no
> opening paragraph there

I see:

The U.S. has long been heralded as a land of opportunity -- a place where anyone can succeed regardless of the economic class they were born into.

on the page in a different font, and that paragraph does not make it into the reader mode result. Are you seeing something else?

> and the reader mode result is good.
> 
> [1]:
> http://money.cnn.com/2016/02/01/news/economy/poverty-inequality-united-
> states/index.html
Flags: needinfo?(evan)
Gijs I see the same. I do know of cases where large sites to serve different markup to different regions.
Status: RESOLVED → REOPENED
Resolution: WORKSFORME → ---
Status: REOPENED → NEW
(Assignee)

Updated

a year ago
Blocks: 1324630
(Assignee)

Comment 5

11 months ago
I can reproduce the issue mentioned on Comment 3. Somehow the `<h2>The U.S. has long been heralded as a land of opportunity -- a place where anyone can succeed regardless of the economic class they were born into.</h2>` node is just removed by some kind of reason.

Good thing is the algorithm chooses correct `topCandidate` (`<div id="storytext">`).

Continue investigate the issue...
Flags: needinfo?(evan)
(Assignee)

Comment 6

11 months ago
Added tests[1] to investigate the issue.

[1]: https://github.com/mozilla/readability/pull/347/commits/077bca8721975efa607839f8c2756d2eee323f29
(Assignee)

Updated

11 months ago
Assignee: nobody → evan
Status: NEW → ASSIGNED
(Assignee)

Comment 7

11 months ago
Sent a PR[1] with the solution. Let's discuss it there.

[1]: https://github.com/mozilla/readability/pull/347/commits/a0f94b1869b5188dfad66d1d5cc8b6270c5bc4f2
(Assignee)

Comment 8

11 months ago
Updated the patch to use a new solution to fix the issue[1].

[1]: https://github.com/mozilla/readability/pull/347/commits/64e97fead34ed567025109c2b6df0ae2d8a40db4
(Assignee)

Comment 9

11 months ago
Fixed all test failures[1].

[1]: https://github.com/mozilla/readability/pull/347/commits/73a020d56675ba649a272d95e025404a9d7936f5
(Assignee)

Comment 10

11 months ago
Updated patch for review comments: https://github.com/mozilla/readability/pull/347/commits/e6ae86bd9c4dc9d14f87d16f99f4a57b319ce4bb
(Assignee)

Comment 11

11 months ago
Landed in GitHub: https://github.com/mozilla/readability/commit/498a7b2bf6b6c3460cb85bed57aad0f8196fd532
(Assignee)

Comment 12

10 months ago
We'll land it in m-c in the MozReview patch[1].

[1]: https://reviewboard.mozilla.org/r/109976/diff/2#index_header
(Assignee)

Comment 13

10 months ago
Landed in m-c: https://hg.mozilla.org/mozilla-central/rev/d1bef3268b21
(Assignee)

Updated

10 months ago
Status: ASSIGNED → RESOLVED
Last Resolved: a year ago10 months ago
Resolution: --- → FIXED

Updated

10 months ago
Blocks: 1329358
You need to log in before you can comment on or make changes to this bug.