Closed
Bug 1259846
Opened 8 years ago
Closed 8 years ago
E10s cohort crash annotation doesn't always work
Categories
(Firefox :: General, defect)
Tracking
()
RESOLVED
FIXED
Firefox 48
People
(Reporter: Felipe, Assigned: Felipe)
References
Details
Attachments
(1 file, 1 obsolete file)
950 bytes,
patch
|
mossop
:
review+
ritu
:
approval-mozilla-aurora+
|
Details | Diff | Splinter Review |
Depending on how early that code runs, Services.appinfo has not yet been QI'ed to nsICrashReporter, so the call fails
Attachment #8734945 -
Flags: review?(dtownsend)
Assignee | ||
Updated•8 years ago
|
Summary: E10s cohort annotation doesn't always register → E10s cohort crash annotation doesn't always work
Assignee | ||
Comment 1•8 years ago
|
||
Attachment #8734945 -
Attachment is obsolete: true
Attachment #8734945 -
Flags: review?(dtownsend)
Attachment #8734947 -
Flags: review?(dtownsend)
Assignee | ||
Comment 2•8 years ago
|
||
(sorry for the bugspam, brain is failing)
Updated•8 years ago
|
Attachment #8734947 -
Flags: review?(dtownsend) → review+
Updated•8 years ago
|
tracking-e10s:
--- → m9+
Comment 4•8 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/7720685c0eba
Status: ASSIGNED → RESOLVED
Closed: 8 years ago
status-firefox48:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 48
Assignee | ||
Comment 5•8 years ago
|
||
Comment on attachment 8734947 [details] [diff] [review] patch Approval Request Comment [Feature/regressing bug #]: the crash reporter annotation of e10s cohort [User impact if declined]: without this a crash report might not have this useful information [Describe test coverage new/current, TreeHerder]: landed in central, confirmed to be working for nightly reports [Risks and why]: none outside of the annotation not working [String/UUID change made/needed]: none
Attachment #8734947 -
Flags: approval-mozilla-aurora?
status-firefox47:
--- → affected
Comment on attachment 8734947 [details] [diff] [review] patch Better crash diagnostics (that were verified in Nightly), definitely worth uplifting to Aurora47
Attachment #8734947 -
Flags: approval-mozilla-aurora? → approval-mozilla-aurora+
Comment 7•8 years ago
|
||
bugherder uplift |
https://hg.mozilla.org/releases/mozilla-aurora/rev/35e304886cc3
Is it worth getting this on beta as well?
Flags: needinfo?(felipc)
Assignee | ||
Comment 9•8 years ago
|
||
No, not this one. We've finished the e10s experiments on beta 46, and will resume them on 47.
Flags: needinfo?(felipc)
Updated•8 years ago
|
status-firefox46:
--- → wontfix
You need to log in
before you can comment on or make changes to this bug.
Description
•