Closed Bug 1259846 Opened 4 years ago Closed 4 years ago
E10s cohort crash annotation doesn't always work
Depending on how early that code runs, Services.appinfo has not yet been QI'ed to nsICrashReporter, so the call fails
Summary: E10s cohort annotation doesn't always register → E10s cohort crash annotation doesn't always work
Attachment #8734947 - Flags: review?(dtownsend) → review+
Comment on attachment 8734947 [details] [diff] [review] patch Approval Request Comment [Feature/regressing bug #]: the crash reporter annotation of e10s cohort [User impact if declined]: without this a crash report might not have this useful information [Describe test coverage new/current, TreeHerder]: landed in central, confirmed to be working for nightly reports [Risks and why]: none outside of the annotation not working [String/UUID change made/needed]: none
Attachment #8734947 - Flags: approval-mozilla-aurora?
Comment on attachment 8734947 [details] [diff] [review] patch Better crash diagnostics (that were verified in Nightly), definitely worth uplifting to Aurora47
Attachment #8734947 - Flags: approval-mozilla-aurora? → approval-mozilla-aurora+
Is it worth getting this on beta as well?
No, not this one. We've finished the e10s experiments on beta 46, and will resume them on 47.
You need to log in before you can comment on or make changes to this bug.