Closed Bug 1259846 Opened 4 years ago Closed 4 years ago

E10s cohort crash annotation doesn't always work

Categories

(Firefox :: General, defect)

46 Branch
defect
Not set

Tracking

()

RESOLVED FIXED
Firefox 48
Tracking Status
e10s m9+ ---
firefox46 --- wontfix
firefox47 --- fixed
firefox48 --- fixed

People

(Reporter: Felipe, Assigned: Felipe)

References

Details

Attachments

(1 file, 1 obsolete file)

Attached patch patch (obsolete) — Splinter Review
Depending on how early that code runs, Services.appinfo has not yet been QI'ed to nsICrashReporter, so the call fails
Attachment #8734945 - Flags: review?(dtownsend)
Summary: E10s cohort annotation doesn't always register → E10s cohort crash annotation doesn't always work
Attached patch patchSplinter Review
Attachment #8734945 - Attachment is obsolete: true
Attachment #8734945 - Flags: review?(dtownsend)
Attachment #8734947 - Flags: review?(dtownsend)
(sorry for the bugspam, brain is failing)
Blocks: 1257251
No longer blocks: 1257265
Attachment #8734947 - Flags: review?(dtownsend) → review+
https://hg.mozilla.org/mozilla-central/rev/7720685c0eba
Status: ASSIGNED → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 48
Comment on attachment 8734947 [details] [diff] [review]
patch

Approval Request Comment
[Feature/regressing bug #]: the crash reporter annotation of e10s cohort
[User impact if declined]: without this a crash report might not have this useful information
[Describe test coverage new/current, TreeHerder]: landed in central, confirmed to be working for nightly reports
[Risks and why]: none outside of the annotation not working
[String/UUID change made/needed]: none
Attachment #8734947 - Flags: approval-mozilla-aurora?
Comment on attachment 8734947 [details] [diff] [review]
patch

Better crash diagnostics (that were verified in Nightly), definitely worth uplifting to Aurora47
Attachment #8734947 - Flags: approval-mozilla-aurora? → approval-mozilla-aurora+
Is it worth getting this on beta as well?
Flags: needinfo?(felipc)
No, not this one. We've finished the e10s experiments on beta 46, and will resume them on 47.
Flags: needinfo?(felipc)
Depends on: 1263051
You need to log in before you can comment on or make changes to this bug.