1259946 - Add toolbar button to remove all storage items

Status: RESOLVED WORKSFORME

(DevTools :: Storage Inspector, defect)

Comment 1

[Tim Nguyen :ntim]

Attachment: Part 1 - Add clear button to storage inspector

Comment 2

[Tim Nguyen :ntim]

Attachment: Part 1 - Add clear button to storage inspector

Part 2 (tests) depends on bug 1231179 and bug 1231155. It'll be much easier to write tests once those bugs land.

Comment 3

[Tim Nguyen :ntim]

Attachment: Part 1 - Add clear button to storage inspector

The tooltip now works.

Comment 4

[Tim Nguyen :ntim]

Hey Jarda,

I've seen you've worked on bug 1231434, are you interested in taking over this bug ?

Tim

Comment 5

[Jarda Snajdr [:jsnajdr]]

Hello Tim,

if you don't plan to finish the patch (it's already pretty close), feel free to reassign the bug to me.

However, I think that this feature is not a particularly good idea. First, there are already two ways to "Delete All", in the table and tree context menus. Second, it's quite a dangerous action to be always just one click away, on an always visible button, without any confirmation. This is real, persistent app data that's going to be deleted. Not just some ephemeral console or network request log that can be recreated by reloading the page.

Comment 6

[Tim Nguyen :ntim]

(In reply to Jarda Snajdr [:jsnajdr] from comment #5)
> Hello Tim,
> 
> if you don't plan to finish the patch (it's already pretty close), feel free
> to reassign the bug to me.
> 
> However, I think that this feature is not a particularly good idea. First,
> there are already two ways to "Delete All", in the table and tree context
> menus.
I think it's still nice to have a button for this, it makes the action much more discoverable, especially as it is a new feature. Plus, it fills up the almost empty toolbar, and makes it look more consistent with other tools.

> Second, it's quite a dangerous action to be always just one click
> away, on an always visible button, without any confirmation. This is real,
> persistent app data that's going to be deleted. Not just some ephemeral
> console or network request log that can be recreated by reloading the page.
I agree with it, I guess we can add a prompt when clicking on the button (and probably the context menu items as well).

Comment 7

[Mike Ratcliffe [:miker] [:mratcliffe] [:mikeratcliffe]]

(In reply to Jarda Snajdr [:jsnajdr] from comment #5)
> Hello Tim,
> 
> if you don't plan to finish the patch (it's already pretty close), feel free
> to reassign the bug to me.
> 
> However, I think that this feature is not a particularly good idea. First,
> there are already two ways to "Delete All", in the table and tree context
> menus. Second, it's quite a dangerous action to be always just one click
> away, on an always visible button, without any confirmation. This is real,
> persistent app data that's going to be deleted. Not just some ephemeral
> console or network request log that can be recreated by reloading the page.

I am inclined to agree with jsnajdr... all other tools use context menus and don't prompt for confirmation so we should keep this pattern.

Let's close this bug.