1260103 - Block plugin pop-up close button is barely visible

Status: VERIFIED FIXED

(Firefox :: Theme, defect)

Description

[Cornel Ionce [:cornel_ionce], Desktop Release QA]

[Affected versions]:
- Firefox 45.0.1
- Firefox 46 beta 5
- Latest 47.0a2 Aurora
- Latest 48.0a1 Nightly

[Affected platforms]:
- Windows 10 x64
- Windows 7 x64
- Ubuntu 14.04 x86

[Steps to reproduce]:
1. Make sure you are using an old/blocked flash version. 
2. Open Firefox using a clean profile.
3. Navigate to a flash content website.
4. Notice the outdated plugin prevention message.


[Expected result]:
The message is correctly displayed with every element visible. 

[Actual result]:
The close button is barely visible.

[Regression range]:
I was able to track down a regression range on Windows 10x64.

Last good: 20150717030202
First bad: 20150718030211
Pushlog: https://hg.mozilla.org/mozilla-central/pushloghtml?fromchange=15155971639c&tochange=d317a93e5161

Caused by: 	
ac6f2fb6777e	Dão Gottwald — Bug 1173729 - Update generic close icon and new tab button icon on Windows 10. r=jaws

[Additional notes]:
- Screenshot: http://i.imgur.com/xx9xP2S.png
- Hovered state: http://i.imgur.com/DBytoRr.png
- This issue does not reproduce on Mac OS X 10.9.5

Comment 1

[Liz Henry (:lizzard Please n-i to RyanVM, jcristau, or pascal)]

Dao can you take a look here?

Comment 2

[Dão Gottwald [::dao]]

This is because we set a custom background for this notification bar: http://mxr.mozilla.org/mozilla-central/search?string=pluginVulnerable&case=on

I'd suggest that we stop doing that and use the standard notification bar styling.

Comment 3

[Benjamin Smedberg]

We decided explicitly that it was more important for this to be the same styling as the in-content blocked plugin notification. I'd like to keep that if possible. We already have a close icon for this case: are we never using it or only not using it in this new win10 case?

Comment 4

[Dão Gottwald [::dao]]

Attachment: patch

Comment 5

[:Gijs (he/him)]

Comment on attachment 8739365 [details] [diff] [review]
patch

Review of attachment 8739365 [details] [diff] [review]:
-----------------------------------------------------------------

This reproduces on Linux as well, at least on Nightly, so we should fix it there, too.

Comment 6

[Dão Gottwald [::dao]]

Attachment: patch

Comment 7

[Pulsebot]

https://hg.mozilla.org/integration/fx-team/rev/1ea84d818c7d

Comment 8

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/1ea84d818c7d

Comment 9

[Cornel Ionce [:cornel_ionce], Desktop Release QA]

Confirming the fix on Latest Nightly 48, build ID: 20160410030224.
Verified on:
* Windows 10 x64
* Windows 7 x64
* Ubuntu 14.04 x86

Comment 10

[Liz Henry (:lizzard Please n-i to RyanVM, jcristau, or pascal)]

Regression from Firefox 42, wontfix for 46 at this point. 
Ritu, do you want this for beta? css only change, though it is late in beta.

Comment 11

[Ritu Kothari (:ritu) (Inactive, please n-i to RyanVM, jcristau, or pascal)]

Hi Dao, if this is a low-risk fix, since its a very visible regression I am open to uplifting to Beta47. What do you think?

Comment 12

[Dão Gottwald [::dao]]

Comment on attachment 8739376 [details] [diff] [review]
patch

Approval Request Comment
[Feature/regressing bug #]: bug 1173729
[User impact if declined]: see comment 0
[Describe test coverage new/current, TreeHerder]: no test coverage
[Risks and why]: simple CSS fix, low risk
[String/UUID change made/needed]: none

Comment 13

[:Gijs (he/him)]

(In reply to Dão Gottwald [:dao] from comment #12)
> Comment on attachment 8739376 [details] [diff] [review]
> patch
> 
> Approval Request Comment
> [Feature/regressing bug #]: bug 1173729
> [User impact if declined]: see comment 0
> [Describe test coverage new/current, TreeHerder]: no test coverage
> [Risks and why]: simple CSS fix, low risk
> [String/UUID change made/needed]: none

48 is on aurora, and this was fixed in 48 - did you mean to request beta approval?

Comment 14

[Ritu Kothari (:ritu) (Inactive, please n-i to RyanVM, jcristau, or pascal)]

Comment on attachment 8739376 [details] [diff] [review]
patch

Visual regression, though it has been shipping since 45, the fix is simple and has been verified on Nightly, Beta47+

Comment 15

[Ritu Kothari (:ritu) (Inactive, please n-i to RyanVM, jcristau, or pascal)]

Hi Wes, fyi this fix needs to be uplifted to m-b. Thanks!

Comment 16

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/releases/mozilla-beta/rev/7abf386fee3f

Comment 17

[Andrei Vaida [:avaida]]

Setting the flag for verification on 47.0b9.

Comment 18

[Cornel Ionce [:cornel_ionce], Desktop Release QA]

Confirming this issue is fixed on Firefox 47.0b9, build ID 20160526140250.