Closed Bug 1173729 Opened 5 years ago Closed 5 years ago

Update generic close icon and new tab button icon on Windows 10

Categories

(Firefox :: Theme, defect, P1)

Unspecified
Windows 10
defect

Tracking

()

VERIFIED FIXED
Firefox 42
Tracking Status
firefox39 --- unaffected
firefox40 --- verified
firefox41 --- verified
firefox42 --- verified

People

(Reporter: dao, Assigned: dao)

References

(Blocks 2 open bugs)

Details

Attachments

(9 files, 1 obsolete file)

572 bytes, image/png
Details
1.13 KB, image/png
Details
598 bytes, image/png
Details
1.18 KB, image/png
Details
87 bytes, image/png
Details
99 bytes, image/png
Details
110 bytes, image/png
Details
142 bytes, image/png
Details
29.75 KB, patch
jaws
: review+
Details | Diff | Splinter Review
Notably, this will make the tab close button larger for touch-friendliness.
needinfo for the new images
Flags: needinfo?(shorlander)
Priority: -- → P1
We also need inverted variants.

And we need the new-tab button icons. Let me know if you prefer handling those in a separate bug.
Flags: needinfo?(shorlander)
Assignee: nobody → dao
Attached patch patch (WIP) (obsolete) — Splinter Review
Attached patch patchSplinter Review
I updated the generic close button, not just the tab close button, since we want touch-friendliness everywhere.

Also made this change on Windows 8 since touch screens are more common there than for older Windows versions.
Attachment #8635241 - Attachment is obsolete: true
Attachment #8635300 - Flags: review?(jaws)
No longer blocks: 1166442
Comment on attachment 8635300 [details] [diff] [review]
patch

Review of attachment 8635300 [details] [diff] [review]:
-----------------------------------------------------------------

untested but the patch looks good. r=me
Attachment #8635300 - Flags: review?(jaws) → review+
Summary: Update tab close button and new tab button icons on Windows 10 → Update generic close icon and new tab button icon on Windows 10
https://hg.mozilla.org/mozilla-central/rev/ac6f2fb6777e
Status: NEW → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 42
Flags: qe-verify+
Depends on: 1185295
No longer depends on: 1185295
Depends on: 1185889
Comment on attachment 8635300 [details] [diff] [review]
patch

Approval Request Comment
[Feature/regressing bug #]: windows 10
[User impact if declined]: aesthetics and touch-friendliness
[Describe test coverage new/current, TreeHerder]: n/a
[Risks and why]: increasing the icon size for the generic close-icon class is a little bit scary, but this important enough and has baked long enough that we should uplift it
[String/UUID change made/needed]: none
Attachment #8635300 - Flags: approval-mozilla-beta?
Attachment #8635300 - Flags: approval-mozilla-aurora?
Comment on attachment 8635300 [details] [diff] [review]
patch

This fix has been on m-c for 5 days. Let's get it into beta7 and see if any issues shake out. Beta+ Aurora+
Attachment #8635300 - Flags: approval-mozilla-beta?
Attachment #8635300 - Flags: approval-mozilla-beta+
Attachment #8635300 - Flags: approval-mozilla-aurora?
Attachment #8635300 - Flags: approval-mozilla-aurora+
QA Contact: cornel.ionce
Confirming this fix on Windows 10 64-bit using:
- latest Nightly, build ID: 20150726030217;
- latest Aurora, build ID: 20150726004010;
- Firefox 40 beta 7, build ID: 20150723165742.

Ran into issue 1185889 on DevEdition.
Depends on: 1188291
Depends on: 1191468
No longer depends on: 1191468
You need to log in before you can comment on or make changes to this bug.