Update generic close icon and new tab button icon on Windows 10

VERIFIED FIXED in Firefox 40

Status

()

P1
normal
VERIFIED FIXED
4 years ago
3 years ago

People

(Reporter: dao, Assigned: dao)

Tracking

(Blocks: 3 bugs)

Trunk
Firefox 42
Unspecified
Windows 10
Points:
---
Dependency tree / graph
Bug Flags:
qe-verify +

Firefox Tracking Flags

(firefox39 unaffected, firefox40 verified, firefox41 verified, firefox42 verified)

Details

Attachments

(9 attachments, 1 obsolete attachment)

572 bytes, image/png
Details
1.13 KB, image/png
Details
598 bytes, image/png
Details
1.18 KB, image/png
Details
87 bytes, image/png
Details
99 bytes, image/png
Details
110 bytes, image/png
Details
142 bytes, image/png
Details
29.75 KB, patch
jaws
: review+
Details | Diff | Splinter Review
(Assignee)

Description

4 years ago
Notably, this will make the tab close button larger for touch-friendliness.
(Assignee)

Comment 1

4 years ago
needinfo for the new images
Flags: needinfo?(shorlander)
(Assignee)

Comment 4

4 years ago
We also need inverted variants.

And we need the new-tab button icons. Let me know if you prefer handling those in a separate bug.
Flags: needinfo?(shorlander)
(Assignee)

Updated

4 years ago
Assignee: nobody → dao
(Assignee)

Comment 11

4 years ago
Posted patch patch (WIP) (obsolete) — Splinter Review
(Assignee)

Comment 12

4 years ago
Posted patch patchSplinter Review
I updated the generic close button, not just the tab close button, since we want touch-friendliness everywhere.

Also made this change on Windows 8 since touch screens are more common there than for older Windows versions.
Attachment #8635241 - Attachment is obsolete: true
Attachment #8635300 - Flags: review?(jaws)
(Assignee)

Updated

4 years ago
No longer blocks: 1166442
Comment on attachment 8635300 [details] [diff] [review]
patch

Review of attachment 8635300 [details] [diff] [review]:
-----------------------------------------------------------------

untested but the patch looks good. r=me
Attachment #8635300 - Flags: review?(jaws) → review+
(Assignee)

Updated

4 years ago
Summary: Update tab close button and new tab button icons on Windows 10 → Update generic close icon and new tab button icon on Windows 10
https://hg.mozilla.org/mozilla-central/rev/ac6f2fb6777e
Status: NEW → RESOLVED
Last Resolved: 4 years ago
status-firefox42: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 42
(Assignee)

Updated

4 years ago
Flags: qe-verify+

Updated

4 years ago
Depends on: 1185295

Updated

4 years ago
No longer depends on: 1185295

Updated

4 years ago
Depends on: 1185889
(Assignee)

Comment 16

4 years ago
Comment on attachment 8635300 [details] [diff] [review]
patch

Approval Request Comment
[Feature/regressing bug #]: windows 10
[User impact if declined]: aesthetics and touch-friendliness
[Describe test coverage new/current, TreeHerder]: n/a
[Risks and why]: increasing the icon size for the generic close-icon class is a little bit scary, but this important enough and has baked long enough that we should uplift it
[String/UUID change made/needed]: none
Attachment #8635300 - Flags: approval-mozilla-beta?
Attachment #8635300 - Flags: approval-mozilla-aurora?
status-firefox39: --- → unaffected
status-firefox40: --- → affected
Comment on attachment 8635300 [details] [diff] [review]
patch

This fix has been on m-c for 5 days. Let's get it into beta7 and see if any issues shake out. Beta+ Aurora+
Attachment #8635300 - Flags: approval-mozilla-beta?
Attachment #8635300 - Flags: approval-mozilla-beta+
Attachment #8635300 - Flags: approval-mozilla-aurora?
Attachment #8635300 - Flags: approval-mozilla-aurora+
QA Contact: cornel.ionce
Confirming this fix on Windows 10 64-bit using:
- latest Nightly, build ID: 20150726030217;
- latest Aurora, build ID: 20150726004010;
- Firefox 40 beta 7, build ID: 20150723165742.

Ran into issue 1185889 on DevEdition.
Status: RESOLVED → VERIFIED
status-firefox40: fixed → verified
status-firefox41: fixed → verified
status-firefox42: fixed → verified
(Assignee)

Updated

4 years ago
Depends on: 1188291
Depends on: 1191468
(Assignee)

Updated

4 years ago
No longer depends on: 1191468
You need to log in before you can comment on or make changes to this bug.