1260612 - Run away Speech Synthesizer can speak for ever

Status: VERIFIED FIXED

(Core :: Web Speech, defect)

Description

[Biju]

Attachment: speak_for_ever.html

This a kind of "eviltraps" (Bug 432687)

A site can keep talking/speaking for ever (long long time). 
And there will be now way for user to stop it.

Follow the instructions in speak_for_ever.html

Comment 1

[Makoto Kato [:m_kato]]

(In reply to Biju from comment #0)
> Created attachment 8736122 [details]
> speak_for_ever.html
> 
> This a kind of "eviltraps" (Bug 432687)
> 
> A site can keep talking/speaking for ever (long long time). 
> And there will be now way for user to stop it.
> 
> Follow the instructions in speak_for_ever.html

What Firefox version and platform do you test?

Comment 2

[:Gijs (he/him)]

I can reproduce on Windows 8, at least. Eitan?

Comment 3

[Eitan Isaacson [:eeejay]]

Attachment: MozReview Request: Bug 1260612 - Cancel speech entirely (including queue) when window is destroyed. r?smaug

Review commit: https://reviewboard.mozilla.org/r/43309/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/43309/

Comment 4

[Eitan Isaacson [:eeejay]]

Yup, I can reproduce and can fix.

Comment 5

[Olli Pettay [:smaug][[e-mail]](vacation until July 14)]

Comment on attachment 8736464 [details]
MozReview Request: Bug 1260612 - Cancel speech entirely (including queue) when window is destroyed. r?smaug

https://reviewboard.mozilla.org/r/43309/#review39925

Comment 6

[Biju]

Is this fixed on trunk? if not, when can we expect. Thanks for all great work.

Comment 7

[Eitan Isaacson [:eeejay]]

(In reply to Biju from comment #6)
> Is this fixed on trunk? if not, when can we expect. Thanks for all great
> work.

I believe it is fixed in nighty, just verified. Do you still see this issue?

Comment 8

[:Gijs (he/him)]

The fix in this patch seems to have landed as part of bug 1254378, and should be in Nightlies later than April 2nd.

Biju, can you confirm it's fixed for you?

Comment 9

[Biju]

Test Result : PASS
Tested on 48.0a1 (2016-04-05) and I no longer see this issue. 

BTW, I see this issue resolved since two days, but was confused after seeing the status of this bug is still showing NEW.

Another question.
I see narrate button/icon only on pages with "read mode".
And all web pages dont get to switch to read mode option.
I wish there is narrate icon visible for every page, as well as narrate context menu item. So that I can select some text content on the page, and then click narrate button, or use right click context menu to read it.

Do we have a bug asking for selection narrate icon/menu ?

Comment 10

[:Gijs (he/him)]

Thanks for confirming this has been addressed!

(In reply to Biju from comment #9)
> I see narrate button/icon only on pages with "read mode".
> And all web pages dont get to switch to read mode option.
> I wish there is narrate icon visible for every page, as well as narrate
> context menu item. So that I can select some text content on the page, and
> then click narrate button, or use right click context menu to read it.
> 
> Do we have a bug asking for selection narrate icon/menu ?

Eitan might know.

Comment 11

[Eitan Isaacson [:eeejay]]

(In reply to Biju from comment #9)
> Test Result : PASS
> Tested on 48.0a1 (2016-04-05) and I no longer see this issue. 
> 
> BTW, I see this issue resolved since two days, but was confused after seeing
> the status of this bug is still showing NEW.
> 
> Another question.
> I see narrate button/icon only on pages with "read mode".
> And all web pages dont get to switch to read mode option.
> I wish there is narrate icon visible for every page, as well as narrate
> context menu item. So that I can select some text content on the page, and
> then click narrate button, or use right click context menu to read it.
> 
> Do we have a bug asking for selection narrate icon/menu ?

We don't have any specific plan for that yet, although that may be a good future addition. I decided to go with reader mode first because the content is already sanitized and decluttered from items and text you don't want spoken.

Comment 12

[Biju]

(In reply to Eitan Isaacson [:eeejay] from bug comment #11)

Created Bug 1262738

Comment 13

[Camelia Badau [:cbadau], Desktop QA]

Verified fixed on Windows 7 64bit, Ubuntu 14.04 64bit and Mac OSX 10.10.5 using Firefox 48 Beta 2, buildID: 20160620091522 (with "media.webspeech.synth.enabled" set to true).