432687 - (eviltraps) [meta] Protect users from websites that trap them or destroy their experience

Status: NEW

(Core :: DOM: Core & HTML, task, P3)

Description

[Saïvann Carignan]

User-Agent:       Mozilla/5.0 (X11; U; Linux x86_64; fr; rv:1.9b5) Gecko/2008041515 Firefox/3.0b5
Build Identifier: Mozilla/5.0 (X11; U; Linux x86_64; fr; rv:1.9b5) Gecko/2008041515 Firefox/3.0b5

There are javascript based websites that are traps which cause Firefox to show nasty content and stop answering user requests. Firefox behavior in these situations is really bad since it obey to the code and stop to listen to the user, it's not possible to close, change the configuration, close the tab or even exit Firefox!

A good example is this website (WARNING, this website shows pornographic content and you will not be able to close it without killing Firefox :

www.mylazysundays.com

Reproducible: Always

Steps to Reproduce:
1.
2.
3.
Actual Results:  
Impossible to move/maximize/close the Firefox window, impossible to change the website, impossible to close the tab and impossible to modify the Firefox configuration.

Expected Results:  
Firefox should accept the user request to change the website or to close the website, and should not accept javascript code which cause Firefox main window to run on the screen and refuse the mouse.

Even if it's javascript, it's a major issue that Firefox refuse any user request in these conditions. There is no reason to justify the user losing control over Firefox.

Firefox should really give the possibility to the user to exit this webpage.

Comment 1

[Jesse Ruderman]

This evil site does several things to get in the way of closing it:

* Tries to move the window around (bug 144069, bug 186708).

* Dozens of alerts in onbeforeunload (bug 391834 would prevent these from appearing; bug 59314 or bug 61098 would let you escape).

* Disables keyboard shortcuts such as Cmd+W.  Perhaps Firefox should not allow sites to cancel certain keyboard shortcuts.

Comment 2

[Saïvann Carignan]

Then if this website use multiples bugs in Firefox which are already known and have a correct priority, I believe that this bug report should be closed, what do you think about it?

Comment 3

[Jesse Ruderman]

Sure, it could be closed as INVALID, or it could be used as a metabug.  We should make sure there's a bug on the keyboard shortcut issue, too.

Comment 4

[cmtalbert]

I like the idea of using this as a meta bug.  Transforming for that end.
--> Confirmed
--> Setting dependencies
--> And I'll file the follow on bug for the Cmd W redirect.

Comment 5

[cmtalbert]

Added bug 435501 for the keyboard re-mapping issue.

Comment 6

[dpk]

Clint, here's a bug for the keyboard re-mapping issue: bug 340902 (which was itself a duplicate of older bugs). It's marked resolved but I cannot personally confirm that it is a resolved matter.

Comment 7

[-]

I just got tricked into visiting this website. Until now I never saw any purpose for the Noscript add-on, but Mylazysundays made me install it.

I still think Firefox should react on such infinite Javascript loops. For example, if a website shows a few alert windows, after three to five of them another popup should show up and ask "This seems to be an infinite Javascript loop. Do you want to abort it? [yes] [no, continue]".

This might be useful for computer illiterate people who have no clue how to use Noscript. Also, is there nobody who knows the webmaster personally to pay him a visit?

Comment 10

[arimfe]

google chrome and opera both deal with this issue perfectly.
chrome has a checkbox in the popup diaglog which prevents further dialogs to be created.
opera makes the user's "Close tab" command ABSOLUTE and it overwrites any javascript on the website.

Comment 11

[funkydude87]

Thanks

The fact that such problems have been around since 2000 with no fix is enough to kill Fx for me.

I will be dropping it and recommending Chrome as the safe web browser from now on.

Comment 14

[Paul Rubin]

Even blogspot is trapping the browser these days (onclose = "are you sure you want to navigate away from this page?", though at least it lets you exit). 

It is a bug that such an event even exists.  Closing a tab should "kill -9" the contents.  It should not post any type of event to javascript on the page or count how many alerts the page has popped.  It should just kill the page completely and instantly, along with all alert dialogs from that page.

Comment 15

[u49640]

(In reply to comment #14)
> Even blogspot is trapping the browser these days (onclose = "are you sure you
> want to navigate away from this page?", though at least it lets you exit). 

Some of those Events should be ok. Like asking the user if he wants to save (submit) entered text on the page
(like a program asking if the user wants to save a file when it closes)

So the OnClose Event shouldn’t be kill −9, but more like kill −15 (SIGTERM). (but with an option to just „SIGKILL“ the page, like an app that doesn’t respond to SIGTERM)

Comment 17

[Jesse Ruderman]

My rant about scareware in bug 455078 comment 5 might be relevant.

Comment 20

[Jonathan]

Safari by default warns you before closing a window where text is entered on a page.

Comment 21

[Carlos Alén Silva]

FWIW: I survive www.mylazysundays.com and similar sites thanks to AlertCheck https://addons.mozilla.org/en-US/firefox/addon/13176
This extension does something similar to what's proposed in comment #7 and Chrome's behavior cited in comment #10

Comment 22

[Carlos Alén Silva]

(In reply to comment #21)

Another extension that solves this problem: RightToClick: https://addons.mozilla.org/en-US/firefox/addon/12572

Comment 24

[Nathan]

(In reply to comment #22)

A better fix, as the developers here don't seem to care:
http://www.google.com/chrome

Comment 28

[Kevin]

This bug should be resolved in Seamonkey.  I looked at NoScript and AlertCheck.  These are too unreliable or tedious, plus problematic updates. Who wants to spend hours learning how to secure a "secure" webbrowser?  I disagree with Comment 15.  Some kind of verify popup is fine in a program on the user's computer with the user's content, but in the context of the web, where the user does not have control over content, it should never be possible for the user to lose control of the program.  Secondly, if NoScript and AlertCheck can be written, then it should be possible for the developers to incorporate the same functionality.  I just hope something will be done.  Thanks

Comment 29

[Biju]

(In reply to comment #28)
We have bug 578828 for what your asking

Comment 31

[Virtual_ManPL [:Virtual] 🇵🇱 - (please needinfo? me - so I will see your comment/reply/question/etc.)]

Awww, still not fixed...

Can't we temporary set to false default settings of dom.disable_window_move_resize in about:config like I mentioned in bug #648959 ?
Because with this option we have some control. Also Opera and Chrome behave that way too.

Comment 32

[Virtual_ManPL [:Virtual] 🇵🇱 - (please needinfo? me - so I will see your comment/reply/question/etc.)]

(In reply to comment #31)
> Awww, still not fixed...
> 
> Can't we temporary set to false default settings of
> dom.disable_window_move_resize in about:config

I mean set it to true ;p

Comment 33

[David Vo [:auscompgeek]]

(In reply to comment #31)
> Awww, still not fixed...
> Can't we temporary set to true default settings of
> dom.disable_window_move_resize in about:config like I mentioned in bug 648959?
> Because with this option we have some control. Also Opera and Chrome behave
> that way too.

See comment 1. That pref also has a UI: Tools > Options > Content > Advanced button next to "Enable JavaScript". Popups should be able to resize and move themselves.

Comment 34

[Virtual_ManPL [:Virtual] 🇵🇱 - (please needinfo? me - so I will see your comment/reply/question/etc.)]

Yep, I know, but this bugs are VERY OLD.
And pasting link to location bar and opening it isn't exactly the popup, because it didn't open any new window.

Opera and Chrome have this disabled as I see, so can't we do the same as workaround until some patch with detection of popups will land ?
This will prevent us for prank sites without option to close tab/window, because keyboard shortcuts are disabled and all application running from mouse pointer.

Odd, that it's still not fixed ;p

Comment 35

[Adam Muntner [:adamm] (use NEEDINFO)]

Can someone who is more familiar with firefox internals than me comment on 

https://bugzilla.mozilla.org/show_bug.cgi?id=909615#c10

please?

In particular, the user's comment, "The problem is that Firefox works in a totally unexpected way. The user clicked on the tab close button and when a confirmation dialogue appears he expects that this is for confirming the tab close action. I don't see any valid reason for Firefox to disrespect the users wish in this regard. I would be a different thing if the user asked to just close a specific (i)frame but I don't think that Firefox even allows that?"

Comment 38

[alex_mayorga]

¡Hola!

FWIW http://protectcheckerextt.biz/ff/ does some evil trickery IMHO.

¡Gracias!
Alex

Comment 39

[Marco Castelluccio [:marco]]

(In reply to alex_mayorga from comment #38)
> ¡Hola!
> 
> FWIW http://protectcheckerextt.biz/ff/ does some evil trickery IMHO.
> 
> ¡Gracias!
> Alex

Can you file a new bug blocking this bug?

Comment 40

[Johann Hofmann [:johannh]]

(In reply to Marco Castelluccio [:marco] from comment #39)
> (In reply to alex_mayorga from comment #38)
> > ¡Hola!
> > 
> > FWIW http://protectcheckerextt.biz/ff/ does some evil trickery IMHO.
> > 
> > ¡Gracias!
> > Alex
> 
> Can you file a new bug blocking this bug?

I think the main evil-trappery issue with that site was fixed with bug 1412559.

Comment 41

[alex_mayorga]

¡Hola Johann!

The experience at http://protectcheckerextt.biz/ff/ is still somewhat disheartening on today's Nightly IMHO, please see https://www.screencast.com/t/jEb78Gor

http://www.britishxcuisine.com/ is another of those fake sites that was affecting a user enough to file a SuMo question at https://support.mozilla.org/questions/1200872

I'm pretty sure I reported that 1st one via https://www.mozilla.org/en-US/about/legal/fraud-report/ https://www.phishtank.com/phish_detail.php?phish_id=5404958 and https://safebrowsing.google.com/safebrowsing/report_phish/ yet that site is still up today.

How can this be improved?

¡Gracias!
Alex

Comment 42

[Johann Hofmann [:johannh]]

Unfortunately I don't really know the inner workings of our fraud reporting or SafeBrowsing. We're working on the rest of these annoyances in the dependencies of this bug.

Comment 43

[kernp25]

https://spaming4-info.ml

This site is also really bad!

Comment 44

[kernp25]

It can lock the Browser!

Comment 45

[kernp25]

The url should be:
https://spaming4-info.ml/error09.com/main3/

Very dangerous!

Comment 47

[Zitronella]

Attachment: blocked-firefox_3.mp4

this site: h***s://multimilltracks.com/as/de/index.php?clickid=2e64e7sirocmya5b&t1=X2jEBmb1nDc&t2=65681&t3=722534&t4=FIREFOX_68.0&t5=77.191.140.146&t6=flashx.pw&t7={t7}&t8={t8}&t9={t9}&t10={t10}&uclick=7sirocmy (i assume it needs some cookies and maybe same IP is also necessary ) block my firefox

Comment 48

[Johann Hofmann [:johannh]]

(In reply to Zitronella from comment #47)

Created attachment 9099508 [details]
blocked-firefox_3.mp4

this site: h***s://multimilltracks.com/as/de/index.php?clickid=2e64e7sirocmya5b&t1=X2jEBmb1nDc&t2=65681&t3=722534&t4=FIREFOX_68.0&t5=77.191.140.146&t6=flashx.pw&t7={t7}&t8={t8}&t9={t9}&t10={t10}&uclick=7sirocmy (i assume it needs some cookies and maybe same IP is also necessary ) block my firefox

Thanks for reporting the site, the biggest part of it is bug 1571003.

Comment 49

[[e-mail]]

Depends on: https://bugzilla.mozilla.org/show_bug.cgi?id=1604720