1260644 - Use UniquePLArenaPool to manage PLArenaPools in PSM

Status: RESOLVED FIXED

(Core :: Security: PSM, defect)

Description

[:Cykesiopka]

UniquePLArenaPools should be used instead of:
 - ScopedPLArenaPool, because Scoped.h is deprecated.
 - Manual PLArenaPool pointers, because manual memory management can be error prone.

Comment 1

[:Cykesiopka]

Attachment: MozReview Request: Bug 1260644 - Use UniquePLArenaPool to manage PLArenaPools in PSM.

Review commit: https://reviewboard.mozilla.org/r/44243/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/44243/

Comment 2

[Dana Keeler (she/her) (use needinfo) [:keeler]]

Comment on attachment 8738027 [details]
MozReview Request: Bug 1260644 - Use UniquePLArenaPool to manage PLArenaPools in PSM.

https://reviewboard.mozilla.org/r/44243/#review41083

LGTM.

::: security/manager/ssl/nsDataSignatureVerifier.cpp:44
(Diff revision 1)
>  nsDataSignatureVerifier::VerifyData(const nsACString & aData,
>                                      const nsACString & aSignature,
>                                      const nsACString & aPublicKey,
>                                      bool *_retval)
>  {
>      // Allocate an arena to handle the majority of the allocations

This function should be 2-space indented if you feel like fixing that too. Not a big deal, though.

::: security/manager/ssl/nsDataSignatureVerifier.cpp:65
(Diff revision 1)
>      if (!pki) {
> -        PORT_FreeArena(arena, false);
>          return NS_ERROR_FAILURE;
>      }
>      SECKEYPublicKey *publicKey = SECKEY_ExtractPublicKey(pki);
>      SECKEY_DestroySubjectPublicKeyInfo(pki);

Hmmm - looks like this function could benefit from some other UniqueType conversions (that can be a follow-up, though).

Comment 3

[:Cykesiopka]

https://reviewboard.mozilla.org/r/44243/#review41083

Thanks for the review!

I'll address the things noted below in Bug 1029173.

Comment 4

[:Cykesiopka]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=288ac9d04b8f435a379c64acedc6c7228902c8fe

Comment 5

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/63c6be19398d

Comment 6

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/63c6be19398d