1260916 - The xpcshell tests with artifact builds are missing target binaries in dist/bin

Status: RESOLVED FIXED

(Firefox Build System :: General, defect)

Comment 1

[Nick Alexander :nalexander [he/him]]

Attachment: MozReview Request: Bug 1260916 - Install target test artifacts on Fennec. r?chmanchester

Matt, could you try this?

Review commit: https://reviewboard.mozilla.org/r/43321/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/43321/

Comment 2

[Nick Alexander :nalexander [he/him]]

Comment on attachment 8736501 [details]
MozReview Request: Bug 1260916 - Install target test artifacts on Fennec. r?chmanchester

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/43321/diff/1-2/

Comment 3

[Chris Manchester (limited bugmail, email directly)]

Comment on attachment 8736501 [details]
MozReview Request: Bug 1260916 - Install target test artifacts on Fennec. r?chmanchester

https://reviewboard.mozilla.org/r/43321/#review40541

As discussed on irc, I'm having trouble getting tests to run with this patch ("CANNOT LINK EXECUTABLE: could not load library "libnss3.so" needed by "/data/local/xpcb/xpcshell"; caused by "libnss3.so" has bad ELF magic"). The objdir and package look somewhat sane (libnss3.so exists), so I'm not sure what's going wrong, but someone should get this to a known working state before we land.

Comment 4

[Ethan Glasser-Camp (:glasserc)]

Attachment: Bug 1260916 - Support running tests from artifact builds,

This should fetch the artifacts necessary to run tests and extract
them correctly.

While we're here, clean up some other regular expressions which
weren't escaped consistently.

Also, if you're going to use backslashes in literal strings because of
regular expressions, r-strings are probably better. (Otherwise you
should double all the backslashes.)

All the same, try to stop short of going full PEP8 without express
permission.

Review commit: https://reviewboard.mozilla.org/r/103046/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/103046/

Comment 5

[Ethan Glasser-Camp (:glasserc)]

I was able to get the tests to run at all using the attached patch, although not all of them ran successfully (due, I think, to other reasons). While I was here I decided to fix the inconsistent escaping of regular expressions and the fact that backslashes weren't being escaped -- if you'd prefer that I undo those changes, or make them as a separate commit, just let me know.

Comment 6

[Nick Alexander :nalexander [he/him]]

Comment on attachment 8824621 [details]
Bug 1260916 - Support running tests from artifact builds,

https://reviewboard.mozilla.org/r/103046/#review103898

Looks good to me!  I'll try to test this locally but it shouldn't regress anything, so feel free to land without another tester.

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/469d1284a93a
Support running tests from artifact builds, r=nalexander

Comment 8

[Geoff Brown [:gbrown]]

Comment on attachment 8824621 [details]
Bug 1260916 - Support running tests from artifact builds,

https://reviewboard.mozilla.org/r/103046/#review104282

I know very little about artifact builds, so reserving r+, but this looks fine to me.

I tried it out locally and it worked fine for me: I was able to run 'mach xpcshell-test netwerk/test/unit' on an artifact build on an Android 4.3 phone.

Comment 9

[Geoff Brown [:gbrown]]

Comment on attachment 8824621 [details]
Bug 1260916 - Support running tests from artifact builds,

Thanks!

Comment 10

[Chris Manchester (limited bugmail, email directly)]

Comment on attachment 8824621 [details]
Bug 1260916 - Support running tests from artifact builds,

https://reviewboard.mozilla.org/r/103046/#review104388

Nick's r+ is sufficient here. Thank you for the patch!

Comment 11

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/469d1284a93a