1332911 - android-api-15-opt test package location doesn't match available packages ("Tried XXX pushheads, no built artifacts found.")

Status: RESOLVED FIXED

(Firefox Build System :: Android Studio and Gradle Integration, defect, P1)

Description

[Andrzej Hunt :ahunt]

Artifact builds seem to be broken today:

0:22.62 You should consider upgrading via the 'pip install --upgrade pip' command.
 0:23.07 Attempting to find a pushhead containing d5343b0f7e6a9619dfdf333d259cff6b4f773bff on mozilla-central.
 0:23.07 Attempting to find a pushhead containing d5343b0f7e6a9619dfdf333d259cff6b4f773bff on integration/mozilla-inbound.
 0:23.07 Attempting to find a pushhead containing d5343b0f7e6a9619dfdf333d259cff6b4f773bff on releases/mozilla-aurora.
 0:24.60 Retrieving the last 50 pushheads starting with id 85995 on integration/mozilla-inbound
 0:24.60 Retrieving the last 50 pushheads starting with id 31240 on mozilla-central
 2:16.42 Tried 61 pushheads, no built artifacts found.
 2:16.44 make[4]: *** [recurse_artifact] Error 1
 2:16.45 make[3]: *** [artifact] Error 2
 2:16.45 make[2]: *** [default] Error 2
 2:16.45 make[1]: *** [realbuild] Error 2
 2:16.45 make: *** [build] Error 2
 2:16.47 0 compiler warnings present.


I've verified the artifacts are present, in fact I'm even able to access the corresponding apk directly (corresponding to d5343b0f7e6a9619dfdf333d259cff6b4f773bff)
https://queue.taskcluster.net/v1/task/Jvg6kaWxTNS_4YBXyhaiYA/artifacts/public%2Fbuild%2Ftarget.apk


I've tried to debug and not gotten too far, but for some reason moving the return statement in TaskCache.artifact_urls() earlier is enough to get artifact builds working (patch will be attached in the next comment). Anything I add after the loop in question doesn't get run, but returning in the loop is enough to "fix" the build. I don't yet know enough python to understand why.

Comment 1

[Andrzej Hunt :ahunt]

Attachment: Patch that fixes artifacts locally

Here's the patch that fixes things locally. (For some reason I can't push to reviewboard where I'm currently located, even though plain hg works fine.)

Comment 2

[Andrzej Hunt :ahunt]

It turns out we're actually raising an error in find_candidate_artifacts (which the loop iterates over), from:
https://dxr.mozilla.org/mozilla-central/source/python/mozbuild/mozbuild/artifacts.py#168
"Expected tests archive matching "{re}", but '
'found none!'.format(re=self._tests_re)"

That then gets swallowed in find_pushhead_artifacts():
https://dxr.mozilla.org/mozilla-central/source/python/mozbuild/mozbuild/artifacts.py#930

And that seems to be caused by the test archive location defined at:
https://dxr.mozilla.org/mozilla-central/source/python/mozbuild/mozbuild/artifacts.py#442
Not corresponding to any archives at:
https://tools.taskcluster.net/index/artifacts/#gecko.v2.mozilla-central.latest.mobile/gecko.v2.mozilla-central.latest.mobile.android-api-15-opt

Comment 3

[Andrzej Hunt :ahunt]

Attachment: Bug 1332911 - Update android-opt artifact test archive filename

Review commit: https://reviewboard.mozilla.org/r/106364/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/106364/

Comment 4

[Nick Alexander :nalexander [he/him]]

Comment on attachment 8829221 [details]
Bug 1332911 - Update android-opt artifact test archive filename

https://reviewboard.mozilla.org/r/106364/#review107324

If it works for you, it works for me.  Thanks for jumping on this, ahunt!

Comment 5

[Andrzej Hunt :ahunt]

Comment on attachment 8829221 [details]
Bug 1332911 - Update android-opt artifact test archive filename

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/106364/diff/1-2/

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/83352cf64406
Update android-opt artifact test archive filename r=nalexander

Comment 7

[Phil Ringnalda (:philor)]

https://hg.mozilla.org/mozilla-central/rev/83352cf64406