1261013 - Remove the System Messages API

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, defect)

Description

[Ben Francis [:benfrancis]]

The handling of system messages is registered at app install time from a mozApp manifest. As we are removing mozApps we also need to remove the System Messages API.

https://developer.mozilla.org/en-US/docs/Mozilla/Firefox_OS/API/Navigator/mozSetMessageHandler

Comment 1

[[:fabrice] Fabrice Desré]

Attachment: system-messages.patch

With this patch we simply relay all internal calls to sendMessage(), broadcastMessage() and registerPage() to the system app.

It's hard to test because all the users are broken...

Comment 2

[:gerard-majax]

Comment on attachment 8742619 [details] [diff] [review]
system-messages.patch

Review of attachment 8742619 [details] [diff] [review]:
-----------------------------------------------------------------

Just a comment about the priorities, but it looks all good :)

::: dom/ipc/ContentParent.cpp
@@ +878,5 @@
>    if (!browserFrame) {
>      return PROCESS_PRIORITY_FOREGROUND;
>    }
>  
> +  return PROCESS_PRIORITY_FOREGROUND;

There is a comment a the start of the function stating: "Frames with mozapptype == critical which are expecting a system message FOREGROUND_HIGH priority". I guess we should remove that statement and even simplify the end of this function because all the return case after the one for "PROCESS_PRIORITY_FOREGROUND_KEYBOARD" are just "PROCESS_PRIORITY_FOREGROUND".

Comment 3

[:gerard-majax]

Let's see the result

Comment 4

[:gerard-majax]

So far on mulet I can see the API is not there anymore and nothing obviously breaks.

Comment 5

[:gerard-majax]

And the same on device :)

Comment 6

[:gerard-majax]

https://hg.mozilla.org/projects/pine/rev/bd4b256765a4