1261778 - [RTL] The left and right keyboard navigation of tree nodes are wrong direction in RTL locales

Status: VERIFIED FIXED

(Toolkit :: UI Widgets, defect)

Description

[magicp]

User Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:45.0) Gecko/20100101 Firefox/45.0
Build ID: 20160315153207

Steps to reproduce:

1. Start any versions Firefox with RTL locales (e.g. arabic)
2. Go to any tree nodes (e.g. Bookmarks sidebar)
3. Hit the left and right key on a collapsed node


Actual results:

Left key: RTL tree node (twisty) is closed.
Right key: RTL tree node is opened.


Expected results:

Left key: RTL tree node (twisty) should be opened.
Right key: RTL tree node should be closed.

Comment 1

[Andrew Overholt [:overholt]]

Should this perhaps be a XUL issue? Are regular web pages able to do such navigation without it being custom JS handlers?

Ehsan, do you have RTL thoughts (sorry to bug you)?

Comment 2

[(no longer active)]

Yes, this is a XUL issue, more specifically a bug in the VK_LEFT/VK_RIGHT keydown handlers in tree.xml.  Should be pretty simple to fix.

Comment 3

[Tim Nguyen :ntim]

Split the devtools issue off to bug 1310055 since DevTools don't use the native XUL tree.

Comment 4

[Itiel]

Attachment: Bug 1261778 - [RTL] Fix the left and right keyboard navigation direction of tree nodes r?bgrins

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/60d2e1c34454
[RTL] Fix the left and right keyboard navigation direction of tree nodes r=bgrins

Comment 6

[Cristian Brindusan [:cbrindusan]]

https://hg.mozilla.org/mozilla-central/rev/60d2e1c34454