1261819 - Create summary description for "Notifications" category

Status: VERIFIED FIXED

(Firefox for Android Graveyard :: Settings and Preferences, defect)

Description

[Teodora Vermesan (:TeoVermesan)]

Steps to reproduce:
1. Go to Menu -> Settings 

Actual results:
- There is no summary description under "Notifications" category

Expected results:
- A summary should be displayed to inform users about new category in settings menu

Comment 1

[Sebastian Kaspari (:sebastian; :pocmo)]

We left this empty intentionally during the work week. Now we are starting to fill the category with settings. What's your take now, antlam?

Comment 2

[Anthony Lam (:antlam) Find me, @antlam on Slack!]

I think we can start with the following:

Notifications
New features, website updates

Comment 3

[Sebastian Kaspari (:sebastian; :pocmo)]

(In reply to Anthony Lam (:antlam) from comment #2)
> Notifications
> New features, website updates

Is it a problem that currently not everyone will have "website updates" in the settings? (Only 75% of Nightly users)

Comment 4

[Sebastian Kaspari (:sebastian; :pocmo)]

Attachment: MozReview Request: Bug 1261819 - (Pre) Move and replace: xml-v11/preferences.xml -> preferences.xml. r?grisha

Review commit: https://reviewboard.mozilla.org/r/44305/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/44305/

Comment 5

[Sebastian Kaspari (:sebastian; :pocmo)]

Attachment: MozReview Request: Bug 1261819 - Add summary to "Notifications" setting. r?grisha

Review commit: https://reviewboard.mozilla.org/r/44307/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/44307/

Comment 6

[:Grisha Kruglov]

Comment on attachment 8738099 [details]
MozReview Request: Bug 1261819 - (Pre) Move and replace: xml-v11/preferences.xml -> preferences.xml. r?grisha

https://reviewboard.mozilla.org/r/44305/#review40995

::: mobile/android/base/resources/xml/preferences.xml:8
(Diff revision 1)
>     - License, v. 2.0. If a copy of the MPL was not distributed with this
>     - file, You can obtain one at http://mozilla.org/MPL/2.0/. -->
>  
> -<!-- Preferences screen for pre-v11 Android devices that do not support
> -     PreferenceFragment or ActionBar. Preference changes here should be mirrored
> -     to xml-v11/preferences.xml. -->
> +<!-- Phone v11+ only: Sync is a top-level menu item.
> +     See xml-v11/preference_headers.xml for tablet layout.
> +     Preference changes here should be mirrored to xml/preferences.xml.in. -->

Do we still need the comment RE mirroring? or did you mean strings.xml.in?

Comment 7

[:Grisha Kruglov]

Comment on attachment 8738100 [details]
MozReview Request: Bug 1261819 - Add summary to "Notifications" setting. r?grisha

https://reviewboard.mozilla.org/r/44307/#review40997

Looks good!

Comment 8

[Sebastian Kaspari (:sebastian; :pocmo)]

(In reply to :Grisha Kruglov from comment #6)
> Do we still need the comment RE mirroring? or did you mean strings.xml.in?

Good point! I moved the file but didn't look if this obsoletes some of the comments.

Comment 9

[Sebastian Kaspari (:sebastian; :pocmo)]

https://hg.mozilla.org/integration/fx-team/rev/f6912798f257f0dc03a00795e57b0e65d404152c
Bug 1261819 - (Pre) Move and replace: xml-v11/preferences.xml -> preferences.xml. r=grisha

https://hg.mozilla.org/integration/fx-team/rev/019158692d55fbcae2786e9afe510cf972b9535f
Bug 1261819 - Add summary to "Notifications" setting. r=grisha

Comment 10

[Sebastian Kaspari (:sebastian; :pocmo)]

https://hg.mozilla.org/integration/fx-team/rev/c9e9878330240c437f0a3a2bca4cce608b5ef33f
Bug 1261819 - Follow-up (lint bustage): Remove unused resource: android_package_name. r=me

Comment 11

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/f6912798f257
https://hg.mozilla.org/mozilla-central/rev/019158692d55
https://hg.mozilla.org/mozilla-central/rev/c9e987833024

Comment 12

[Sorina Florean [:sflorean]]

Verified as fixed in build Aurora 48.0a2 (2016-05-26).
Device: Nexus 5 (Android 6.0.1) and LG G4 (Android 5.1).