Closed Bug 1247788 Opened 4 years ago Closed 4 years ago

Add "Notifications" in Settings

Categories

(Firefox for Android :: General, defect)

All
Android
defect
Not set

Tracking

()

RESOLVED FIXED
Firefox 48
Tracking Status
firefox48 --- fixed

People

(Reporter: antlam, Assigned: sebastian)

References

(Blocks 1 open bug)

Details

Attachments

(2 files, 1 obsolete file)

We're doing a lot of things with Notifications in Fennec and right now, and the system offers a _really_ easy way to block ALL notifications. 

That's going to be even more appealing to users if we don't give them some level of control to manage this within our own app.

I think we need to add a "Notifications" item inside Settings. WRT placement, I don't have huge opinions right now, but I think it needs to be on the first level. I'm thinking above "Advanced" since this is something that affects all users.

Copy TBD, but a simple list with toggles will do I think:

+-----------------------------------------+
|                                         |
|  What's new update                 O--  |
|                                         |
|                                         |
|  Unread Bookmarks                  O--  |
|                                         |
|                                         |
|  Website updates                   O--  |
|                                         |
|                                         |
|  Tab queue                         O--  |
|                                         |
|                                         |
|                                         |
|                                         |
|                                         |
|                                         |
|                                         |
|                                         |
|                                         |
|                                         |
+-----------------------------------------+
^ Items in list for illustrative purposes only
I agree we'll need something like this.

I'm wondering if we should add "Tab queue" to this list. It's the only one of the notifications that is user initiated, by tapping a link in an external application. The others are opt-out and should have settings here, and maybe in the notification itself.
Yeah, tab queue feels a bit out of place. If we include tab queue, should we also include other notifications that stem from user action, like downloads? Seems like this could quickly get out of hand.

I would argue that we should put an opt-out for snippets in here. Make this less about the system notification UI, more about the things Firefox could be doing to annoy you.
Duplicate of this bug: 1193510
Assignee: nobody → s.kaspari
Status: NEW → ASSIGNED
I landed this new settings category as part of bug 1241810:
https://hg.mozilla.org/integration/fx-team/rev/d0fd7d32ee5e

@antlam: I only added "content notifications" in there. I'd use this bug to add other notifications to this menu. Do you have a list of notifications you want to see there?
Flags: needinfo?(alam)
(In reply to Sebastian Kaspari (:sebastian) from comment #5)
> I landed this new settings category as part of bug 1241810:
> https://hg.mozilla.org/integration/fx-team/rev/d0fd7d32ee5e

This is the actual patch:
https://hg.mozilla.org/integration/fx-team/rev/6adb4ec5f1c8
(In reply to Sebastian Kaspari (:sebastian) from comment #5)
> I landed this new settings category as part of bug 1241810:
> https://hg.mozilla.org/integration/fx-team/rev/d0fd7d32ee5e
> 
> @antlam: I only added "content notifications" in there. I'd use this bug to
> add other notifications to this menu. Do you have a list of notifications
> you want to see there?

I think we should start with these:

What's new in Firefox
Discover new features and other app updates

Website updates
New content from supported sites you've bookmarked

Later, we can look to include controls for unread bookmarks (bug 1245642), web notifications and others as well.
Flags: needinfo?(alam) → needinfo?(s.kaspari)
(In reply to Anthony Lam (:antlam) from comment #7)
> What's new in Firefox
> Discover new features and other app updates

I added this one

(In reply to Anthony Lam (:antlam) from comment #7)
> Website updates
> New content from supported sites you've bookmarked

I didn't change this one yet. Using bookmarks is the current heuristic but there's interest to test others like history/top sites (bug 1253290). It would be troublesome to update the string for every experiment or have multiple versions of it and update them at runtime.

What we currently are using is:
> Website updates
> Allow notifications for supported sites

Can we find a string that does not use "bookmarked"? Or do you think it's essential to communicate this for the experiment?
Flags: needinfo?(s.kaspari)
Attachment #8736659 - Flags: review?(margaret.leibovic) → review+
Comment on attachment 8736659 [details]
MozReview Request: Bug 1247788 - Add setting for "What's new?" notification. r=margaret

https://reviewboard.mozilla.org/r/43513/#review40071

Nice, thanks.
(In reply to Sebastian Kaspari (:sebastian) from comment #9)
> (In reply to Anthony Lam (:antlam) from comment #7)
> > What's new in Firefox
> > Discover new features and other app updates
> 
> I added this one
> 
> (In reply to Anthony Lam (:antlam) from comment #7)
> > Website updates
> > New content from supported sites you've bookmarked
> 
> I didn't change this one yet. Using bookmarks is the current heuristic but
> there's interest to test others like history/top sites (bug 1253290). It
> would be troublesome to update the string for every experiment or have
> multiple versions of it and update them at runtime.

Fair point.

> What we currently are using is:
> > Website updates
> > Allow notifications for supported sites
> 
> Can we find a string that does not use "bookmarked"? Or do you think it's
> essential to communicate this for the experiment?
 
Let's go with this, it involves changing the other notification copy but I think it's better.

> Website updates
> Discover new content from supported sites

> What's new in Firefox
> Learn about changes and new features after an update
Flags: needinfo?(s.kaspari)
Attached image settings_notifications.png (obsolete) —
Flags: needinfo?(s.kaspari)
Attachment #8736803 - Flags: feedback?(alam)
Comment on attachment 8736659 [details]
MozReview Request: Bug 1247788 - Add setting for "What's new?" notification. r=margaret

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/43513/diff/1-2/
Attachment #8736659 - Attachment description: MozReview Request: Bug 1247788 - Add setting for "What's new?" notification. r?margaret → MozReview Request: Bug 1247788 - Add setting for "What's new?" notification. r=margaret
Comment on attachment 8736803 [details]
settings_notifications.png

Let's make these switches too.

And can we change the description copy in the What's new in Fennec pref? I want to shorten it to:

Learn about new features after an update
Flags: needinfo?(s.kaspari)
Attachment #8736803 - Flags: feedback?(alam) → feedback-
Attachment #8736803 - Attachment is obsolete: true
Flags: needinfo?(s.kaspari)
Attachment #8737125 - Flags: feedback?(alam)
Comment on attachment 8737125 [details]
settings_notifications.png

+++++++++
Attachment #8737125 - Flags: feedback?(alam) → feedback+
https://hg.mozilla.org/mozilla-central/rev/7dd46c214c29
Status: ASSIGNED → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 48
You need to log in before you can comment on or make changes to this bug.