126193 - New bookmarks are added to a folder if selected no matter what

Status: VERIFIED FIXED

(SeaMonkey :: Bookmarks & History, defect)

Description

[Joonas Paalasmaa]

User-Agent: Mozilla/5.0 (Windows; U; WinNT4.0; en-US; rv:0.9.8) Gecko/20020204
BuildID:    2002020406

My bookmarks consists of four folders and a few bookmarks in the root
level. Every time I add a new bookmark, it is added to one of the folders
instead of the root level.

Comment 1

[Boris Zbarsky [:bzbarsky]]

I've seen this too.  The only way to get a root-level bookmark is to make sure
that none of the folders are selected.... otherwise the folders (even closed)
will get the bookmark.

Comment 2

[Joonas Paalasmaa]

I am not adding the bookmark in 'Manage Bookmarks' -mode, but during normal
browsing with Ctrl+D.

Comment 3

[Peter Trudelle]

nsbeta1+ per ADT triage team.  Bookmark addition should not be based on selected
folder.

Comment 4

[Blake Ross]

-> me

Comment 5

[Blake Ross]

Attachment: patch

Comment 6

[Ben Goodger (use ben at mozilla dot org for email)]

Comment on attachment 73480 [details] [diff] [review]
patch

sr=[e-mail]

Comment 7

[Joe Hewitt (gone)]

Comment on attachment 73480 [details] [diff] [review]
patch

r=hewitt

Comment 8

[Asa Dotzler [:asa]]

Comment on attachment 73480 [details] [diff] [review]
patch

a=asa (on behalf of drivers) for checkin to the 1.0 trunk

Comment 9

[Jaime Rodriguez, Jr.]

ADT3 per ADT triage.

Comment 10

[Blake Ross]

fixed.

Comment 11

[Claudius Gayle]

blake, what was fixed here? Do I now have the ability to unset the 'Set as new
bookmarks folder' bit? 
...

 Ok I looked at the patch. While it is entirely possible that I am dead wrong,
that doesn't seem to have anything to do with the reporter's stated problem
(especially comment 2).

By my reckoning, you've solved bz's problem (comment 1) which is great.

So, reporter, are you still having your original problem? Could you restate it
with steps to reproduce? After that I'l ldetermine whether to reopen or leave
this bug as fixing the second problem and create a new bug for the original problem.

Comment 12

[Blake Ross]

I think you're right; comment 2 confused me, and it looks like it confused ADT
as well (comment 3).  Comment 3 suggests that this was plussed to make bookmarks
not be added to closed but selected folders, which is now fixed. But I guess the
reporter accidentally set a new bookmark folder and wants a way to unset it?

Comment 13

[Claudius Gayle]

VERIFIED Fixed with 20020409(before the branch) builds.

I tweaked the summary to reflect the morph/actual fix. wrote bug 139593 to cover
what I believe was the reporter's original issue.