1262006 - Speech synthesis: Tooltip for Play button is 'Stop' and for Stop button 'Start'

Status: VERIFIED FIXED

(Toolkit :: Reader Mode, defect)

Description

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

Firefox 48.0a1 20160404030231 and 47.0a2 20160403004049

Speech synthesis: Tooltip for Play button is 'Stop' and for Stop button 'Start'

1. Set media.webspeech.synth.enabled to true.
2. Open http://blog.monotonous.org/2016/03/07/narrate-a-new-feature-in-firefox-nightly/
3. Switch to reader mode by clicking the book icon in the location bar.
4. In the left toolbar, click the third icon from the top.
5. Move the mouse over the Play button.
Actual and expected result: Tooltip is 'Start'.
6. Click the button.
Actual result: Tooltip is still 'Start'.
Expected result: 'Stop'.
7. Click the button.
Actual result: Tooltip is 'Stop'.
Expected result: 'Start'.

Comment 1

[Eitan Isaacson [:eeejay]]

Attachment: MozReview Request: Bug 1262006 - Swap narrate start/stop button tooltip states. r=Gijs

Review commit: https://reviewboard.mozilla.org/r/45153/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/45153/

Comment 2

[:Gijs (out for now; he/him)]

Comment on attachment 8739253 [details]
MozReview Request: Bug 1262006 - Swap narrate start/stop button tooltip states. r=Gijs

https://reviewboard.mozilla.org/r/45153/#review41693

r=me, but can you add this to the automated test(s) ? We clearly can't be trusted to just get it right. :-)

Comment 3

[Eitan Isaacson [:eeejay]]

Comment on attachment 8739253 [details]
MozReview Request: Bug 1262006 - Swap narrate start/stop button tooltip states. r=Gijs

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/45153/diff/1-2/

Comment 4

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/dbc96a62c1da

Comment 5

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/dbc96a62c1da

Comment 6

[Camelia Badau [:cbadau], Desktop Test Engineering]

Verified fixed on Windows 7 64bit and Mac OSX 10.9.5 using latest Aurora 48.0a2 (buildID: 20160504004015).

On Ubuntu, the issue can't be verified since it depends on bug 1270110.

Comment 8

[Camelia Badau [:cbadau], Desktop Test Engineering]

Verified fixed on Ubuntu 14.04 x64 using Firefox 48 Beta 7 (buildID: 20160711002726).