1262214 - Hook up the new disco pane

Status: RESOLVED FIXED

(Toolkit :: Add-ons Manager, defect, P2)

Description

[Andy McKay]

This bug is to hook up the new disco pane as per UX mocks. Since this page is just a pointer to AMO there's a couple of things to do here:

1) The UX mocks call for the removal of the search and gear icon at the top of the page: https://www.dropbox.com/s/ec97ywh5s791q5m/Screenshot%202016-04-05%2010.58.40.png?dl=0

2) point to the new domain created in bug 1262009, by altering the relevant setting, extensions.webservice.discoverURL

Comment 1

[Andrew Swan [:aswan]]

(In reply to Andy McKay [:andym] from comment #0)
> 1) The UX mocks call for the removal of the search and gear icon at the top
> of the page:
> https://www.dropbox.com/s/ec97ywh5s791q5m/Screenshot%202016-04-05%2010.58.40.
> png?dl=0

To confirm, the intention is that the gear and search box appear when looking at any page other than "Get Add-ons"?  (including the search page?)  And they simply aren't present when looking at "Get Add-ons"?

Comment 2

[Andrew Swan [:aswan]]

(In reply to Andy McKay [:andym] from comment #0)
> 2) point to the new domain created in bug 1262009, by altering the relevant
> setting, extensions.webservice.discoverURL

The default discovery URL is currently:
https://services.addons.mozilla.org/%LOCALE%/firefox/discovery/pane/%VERSION%/%OS%/%COMPATIBILITY_MODE%

I'll update the hostname but will there be a change to the path too?  If so, I'd like to just do it all at once.

Comment 3

[Stuart Colville [:muffinresearch]]

(In reply to Andrew Swan [:aswan] from comment #2)
> (In reply to Andy McKay [:andym] from comment #0)
> > 2) point to the new domain created in bug 1262009, by altering the relevant
> > setting, extensions.webservice.discoverURL
> 
> The default discovery URL is currently:
> https://services.addons.mozilla.org/%LOCALE%/firefox/discovery/pane/
> %VERSION%/%OS%/%COMPATIBILITY_MODE%
> 
> I'll update the hostname but will there be a change to the path too?  If so,
> I'd like to just do it all at once.

The only change is the hostname we'll keep the path as is.

Comment 4

[Markus Jaritz [:designakt] (UX)]

Attachment: AddonDiscovery-currentHeaderOptions.png

(In reply to Andrew Swan [:aswan] from comment #1)
> (In reply to Andy McKay [:andym] from comment #0)
> > 1) The UX mocks call for the removal of the search and gear icon at the top
> > of the page:
> > https://www.dropbox.com/s/ec97ywh5s791q5m/Screenshot%202016-04-05%2010.58.40.
> > png?dl=0
> 
> To confirm, the intention is that the gear and search box appear when
> looking at any page other than "Get Add-ons"?  (including the search page?) 
> And they simply aren't present when looking at "Get Add-ons"?

Yes.
I'll link the full new discovery page for reference.
https://invis.io/SW6XLBBJB

The intention behind this is to focus users of this page on the add-ons we introduce, as this page will be the first thing people discovering about:addons will see, and we want to get users to install one of those add-ons.
At that stage a header with additional options about what to do with your add-ons and search for add-ons is the opposit of that. (See attachment for current options on that page.)

Comment 5

[Andrew Swan [:aswan]]

Attachment: MozReview Request: Bug 1262214 Part 1: point "get addons" to discovery.a.m.o r?kmag

Review commit: https://reviewboard.mozilla.org/r/47505/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/47505/

Comment 6

[Andrew Swan [:aswan]]

Attachment: MozReview Request: Bug 1262214 Part 2: Hide header when viewing the discovery pane r?rhelmer

Review commit: https://reviewboard.mozilla.org/r/47507/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/47507/

Comment 7

[Kris Maglione [:kmag]]

Comment on attachment 8743023 [details]
MozReview Request: Bug 1262214 Part 1: point "get addons" to discovery.a.m.o r?kmag

https://reviewboard.mozilla.org/r/47505/#review44315

Comment 8

[Robert Helmer [:rhelmer]]

Comment on attachment 8743024 [details]
MozReview Request: Bug 1262214 Part 2: Hide header when viewing the discovery pane r?rhelmer

https://reviewboard.mozilla.org/r/47507/#review44517

::: toolkit/mozapps/extensions/content/extensions.js:767
(Diff revision 1)
>      if (!viewObj.node)
>        throw Components.Exception("Root node doesn't exist for '" + view.type + "' view");
>  
>      if (this.currentViewObj && aViewId != aPreviousView) {
> +      this.headerEl.hidden = Boolean(viewObj.hideHeader);
> +      

errant whitespace, please remove

Comment 9

[Andrew Swan [:aswan]]

Comment on attachment 8743024 [details]
MozReview Request: Bug 1262214 Part 2: Hide header when viewing the discovery pane r?rhelmer

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/47507/diff/1-2/

Comment 10

[Pulsebot]

https://hg.mozilla.org/integration/fx-team/rev/913eb4e86ec6
https://hg.mozilla.org/integration/fx-team/rev/8d264de83af5

Comment 11

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/913eb4e86ec6
https://hg.mozilla.org/mozilla-central/rev/8d264de83af5