Update domains for permissions

RESOLVED FIXED in Firefox 48

Status

()

Toolkit
Add-ons Manager
RESOLVED FIXED
2 years ago
2 years ago

People

(Reporter: Andy McKay, Assigned: aswan)

Tracking

unspecified
mozilla48
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(firefox48 fixed)

Details

MozReview Requests

()

Submitter Diff Changes Open Issues Last Updated
Loading...
Error loading review requests:

Attachments

(1 attachment)

(Reporter)

Description

2 years ago
In bug 1262009 ops want to run the discovery pane on a new domain. That means an update to the permissions for UITour bug 1256598 and AddonsManager bug 1245571.
Depends on: 1245571
The ops bug mentioned in the initial description is a typo it should be bug 1262209
For production UITour and mozAddonManager are both currently exposed to addons.mozilla.org and services.addons.mozilla.org.  Should discovery.addons.mozilla.org replace one or both of these or just be added to the list?

For dev, UITour gets permitted domains from a preference setting so there's nothing to do for this issue.
But mozAddonManager uses a hard-coded list which is currently:
addons.allizom.org
services.addons.allizom.org
addons-dev.allizom.org
services.addons-dev.allizom.org
example.com

Bug 1262209 mentions discovery.addons-dev.allizom.org and discovery.addons.allizom.org for dev and staging respectively.  Same question: should these replace (part of) the current list or just be added to it?
Flags: needinfo?(amckay)
(Reporter)

Comment 3

2 years ago
(In reply to Andrew Swan [:aswan] from comment #2)
> For production UITour and mozAddonManager are both currently exposed to
> addons.mozilla.org and services.addons.mozilla.org.  Should
> discovery.addons.mozilla.org replace one or both of these or just be added
> to the list?
> 
> For dev, UITour gets permitted domains from a preference setting so there's
> nothing to do for this issue.
> But mozAddonManager uses a hard-coded list which is currently:
> addons.allizom.org
> services.addons.allizom.org
> addons-dev.allizom.org
> services.addons-dev.allizom.org
> example.com
> 
> Bug 1262209 mentions discovery.addons-dev.allizom.org and
> discovery.addons.allizom.org for dev and staging respectively.  Same
> question: should these replace (part of) the current list or just be added
> to it?

discovery.* can replace services.* in all the above examples.
Flags: needinfo?(amckay)
Created attachment 8741979 [details]
MozReview Request: Bug 1262218 Update permissions for APIs used for addon discovery

Review commit: https://reviewboard.mozilla.org/r/46885/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/46885/
Attachment #8741979 - Flags: review?(rhelmer)
Comment on attachment 8741979 [details]
MozReview Request: Bug 1262218 Update permissions for APIs used for addon discovery

https://reviewboard.mozilla.org/r/46885/#review43899

It might be nice to have constants for these domains instead of having the exact domain names duplicated, but this is not a new issue introduced by this patch so up to you.
Attachment #8741979 - Flags: review?(rhelmer) → review+
https://reviewboard.mozilla.org/r/46885/#review43899

Yeah, I agree that would be nice but I'm pretty sure the permissions file is just copied verbatim into the build directory so substituting for a centrally defined symbol would entail introducing a pre-processing step.  I think I'll leave that for another day :-)
Keywords: checkin-needed

Comment 8

2 years ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/6f7203377bf7
Status: NEW → RESOLVED
Last Resolved: 2 years ago
status-firefox48: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla48
Iteration: --- → 48.3 - Apr 25
You need to log in before you can comment on or make changes to this bug.