1262669 - Downloads button indicator doesn't redraw with APZ and HWA disabled

Status: RESOLVED DUPLICATE of bug 1265605

(Core :: Layout, defect)

Description

[arni2033]

>>>   My Info:   Win7_64, Nightly 48, 32bit, ID 20160403030243
STR_1_simplified:
1. Disable APZ and HWA, enable lwtheme, move Downloads button to the end of TabsToolbar. Restart
2. Open https://bugzilla.mozilla.org/ , save page, save page
3. Open Customize, drag Downloads button to other place then back w/o mouseup. Drop. Exit Customize
3. Save page

AR:  [screencast] Downloads button doesn't redraw
ER:  No graphic glitches

> Regression:   https://hg.mozilla.org/integration/mozilla-inbound/pushloghtml?fromchange=c525c5164cdde373a636d525e53c77f52d8fd693&tochange=c99e8abb5e00eaa439a3be7864df0e4135326349

Comment 1

[arni2033]

Attachment: screencast 1 (bug 1262669) - Downloads button doesn't redraw.webm

Comment 2

[Milan Sreckovic [:milan] (needinfo for best results)]

We'll take a fix if it comes up, but will not block 48, given that this is a non-default configuration.

Comment 3

[arni2033]

UPD:
This was fixed between 2016-05-05 and 2016-05-11. I'll track down the fix in a few days.
Please ignore this bug for now.

Comment 4

[arni2033]

This was fixed by bug 1258904. Fix range:
> https://hg.mozilla.org/integration/mozilla-inbound/pushloghtml?fromchange=8fa8077e9c5f8610cf55f084930b8650b3710b1f&tochange=246fdb220ef355bffd166aee2d53e8fbff5dfa56

Duplicate of this bug: bug 1280060

Comment 5

[Hiroyuki Ikezoe (:hiro)]

Actually this bug is exactly a duplicate of bug 1258904.  I'd been wondering why bug 1258904 did not happen on other platforms.

Comment 6

[Hiroyuki Ikezoe (:hiro)]

Gosh. Sorry.  I meant bug 1265605.

Comment 7

[arni2033]

(In reply to Hiroyuki Ikezoe (:hiro) from comment #5)
> Actually this bug is exactly a duplicate of bug 1265605.

1) Actually bug 1265605 is exactly a duplicate of this bug, as this bug has more info
   and was reported long before 1265605.
2) I left this bug as "New" with the same reasoning as bug 1280060. If you think that each and every
   bug that don't happen on Nightly should be marked as Fixed, close bug 1280060 as well.
   If not, then keep this bug open as well.
  (bug 1280060 was also reported long after this bug. I think it got too much attention for no reason
   given there's already enough bugs with clear regression range, such as this one, and they are
   being carefully ignored until they reach release [quite interesting fact])

Comment 8

[Hiroyuki Ikezoe (:hiro)]

The reason why I did not mark bug 1280060 as a duplicate of bug 1265605 is that it's not related download button.  But yes, that bug should have been closed.

Comment 9

[Ritu Kothari (:ritu) (Inactive, please n-i to RyanVM, jcristau, or pascal)]

This is not critical enough to be included in a dot release.