Measuring tool not turned off when toolbox button is hidden

NEW
Unassigned

Status

P2
minor
3 years ago
4 months ago

People

(Reporter: sebo, Unassigned)

Tracking

(Blocks: 1 bug)

Trunk

Firefox Tracking Flags

(firefox48 affected)

Details

(Reporter)

Description

3 years ago
When the toolbox options checkbox that toggles the measuring tool gets unchecked while the tool is active, the tool stays activated. This means the measuring overlay is still there even when the tool is deactivated.

The tool should instead get deactivated once the checkbox gets unchecked.

Sebastian

PS: The same is true for other tools like the rulers toggle or the tool for highlighting the painted area. Let me know if I should file separate bugs for these.
Matteo, could you please investigate a bit here in order to prioritize this bug?
Flags: needinfo?(zer0)
(In reply to Sebastian Zartner [:sebo] from comment #0)

> When the toolbox options checkbox that toggles the measuring tool gets
> unchecked while the tool is active, the tool stays activated. This means the
> measuring overlay is still there even when the tool is deactivated.
> 
> The tool should instead get deactivated once the checkbox gets unchecked.

Sebastian, could you provide some STR? I wasn't able to reproduce it simply clicking on the icons / executing commands from GCLI, and a mix of them (enable from button, disable from GCLI, and so on).
This, on the latest Nightly, 48.0a1 (2016-04-11), and on OS X 10.11.4.

> PS: The same is true for other tools like the rulers toggle or the tool for
> highlighting the painted area.

That's very possible, they all share the same mechanism.

> Let me know if I should file separate bugs for these.

In case we can use this bug for all of them, maybe we'll just rephrase the subject.
Flags: needinfo?(zer0) → needinfo?(sebastianzartner)
(Reporter)

Comment 3

3 years ago
Sorry for not being clearer before. Here are the steps:
1. Open the DevTools
2. Switch to the Options panel
3. Check the option 'Measure a portion of the page'
4. Click the button of the Measure tool to enable it
5. Measure something on the page
6. Uncheck the option 'Measure a portion of the page' within the Options panel

=> The selected area is still visible and you can still create new measurements while the toolbox button is not available anymore.

Hope this makes it clearer now.

>> PS: The same is true for other tools like the rulers toggle or the tool for
>> highlighting the painted area.
>
> That's very possible, they all share the same mechanism.

That actually applies to all tools listed under 'Available Toolbox Buttons'.
My assumption was (and I guess I'm not the only one) that there is no way to disable the tool when the toolbox button is hidden. I didn't think of the GCLI to toggle it.

Though the main point of this issue is, when somebody removes the button from the toolbox, (s)he likely doesn't want to use the tool anymore and therefore it should be turned off.

Sebastian
Flags: needinfo?(sebastianzartner)
Summary: Measuring tool not turned off when hidden → Measuring tool not turned off when toolbox button is hidden
Marking as P2. Matteo, feel free to change it.
Also could you please check if this could be a good mentored first bug? I have a feeling it could.
Flags: needinfo?(zer0)
Priority: -- → P2
(Reporter)

Updated

2 years ago
See Also: → bug 1287083
(In reply to Sebastian Zartner [:sebo] from comment #3)
> Sorry for not being clearer before. Here are the steps:
> 1. Open the DevTools
> 2. Switch to the Options panel
> 3. Check the option 'Measure a portion of the page'
> 4. Click the button of the Measure tool to enable it
> 5. Measure something on the page
> 6. Uncheck the option 'Measure a portion of the page' within the Options
> panel
> 
> => The selected area is still visible and you can still create new
> measurements while the toolbox button is not available anymore.
> 
> Hope this makes it clearer now.

Okay, now I understand! I would say it's intended. Basically they're shortcut buttons for the GCLI command. The presence in the toolbox doesn't affect the functionality of the command itself; in fact if you execute the command from the GCLI and then enable the relative button, the button should get the current state of the tool – without "resetting" that state.

Said that, I also think it's bad UI, because if the user only uses the tool from the toolbox without knowing the GCLI, removing that from the toolbox makes virtually impossible for him to exit from the tool.

We should probably either reset the state of the tool every time the relative button is added / removed; or just when is removed.

But I don't think we have currently such functionality in GCLI, to specify in a command something to do when the related button is removed. Joe, do we?

> That actually applies to all tools listed under 'Available Toolbox Buttons'.
> My assumption was (and I guess I'm not the only one) that there is no way to
> disable the tool when the toolbox button is hidden. I didn't think of the
> GCLI to toggle it.

> Though the main point of this issue is, when somebody removes the button
> from the toolbox, (s)he likely doesn't want to use the tool anymore and
> therefore it should be turned off.

Yes, that's a valid point.
Flags: needinfo?(zer0) → needinfo?(jwalker)
So I agree that it would be nice to turn a tool off when we remove the button, but I think this is a P3, right?
Flags: needinfo?(jwalker)
(Reporter)

Updated

a year ago
Component: Developer Tools: Inspector → Developer Tools: Measuring Tool

Updated

4 months ago
Product: Firefox → DevTools
You need to log in before you can comment on or make changes to this bug.