Closed Bug 1263237 Opened 5 years ago Closed 5 years ago

merge service-worker/resources/test-helpers.js and service-workers/resources/test-helpers.js

Categories

(Core :: DOM: Service Workers, defect)

defect
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla48
Tracking Status
firefox48 --- fixed

People

(Reporter: bkelly, Assigned: bkelly)

References

Details

(Whiteboard: btpp-active)

Attachments

(2 files)

We currently have two different wpt test-helpers.js files:

  service-worker/resources/test-helpers.js
  service-workers/resources/test-helpers.js

The first is part of the main service worker tests we just moved out of the mozilla dir.  The second is used in the cache tests.

I intend to merge the second script into the first script.
Assignee: nobody → bkelly
Status: NEW → ASSIGNED
Actually, this is easier then that.  The file names are slightly different:

  service-worker/resources/test-helpers.sub.js
  service-workers/resources/test-helpers.js

So we can just move the second file into the other directory.
This moves the one test-helpers.js script that was in service-workers/service-workers/resources into the same resources dir with the other service worker tests.  We've been using service-workers/service-worker (no trailing s) instead.
Attachment #8739519 - Flags: review?(james)
Note, the moved file is in the patch, but splinter doesn't show hg renames in its diff tool.
Comment on attachment 8739519 [details] [diff] [review]
Unify scripts in service-worker/resources. r=jgraham

I think I should look at this more.  Now that I understand what the .sub.js means, I think the two files could probably be merged.
Attachment #8739519 - Flags: review?(james)
Whiteboard: btpp-active
Comment on attachment 8739797 [details] [diff] [review]
Unify scripts in service-worker/resources. r=jgraham

Review of attachment 8739797 [details] [diff] [review]:
-----------------------------------------------------------------

Thanks!
Attachment #8739797 - Flags: review?(james) → review+
https://hg.mozilla.org/mozilla-central/rev/85e27e41f321
Status: ASSIGNED → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla48
Depends on: 1270673
You need to log in before you can comment on or make changes to this bug.