126342 - offline: if the pref set to 'automatically download mesgs for offline use', newsgroups won't be downloaded.

Status: VERIFIED FIXED

(SeaMonkey :: MailNews: Backend, defect)

Description

[grylchan]

Spun off bug 102782

As I forgot to put it in that bug, the other case where you could
download newsgroups.

If the pref in Edit|Preferences|Offline&Diskspace|when going offline
 - automatically download mesgs for offline use

this pref is tied into the offline idicator. So if the user
clicks it, newsgroups won't be downloaded. But if the user
has pref 'set to ask me' and user clicks icon, the user will
be prompted and mail/news will both be downloaded.

Steps to reproduce:
1. Set the pref Edit|Preferences|Offline&Diskspace|when going offline
   - automatically download mesgs for offline use
2.Select a newsgroup to download via Items for Offline use Window
3.Click offline icon in mesenger or stand alone meg
4.mesgs are automatically downloaded

result: newsgroups aren't downloaded
expected: newsgroup to be downloaded

Comment 1

[David :Bienvenu]

gary, I'm so confused. Isn't this the same as 102782? And this works fine for
me. I have newsgroups configured for offline use; I click the offline indicator,
pick download messages, and the newsgroups are downloaded.

Comment 2

[grylchan]

Me confusing you David? ha!

Here's the skinny:
 Bug 102782 - click icon, get prompted to download, downloads
              both your mail and news mesgs. Verified.

Well that window prompt, when you click the offline icon, is
tied into the preference:
   Edit|Preferences|Offline&Diskspace|when going offline
     -Ask me if I want to download mesgs for offline use (bug 10278)
     -Automatically download mesgs for offline use (this bug)
     -Do not download mesgs for offline use

So when you click the offline icon, it will do something based on
the pref setting above.

So this bug is filed based on 2nd pref of 'automatically download my mesgs'
as if I have a newsgroup selected, when I click the icon, it downloads
only my mail mesgs not my newsgroup mesgs.

Comment 3

[David :Bienvenu]

sorry, Gary, I understand now. I didn't realize that the js front end had
different calls for those two scenarios, silly me. You'd think there would just
be the one code path, with an optional prompt, but NOooooooooooooooo. I'll try
to find the code path for this scenario.

Comment 4

[David :Bienvenu]

Attachment: proposed fix

Comment 5

[David :Bienvenu]

checked in ,rs=sspitzer

Comment 6

[grylchan]

using commercial build
2002-02-22-10-trunk nt 4.0
2002-02-22-09-trunk linux 2.2
2002-02-22-07-trunk mac 9.2.2, mac 10.1.3

verified having the pref "Automatically download mesgs for offline use"
set, that if you click offline icon (in mesgr,stand alone mesg window)
that mail and newsgroup selected for offline use will be downloaded.

mark as verified.