102782 - offline: newsgrps: selecting newgrps in items for offline usage window and then downloading them at the 'download prompt' results in mesgs not being dwnlded

Status: VERIFIED FIXED

(SeaMonkey :: MailNews: Backend, defect, P2)

Description

[grylchan]

Using 10-2 commercial branch builds on all platforms.

Comparing this to the way Mail is downloaded using the same steps.

No problems at all if I use "download and sync window".

If you select some newsgroups to be downloaded through
the 'items for offline usage window', then click offline icon and
the pop up window 'do you want to download mesgs' appears,
and you say download, the result is that newsgroup mesgs aren't downloaded.
When I go back online, then click on a newsgroup mesg, it turns
dark grey and its downloaded.


If I repeat same steps for mail, messages are automatically 
downloaded.

Might be related to downloading problems in this bug 87018?

Similar to a mail bug that I filed: bug 90772. <-see my first
test case in that bug.

Steps to reproduce:
1.Login to your imap mail account (i used a brand new profile)
2.subscribe to some newsgroups if you have not already.
2a.click on the newsgroups to get the headers
3.Edit|Mail and Account settings|Offline & Disk space for that news account
4.Click Select button
5.Select a few newsgroups(s) to download
6.Click ok 
7.Exit preferences window
8.Click offline icon
9.The download messages window pops up
10.say yes to download
11.visit newsgroups (s) that you have downloaded

result: not downloaded
        Go back online and select a news mesg and it will then be downloaded.
expected: to be downloaded like it is for mail.

Comment 1

[David :Bienvenu]

Gary, isn't this a dup of bug 84061 or bug 87018?

Comment 2

[grylchan]

It could be. Or maybe fixes to either bug 84061 or bug 87018
will fix this bug.

My reasons why not a dupe of either bug:
 bug 84061 : deals with newly subscribed newsgroups and trying
             to download them. In this particular case
             I get the headers, read few of the mesgs
             in the newsgroups before trying to download.
             And they are not downloaded.

 bug 87018 : This bug covers downloading multiple newsgroups.
             [though I do have in my steps to reproduce
              to select few newsgroups so I understand where
              you are coming from]
             I've tried only downloading 1 newsgroup and I
             still see the problem.


I can resolve as invalid for now and reopen if either of the
2 bugs you mentioned does not fix this problem.

Sound good?

            

Comment 3

[David :Bienvenu]

hmm, maybe it's not a dup. Leave it open for now, please, and when I get to
those other bugs, I'll get to this one along the way.

Comment 4

[Chase Tingley]

*** Bug 105967 has been marked as a duplicate of this bug. ***

Comment 5

[David :Bienvenu]

Attachment: proposed fix

we weren't resetting m_numWrote between groups, which was causing problems.

Comment 6

[grylchan]

David, would your fix also possibly fix this other bug:
bug 109232?

I was going to almost dupe that bug as dupe of this one.

Comment 7

[David :Bienvenu]

Gary, I'm not sure - that's an odd bug that I haven't been able to reproduce
myself. You might want to just try tomorrow's build and see how it works.

Comment 8

[David :Bienvenu]

fix checked in.

Comment 9

[grylchan]

David,
reopening this bug.

When I select some newsgroups to be downloaded in 'items
for offline use' window and then click offline icon,
the download prompt pops us, and I click 'download' button:
the result is it goes offline but the newsgroups aren't
downloaded. If I go back online and click on each news mesg,
then each mesg gets downloaded. I tried clicking offline icon/download
prompt again and it didn't work.

I was using commercial:
2002-02-01-10-trunk/ nt 4.0
2002-02-01-08-trunk/ linux 2.2

Comment 10

[David :Bienvenu]

Are these groups you've downloaded headers for, or newly subscribed groups? I
think you verified the bug where you select newly subscribed groups for offline
use, and I think that would be similar to this bug. If it's a group that you had
downloaded headers for, was the newsgroup up to date?

Comment 11

[grylchan]

Ok I tried a brand new profile.
Only a newsgroup account was created (no mail).
Subscribed to 3 news accounts.
Clicked on only 1 of them, got the headers, clicked on
few of the mesgs.
I selected all 3 mail accounts from edit|mailnews acct settings|
offline&diskspace|select button and chose all 3.
I then clicked the offline icon and the download prompt
appeared. I said download and result was mesgs weren't downloaded.

This bug is different than the other ones because we are not using
'Download/Sync now' window. I am just using
prefs from Edit|Preferences|Offline&disk space| when going offline:
   -don't download
   -ask me (and I say yes download)
   -automatically downlad them

So when I click offline icon, I expect news mesgs (in additon
to mail mesgs as that works fine) to be downloaded?

Or am I wrong in that prefs under Edit|Prefrences|Offline&Disk Space
are only intended to work with Mail and not news?

Comment 12

[David :Bienvenu]

it could be the js in the front end only asks the backend to download mail in
this scenario. I'll look into it. Jennifer, do you think it should download
newsgroups as well, i.e., do a full synchronize for offline?

Comment 13

[jglick]

>Or am I wrong in that prefs under Edit|Prefrences|Offline&Disk Space
>are only intended to work with Mail and not news?

Prefs should apply to whatever the user has selected in the "Select items for 
offline use", mail and/or newsgroup messages.

Comment 14

[David :Bienvenu]

Attachment: proposed fix

as I suspected, the front end js code was telling the offline backend code not
to download newsgroups. I've changed it to tell the offline be to download
newsgroups, if any are configured for offline use.

Comment 15

[David :Bienvenu]

cc'ing Navin for review.

Comment 16

[(not reading, please use [e-mail] instead)]

Comment on attachment 69242 [details] [diff] [review]
proposed fix

sr=sspitzer

Comment 17

[David :Bienvenu]

fix checked in - we will download whatever news and mail folders you have
configured for offline use.

Comment 18

[grylchan]

Using commercial builds:
2002-02-18-09-trunk nt 4.0
2002-02-18-10-trunk linux 2.2
2002-02-18-08-trunk/ mac 9.2.2
2002-02-18-12-trunk/ mac 10.1.2

Having any mail and/or newsgroups configured for offline use,
clicking the offline icon and saying download at the prompt
results in both mail and newsgroups being downloaded.

Forgot one case to add to this bug so I spun off a new bug 126342.
If pref to 'automatically download mesgs' is set and you click offline
icon (you won't be prompted) instead it will automatically download
your mesgs. But it doesn't work for newsgroups. So I created a new
bug as I failed to mention this in this bug.

marking as verified.