1263533 - Firefox 45.0.2 ESR fails to send Cookie header with XHR post requests done from a web worker when third-party cookies are blocked

Status: VERIFIED FIXED

(Core :: Networking: Cookies, defect)

Description

[Paul Oiegas [:poiegas], PM for (Ecosystem QA, Services QA, WebCompat QA, Ads QA, and Solo QA teams)]

[Affected versions]:
- Firefox 45.0.2 ESR (both candidate builds)

[Affected platforms]:
- Windows All
- Mac OS All
- Linux All

[Steps to reproduce]:
1. Start Firefox and navigate to "about:preferences" page.
2. Click the "Privacy" section button.
3. At "History" section, change the "Firefox will:" option into "Use custom settings for history".
4. Change the "Accept third-party cookies:" option into "Never".
5. Open a new tab and navigate to "https://push-fouadchk.rhcloud.com/demos/upload" page.
6. Upload an accepted file and observe the message displayed after upload completes.

[Expected result]:
"File_name (size): successfully uploaded... " message is displayed under the upload area.

[Actual result]:
"File_name (size): ERROR--Server: Bad request, Operation aborted..." message displayed under upload area.

[Notes]:
- This issue also reproduces on "https://inbox.google.com" page. After you log in the inbox page continuously reloads.
- Issue does not reproduces on 45.0.2 candidate, latest beta, dev edition and latest nightly.

Comment 1

[Sylvestre Ledru [:Sylvestre]]

Blake, in 45esr, we disabled the service workers ( https://www.fxsitecompat.com/en-CA/docs/2016/service-workers-have-been-disabled-in-firefox-45-esr/ ). I guess this is the issue here.
You confirm there is not much you can do here?

Comment 2

[Kohei Yoshino [:kohei]]

Service workers are different from Web (dedicated/shared) workers so we have to figure out what's going on here.

Comment 3

[Alice0775 White]

45.0.2 ESR build2 does not include the bunch of patch Bug 1257861 yet.

https://hg.mozilla.org/releases/mozilla-esr45/graph/tip

Comment 4

[Sylvestre Ledru [:Sylvestre]]

I landed: https://hg.mozilla.org/releases/mozilla-esr45/rev/3c4e50e49351 (the relbranch) 
https://hg.mozilla.org/releases/mozilla-esr45/rev/a9582019244b

Comment 5

[Alice0775 White]

I say that not yet landed build2 of ESR45.0.2

I think 45.0.2 build3 is needed

Comment 6

[Sylvestre Ledru [:Sylvestre]]

https://hg.mozilla.org/releases/mozilla-esr45/shortlog/GECKO4501esr_2016031618_RELBRANCH seems to disagree with you

Comment 7

[Alice0775 White]

Anyway, the patch is not included in the source.

http://archive.mozilla.org/pub/firefox/candidates/45.0.2esr-candidates/build2/source/firefox-45.0.2esr.source.tar.xz

Comment 8

[Sylvestre Ledru [:Sylvestre]]

Wes, Tomcat, what do you think? Thanks

Comment 9

[Carsten Book [:Tomcat]]

because i think its not on the relbranch

see https://hg.mozilla.org/releases/mozilla-esr45/rev/3c4e50e49351
vs https://hg.mozilla.org/releases/mozilla-esr45/rev/ccb4393876d9

https://hg.mozilla.org/releases/mozilla-esr45/rev/ccb4393876d9 has:
branch	GECKO4501esr_2016031618_RELBRANCH

and https://hg.mozilla.org/releases/mozilla-esr45/rev/3c4e50e49351 (this bug)
not

Comment 10

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

I think this is what's needed?
remote:   https://hg.mozilla.org/releases/mozilla-esr45/rev/fa7bcf815cf2
remote:   https://hg.mozilla.org/releases/mozilla-esr45/rev/97986cd5eebd

Comment 11

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

Calling this fixed until I hear otherwise. :)

Comment 12

[Blake Kaplan (:mrbkap) (inactive)]

Thanks for figuring this out!

Comment 13

[Paul Oiegas [:poiegas], PM for (Ecosystem QA, Services QA, WebCompat QA, Ads QA, and Solo QA teams)]

Hi guys,

Verified the fix for this issue on Firefox 45.0.2 ESR candidate build 3 (x32 & x64 builds) and all went well now. Tested with both the mentioned testcases on Windows 10 x64, Mac OS 10.11, Ubuntu 14.04 x32 and 15.10 x64 and no issues were observed.