1263887 - [e10s] Select dropdowns in e10s mode do not notice changes to the <select> after it has opened.

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, defect)

Description

[ovidiu boca[:Ovidiu]]

Attachment: Bug[e10s].mp4

[Affected versions]:

Nightly 48.0a1

[Affected platforms]:
Windows 7 x64
Mac OS X 10.10
Linux Ubuntu 14.04

[Steps to reproduce]:

1. Go to http://fashionchoice.bg/?product=efekten-maksi-zhaket-za-proletta-s-dzhobcheta-v-chetiri-tsvyata

2. You have 2 dropdowns menus, from the first choose 1 item

3. Go to the second dropdown and choose 1 size

4.Go back to the first dropdown and try to choose 1 item again

[Expected result]:

In the dropdown menu I can see a list of item from where I can choose.

[Actual result]:

I can't see the list in the dropdown only if I click it again. 

[Notes]:
This is a e10s issue, I can't reproduce it with e10s disabled. I attached a video where you can see the behaviour of this bug.

Comment 1

[Mike Conley (:mconley) (:⚙️)]

The problem here is that script on the page is adding <option> elements to the list after it's been opened, and we're not responding to that.

Comment 2

[Mike Conley (:mconley) (:⚙️)]

Attachment: MozReview Request: Bug 1263887 - Update <select>'s on mutation for e10s. r=Felipe

Review commit: https://reviewboard.mozilla.org/r/47267/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/47267/

Comment 3

[Mike Conley (:mconley) (:⚙️)]

Attachment: MozReview Request: Bug 1263887 - Update the active child on a menulist when setting selection. r=enndeakin

Review commit: https://reviewboard.mozilla.org/r/47475/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/47475/

Comment 4

[Mike Conley (:mconley) (:⚙️)]

Comment on attachment 8742536 [details]
MozReview Request: Bug 1263887 - Update <select>'s on mutation for e10s. r=Felipe

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/47267/diff/1-2/

Comment 5

[Neil Deakin]

Comment on attachment 8742909 [details]
MozReview Request: Bug 1263887 - Update the active child on a menulist when setting selection. r=enndeakin

https://reviewboard.mozilla.org/r/47475/#review44505

Comment 6

[:Felipe Gomes (needinfo for replies!)]

Comment on attachment 8742536 [details]
MozReview Request: Bug 1263887 - Update <select>'s on mutation for e10s. r=Felipe

https://reviewboard.mozilla.org/r/47267/#review44927

Comment 7

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/c45842dc5468
https://hg.mozilla.org/integration/mozilla-inbound/rev/48ba27830041

Comment 8

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

Backed out for failures in CTP tests, e.g. browser_CTP_crashreporting.js

Backouts:
https://hg.mozilla.org/integration/mozilla-inbound/rev/4b16c1609af5
https://hg.mozilla.org/integration/mozilla-inbound/rev/78b83b86b1aa

Push with failures: https://treeherder.mozilla.org/#/jobs?repo=mozilla-inbound&revision=48ba2783004140f0331ffd4764363b5b0040f127
Failure log: https://treeherder.mozilla.org/logviewer.html#?job_id=26348111&repo=mozilla-inbound

14:54:33     INFO -  101 INFO Entering test bound
14:54:33     INFO -  102 INFO TEST-PASS | browser/base/content/test/plugins/browser_CTP_crashreporting.js | Plugin should not be activated -
14:54:33     INFO -  103 INFO TEST-UNEXPECTED-FAIL | browser/base/content/test/plugins/browser_CTP_crashreporting.js | uncaught exception - TypeError: this.menuBoxObject is undefined at set_selectedItem@chrome://global/content/bindings/menulist.xml:257:13
14:54:33     INFO -  set_value@chrome://global/content/bindings/menulist.xml:111:15
14:54:33     INFO -  plugin-popupnotification-center-item_XBL_Constructor@chrome://browser/content/urlbarBindings.xml:1856:9
14:54:33     INFO -  PopupNotifications_showPanel/promise<@resource://gre/modules/PopupNotifications.jsm:747:1
14:54:33     INFO -  Handler.prototype.process@resource://gre/modules/Promise.jsm -> resource://gre/modules/Promise-backend.js:937:23
14:54:33     INFO -  this.PromiseWalker.walkerLoop@resource://gre/modules/Promise.jsm -> resource://gre/modules/Promise-backend.js:816:7
14:54:33     INFO -  Promise*this.PromiseWalker.scheduleWalkerLoop@resource://gre/modules/Promise.jsm -> resource://gre/modules/Promise-backend.js:747:11
14:54:33     INFO -  this.PromiseWalker.schedulePromise@resource://gre/modules/Promise.jsm -> resource://gre/modules/Promise-backend.js:779:7
14:54:33     INFO -  this.PromiseWalker.completePromise@resource://gre/modules/Promise.jsm -> resource://gre/modules/Promise-backend.js:714:7
14:54:33     INFO -  receiveMessage@resource://testing-common/ContentTask.jsm:113:9
14:54:33     INFO -  Stack trace:
14:54:33     INFO -  chrome://mochikit/content/tests/SimpleTest/SimpleTest.js:simpletestOnerror:1563
14:54:33     INFO -  resource://gre/modules/PopupNotifications.jsm:PopupNotifications_showPanel/promise<:747
14:54:33     INFO -  resource://gre/modules/Promise.jsm -> resource://gre/modules/Promise-backend.js:Handler.prototype.process:937
14:54:33     INFO -  resource://gre/modules/Promise.jsm -> resource://gre/modules/Promise-backend.js:this.PromiseWalker.walkerLoop:816
14:54:33     INFO -  JavaScript error: chrome://global/content/bindings/menulist.xml, line 257: TypeError: this.menuBoxObject is undefined
14:54:33     INFO -  104 INFO Console message: [JavaScript Error: "TypeError: this.menuBoxObject is undefined" {file: "chrome://global/content/bindings/menulist.xml" line: 257}]
14:54:33     INFO -  set_selectedItem@chrome://global/content/bindings/menulist.xml:257:13
14:54:33     INFO -  set_value@chrome://global/content/bindings/menulist.xml:111:15
14:54:33     INFO -  plugin-popupnotification-center-item_XBL_Constructor@chrome://browser/content/urlbarBindings.xml:1856:9
14:54:33     INFO -  PopupNotifications_showPanel/promise<@resource://gre/modules/PopupNotifications.jsm:747:1
14:54:33     INFO -  Handler.prototype.process@resource://gre/modules/Promise.jsm -> resource://gre/modules/Promise-backend.js:937:23
14:54:33     INFO -  this.PromiseWalker.walkerLoop@resource://gre/modules/Promise.jsm -> resource://gre/modules/Promise-backend.js:816:7
14:54:33     INFO -  Promise*this.PromiseWalker.scheduleWalkerLoop@resource://gre/modules/Promise.jsm -> resource://gre/modules/Promise-backend.js:747:11
14:54:33     INFO -  this.PromiseWalker.schedulePromise@resource://gre/modules/Promise.jsm -> resource://gre/modules/Promise-backend.js:779:7
14:54:33     INFO -  this.PromiseWalker.completePromise@resource://gre/modules/Promise.jsm -> resource://gre/modules/Promise-backend.js:714:7
14:54:33     INFO -  receiveMessage@resource://testing-common/ContentTask.jsm:113:9
14:54:33     INFO -  Xlib:  extension "RANDR" missing on display ":0".

Comment 9

[Mike Conley (:mconley) (:⚙️)]

Comment on attachment 8742909 [details]
MozReview Request: Bug 1263887 - Update the active child on a menulist when setting selection. r=enndeakin

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/47475/diff/1-2/

Comment 10

[Mike Conley (:mconley) (:⚙️)]

Comment on attachment 8742536 [details]
MozReview Request: Bug 1263887 - Update <select>'s on mutation for e10s. r=Felipe

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/47267/diff/2-3/

Comment 11

[Mike Conley (:mconley) (:⚙️)]

Comment on attachment 8742909 [details]
MozReview Request: Bug 1263887 - Update the active child on a menulist when setting selection. r=enndeakin

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/47475/diff/2-3/

Comment 12

[Mike Conley (:mconley) (:⚙️)]

Comment on attachment 8742536 [details]
MozReview Request: Bug 1263887 - Update <select>'s on mutation for e10s. r=Felipe

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/47267/diff/3-4/

Comment 13

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/3c2a87839422
https://hg.mozilla.org/integration/mozilla-inbound/rev/c0730eb0c5fc

Comment 14

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

Backed out for various failures like https://treeherder.mozilla.org/logviewer.html#?job_id=26435296&repo=mozilla-inbound and https://treeherder.mozilla.org/logviewer.html#?job_id=26444507&repo=mozilla-inbound

https://hg.mozilla.org/integration/mozilla-inbound/rev/8ba674386af9

Comment 15

[Mike Conley (:mconley) (:⚙️)]

*sigh*. Sorry about that - I was pretty sure that was going to work. I'll do a try push before trying another landing.

Comment 16

[Mike Conley (:mconley) (:⚙️)]

Comment on attachment 8742536 [details]
MozReview Request: Bug 1263887 - Update <select>'s on mutation for e10s. r=Felipe

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/47267/diff/4-5/

Comment 17

[Mike Conley (:mconley) (:⚙️)]

Try looks good - third time's the charm.

Comment 18

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/df899bb47807
https://hg.mozilla.org/integration/mozilla-inbound/rev/4a2161196658

Comment 19

[Phil Ringnalda (:philor)]

Any OS X non-e10s m-oth in that try push?

Backed out in https://hg.mozilla.org/integration/mozilla-inbound/rev/aebbd7ae291a1029c829ec684ab2a03fff0301d3 for https://treeherder.mozilla.org/logviewer.html#?job_id=26466752&repo=mozilla-inbound

Comment 20

[Mike Conley (:mconley) (:⚙️)]

Hey yzen, it looks like the problem with the test hinges on the change I made to menulist.xml. Apparently, even just accessing this.menuBoxObject.activeChild (and not setting it) is enough to cause the accessible/tests/mochitest/selectable/test_menulist.xul test to break with:

26 INFO TEST-UNEXPECTED-FAIL | chrome://mochitests/content/a11y/accessible/tests/mochitest/selectable/test_menulist.xul | addItemToSelection(1): getSelectedChildren: wrong selected children count for ['menupopup node', address: [object XULElement], role: combobox list, name: 'item2', address: [xpconnect wrapped (nsISupports, nsIAccessible, nsIAccessibleSelectable)]] - got +0, expected 1
SimpleTest.is@chrome://mochikit/content/tests/SimpleTest/SimpleTest.js:268:5
testSelectableSelection@chrome://mochitests/content/a11y/accessible/tests/mochitest/selectable.js:19:3
doTest/<@chrome://mochitests/content/a11y/accessible/tests/mochitest/selectable/test_menulist.xul:47:9
setTimeout handler*SimpleTest_setTimeoutShim@chrome://mochikit/content/tests/SimpleTest/SimpleTest.js:622:12
doTest@chrome://mochitests/content/a11y/accessible/tests/mochitest/selectable/test_menulist.xul:46:7
setTimeout handler*SimpleTest_setTimeoutShim@chrome://mochikit/content/tests/SimpleTest/SimpleTest.js:622:12
addA11yLoadEvent/waitForDocLoad/<@chrome://mochitests/content/a11y/accessible/tests/mochitest/common.js:169:9
setTimeout handler*SimpleTest_setTimeoutShim@chrome://mochikit/content/tests/SimpleTest/SimpleTest.js:622:12
waitForDocLoad@chrome://mochitests/content/a11y/accessible/tests/mochitest/common.js:159:5
SimpleTest.waitForFocus/waitForFocusInner/focusedOrLoaded/<@chrome://mochikit/content/tests/SimpleTest/SimpleTest.js:741:59
27 INFO TEST-UNEXPECTED-FAIL | chrome://mochitests/content/a11y/accessible/tests/mochitest/selectable/test_menulist.xul | Can't get accessible for  'cb1_item2'
getAccessible@chrome://mochitests/content/a11y/accessible/tests/mochitest/common.js:276:9
testSelectableSelection@chrome://mochitests/content/a11y/accessible/tests/mochitest/selectable.js:24:23
doTest/<@chrome://mochitests/content/a11y/accessible/tests/mochitest/selectable/test_menulist.xul:47:9
setTimeout handler*SimpleTest_setTimeoutShim@chrome://mochikit/content/tests/SimpleTest/SimpleTest.js:622:12
doTest@chrome://mochitests/content/a11y/accessible/tests/mochitest/selectable/test_menulist.xul:46:7
setTimeout handler*SimpleTest_setTimeoutShim@chrome://mochikit/content/tests/SimpleTest/SimpleTest.js:622:12
addA11yLoadEvent/waitForDocLoad/<@chrome://mochitests/content/a11y/accessible/tests/mochitest/common.js:169:9
setTimeout handler*SimpleTest_setTimeoutShim@chrome://mochikit/content/tests/SimpleTest/SimpleTest.js:622:12
waitForDocLoad@chrome://mochitests/content/a11y/accessible/tests/mochitest/common.js:159:5
SimpleTest.waitForFocus/waitForFocusInner/focusedOrLoaded/<@chrome://mochikit/content/tests/SimpleTest/SimpleTest.js:741:59
28 INFO TEST-UNEXPECTED-FAIL | chrome://mochitests/content/a11y/accessible/tests/mochitest/selectable/test_menulist.xul | uncaught exception - TypeError: selectedChildren is null at testSelectableSelection@chrome://mochitests/content/a11y/accessible/tests/mochitest/selectable.js:25:9
doTest/<@chrome://mochitests/content/a11y/accessible/tests/mochitest/selectable/test_menulist.xul:47:9
setTimeout handler*SimpleTest_setTimeoutShim@chrome://mochikit/content/tests/SimpleTest/SimpleTest.js:622:12
doTest@chrome://mochitests/content/a11y/accessible/tests/mochitest/selectable/test_menulist.xul:46:7
setTimeout handler*SimpleTest_setTimeoutShim@chrome://mochikit/content/tests/SimpleTest/SimpleTest.js:622:12
addA11yLoadEvent/waitForDocLoad/<@chrome://mochitests/content/a11y/accessible/tests/mochitest/common.js:169:9
setTimeout handler*SimpleTest_setTimeoutShim@chrome://mochikit/content/tests/SimpleTest/SimpleTest.js:622:12
waitForDocLoad@chrome://mochitests/content/a11y/accessible/tests/mochitest/common.js:159:5
SimpleTest.waitForFocus/waitForFocusInner/focusedOrLoaded/<@chrome://mochikit/content/tests/SimpleTest/SimpleTest.js:741:59

Do you know why that is?

Comment 21

[Mike Conley (:mconley) (:⚙️)]

Comment on attachment 8742536 [details]
MozReview Request: Bug 1263887 - Update <select>'s on mutation for e10s. r=Felipe

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/47267/diff/5-6/

Comment 22

[Yura Zenevich [:yzen] (please use "needinfo")]

Taking ni? off, since we chatted in IRC

Comment 23

[Mike Conley (:mconley) (:⚙️)]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=6ba6cddd18d4

Comment 24

[Mike Conley (:mconley) (:⚙️)]

Comment on attachment 8742536 [details]
MozReview Request: Bug 1263887 - Update <select>'s on mutation for e10s. r=Felipe

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/47267/diff/6-7/

Comment 25

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/3dce9ed6c341

Comment 26

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/3dce9ed6c341

Comment 27

[Chris Peterson [:cpeterson]]

Mike, should we uplift your <select> fix to Aurora 48, in case we can enable e10s for some release users with Firefox 48?

Comment 28

[Mike Conley (:mconley) (:⚙️)]

Yep. Will request uplift now that this has had time to bake.

Comment 29

[Mike Conley (:mconley) (:⚙️)]

Comment on attachment 8742536 [details]
MozReview Request: Bug 1263887 - Update <select>'s on mutation for e10s. r=Felipe

Approval Request Comment
[Feature/regressing bug #]:

e10s

[User impact if declined]:

Users that have e10s enabled, and have opened <select> drop downs on pages that modify the contents of that <select> with script will not see those changes manifest until the <select> is re-opened.

[Describe test coverage new/current, TreeHerder]:

Manual testing, though it's had a number of days to bake now.

[Risks and why]: 

Pretty low, and this affects e10s only.

[String/UUID change made/needed]:

None.

Comment 30

[Liz Henry (:lizzard) (relman/hg->git project)]

Comment on attachment 8742536 [details]
MozReview Request: Bug 1263887 - Update <select>'s on mutation for e10s. r=Felipe

Fix for dropdown menus, please uplift to aurora.

Comment 31

[Mike Conley (:mconley) (:⚙️)]

remote:   https://hg.mozilla.org/releases/mozilla-aurora/rev/45197bd1bd11

Comment 32

[Mike Conley (:mconley) (:⚙️)]

Attachment: Bugnotes

http://people.mozilla.org/~mconley2/bugnotes/bug-1263887.html