1263954 - TEST-UNEXPECTED-FAIL | browser/extensions/loop/chrome/test/mochitest/browser_copypanel.js | Test timed out / uncaught exception

Status: RESOLVED FIXED

(Hello (Loop) :: Client, defect, P1)

Description

[Mark Banner (:standard8)]

I was just doing a try run of latest master to test a different bug, as I result, I started finding lots of issues with browser_copypanel.js.

Looks like bug 1239965 added the test

https://treeherder.mozilla.org/#/jobs?repo=try&revision=e376a88e5e72&selectedJob=19355314

162 INFO Entering test bound test_copy_panel_shown
 07:18:11     INFO -  163 INFO Console message: [JavaScript Error: "TypeError: PanelUI.panel is undefined" {file: "chrome://browser/content/browser.js" line: 2499}]
 07:18:11     INFO -  gMenuButtonBadgeManager.uninit@chrome://browser/content/browser.js:2499:5
 07:18:11     INFO -  gBrowserInit.onUnload@chrome://browser/content/browser.js:1459:5
 07:18:11     INFO -  onunload@chrome://browser/content/browser.xul:1:1
 07:18:11     INFO -  164 INFO Console message: [JavaScript Warning: "Unknown property 'user-select'.  Declaration dropped." {file: "chrome://loop/content/shared/css/common.css" line: 480 column: 13 source: "  user-select: none;"}]
 07:18:11     INFO -  165 INFO TEST-PASS | browser/extensions/loop/chrome/test/mochitest/browser_copypanel.js | copy panel exists on copy - {"_prevFocus":null,"_fadeTimer":null,"_currentFocus":null} != null -
 07:18:11     INFO -  166 INFO TEST-PASS | browser/extensions/loop/chrome/test/mochitest/browser_copypanel.js | triggered telemetry count for showing - 1 === 1 -
 07:18:11     INFO -  167 INFO Leaving test bound test_copy_panel_shown
 07:18:11     INFO -  168 INFO Entering test bound test_click_yes_again
 07:18:11     INFO -  169 INFO TEST-UNEXPECTED-FAIL | browser/extensions/loop/chrome/test/mochitest/browser_copypanel.js | uncaught exception - TypeError: iframe.parentNode.hidePopup is not a function at test_copy_panel_shown/histogram<@chrome://mochitests/content/browser/browser/extensions/loop/chrome/test/mochitest/browser_copypanel.js:72:5
 07:18:11     INFO -  testClick/</</<@chrome://mochitests/content/browser/browser/extensions/loop/chrome/test/mochitest/browser_copypanel.js:64:24
 07:18:11     INFO -  setTimeout handler*SimpleTest_setTimeoutShim@chrome://mochikit/content/tests/SimpleTest/SimpleTest.js:622:12
 07:18:11     INFO -  testClick/</<@chrome://mochitests/content/browser/browser/extensions/loop/chrome/test/mochitest/browser_copypanel.js:64:7
 07:18:11     INFO -  EventListener.handleEvent*EventTargetInterposition.methods.addEventListener@resource://gre/modules/RemoteAddonsParent.jsm:631:5
 07:18:11     INFO -  AddonInterpositionService.prototype.interposeProperty/desc.value@resource://gre/components/multiprocessShims.js:160:52
 07:18:11     INFO -  testClick/<@chrome://mochitests/content/browser/browser/extensions/loop/chrome/test/mochitest/browser_copypanel.js:61:5
 07:18:11     INFO -  testClick@chrome://mochitests/content/browser/browser/extensions/loop/chrome/test/mochitest/browser_copypanel.js:60:10
07:18:11 INFO - test_copy_panel_shown@chrome://mochitests/content/browser/browser/extensions/loop/chrome/test/mochitest/browser_copypanel.js:71:25


474 INFO Entering test bound test_copy_panel_shown
 07:27:53     INFO -  475 INFO Console message: [JavaScript Error: "TypeError: PanelUI.panel is undefined" {file: "chrome://browser/content/browser.js" line: 2499}]
 07:27:53     INFO -  gMenuButtonBadgeManager.uninit@chrome://browser/content/browser.js:2499:5
 07:27:53     INFO -  gBrowserInit.onUnload@chrome://browser/content/browser.js:1459:5
 07:27:53     INFO -  onunload@chrome://browser/content/browser.xul:1:1
 07:27:53     INFO -  476 INFO Console message: [JavaScript Warning: "Unknown property 'user-select'.  Declaration dropped." {file: "chrome://loop/content/shared/css/common.css" line: 480 column: 13 source: "  user-select: none;"}]
 07:27:53     INFO -  477 INFO TEST-PASS | browser/extensions/loop/chrome/test/mochitest/browser_copypanel.js | copy panel exists on copy - {"_prevFocus":null,"_fadeTimer":null,"_currentFocus":null} != null -
 07:27:53     INFO -  478 INFO TEST-PASS | browser/extensions/loop/chrome/test/mochitest/browser_copypanel.js | triggered telemetry count for showing - 1 === 1 -
 07:27:53     INFO -  479 INFO Leaving test bound test_copy_panel_shown
 07:27:53     INFO -  480 INFO Entering test bound test_click_yes_again
 07:27:53     INFO -  481 INFO TEST-PASS | browser/extensions/loop/chrome/test/mochitest/browser_copypanel.js | copy panel still exists - {"_prevFocus":null,"_fadeTimer":null,"_currentFocus":null} != null -
 07:27:53     INFO -  482 INFO TEST-PASS | browser/extensions/loop/chrome/test/mochitest/browser_copypanel.js | triggered telemetry count for yes again - 1 === 1 -
 07:27:53     INFO -  483 INFO Leaving test bound test_click_yes_again
 07:27:53     INFO -  484 INFO Entering test bound test_click_yes_never
 07:27:53     INFO -  485 INFO TEST-PASS | browser/extensions/loop/chrome/test/mochitest/browser_copypanel.js | copy panel removed - null == null -
 07:27:53     INFO -  486 INFO TEST-PASS | browser/extensions/loop/chrome/test/mochitest/browser_copypanel.js | triggered telemetry count for yes never - 1 === 1 -
 07:27:53     INFO -  487 INFO Leaving test bound test_click_yes_never
 07:27:53     INFO -  488 INFO Entering test bound test_click_no_again
 07:27:53     INFO -  489 INFO Console message: [JavaScript Error: "The Components object is deprecated. It will soon be removed." {file: "chrome://loop/content/shared/js/utils.js" line: 9}]
07:27:53 INFO - 490 INFO TEST-UNEXPECTED-FAIL | browser/extensions/loop/chrome/test/mochitest/browser_copypanel.js | Test timed out -


301 INFO Entering test bound test_copy_panel_shown
 07:30:45     INFO -  302 INFO Console message: [JavaScript Error: "TypeError: PanelUI.panel is undefined" {file: "chrome://browser/content/browser.js" line: 2499}]
 07:30:45     INFO -  gMenuButtonBadgeManager.uninit@chrome://browser/content/browser.js:2499:5
 07:30:45     INFO -  gBrowserInit.onUnload@chrome://browser/content/browser.js:1459:5
 07:30:45     INFO -  onunload@chrome://browser/content/browser.xul:1:1
 07:30:45     INFO -  303 INFO Console message: [JavaScript Warning: "Unknown property 'user-select'.  Declaration dropped." {file: "chrome://loop/content/shared/css/common.css" line: 480 column: 13 source: "  user-select: none;"}]
07:30:45 INFO - 304 INFO TEST-UNEXPECTED-FAIL | browser/extensions/loop/chrome/test/mochitest/browser_copypanel.js | Test timed out -

Comment 1

[Ed Lee :Mardak]

I retriggered various failing and passing tests, and all the failures seem to be on Linux so far:

2 of 3 Linux opt Mochi-bc5: Test timed out
1 of 3 Linux opt Me10s-bc2: TypeError: iframe.parentNode.hidePopup is not a function
3 of 3 Linux dbg Mochi-bc5: Test timed out
3 of 3 Linux dbg Me10s-bc3: Test timed out
1 of 3 Lin64 opt Mochi-bc5: Test timed out
2 of 3 Lin64 opt Me10s-bc2: TypeError: iframe.parentNode.hidePopup is not a function
3 of 3 Lin64 dbg Mochi-bc5: Test timed out
3 of 3 Lin64 dbg Me10s-bc4: Test timed out
3 of 3 Lin64 dbg tc-Mc-bc5: Test timed out
3 of 3 Lin64 dbg tcMes-bc4: Test timed out

Comment 2

[Ed Lee :Mardak]

The "PanelUI.panel is undefined" issue is somewhat okay as it's triggered by a bunch of other tests that open and close a browser window quickly. There's 3 hello tests that open a private browsing window and close them immediately that trigger the error.

Digging into the other timing errors..

Comment 3

[Ed Lee :Mardak]

There's also a marionette test failure when running in m-c as opposed to loop repository:
 TypeError: Cu is undefinedinit@http://localhost:49281/add-on/panels/js/copy.js:89:9 

It needed an updated reference in shared/test/frontend_tester.py

Comment 4

[GitHub Autolander Bot]

Attachment: [loop] Mardak:bug-1263954-copytest > mozilla:master

Comment 5

[Ed Lee :Mardak]

Comment on attachment 8741728 [details] [review]
[loop] Mardak:bug-1263954-copytest > mozilla:master

After much debugging, it looks like the test timing out is caused by a mysterious popuphiding of the just-opened copy panel. Here's the call stack from within a "popuphiding" listener:

> EventListener.handleEvent*EventTargetInterposition.methods.addEventListener@resource://gre/modules/RemoteAddonsParent.jsm:633:5
> AddonInterpositionService.prototype.interposeProperty/desc.value@resource://gre/components/multiprocessShims.js:161:52

It looks like there's some magic cpows that's munging the actual thing causing the popup to hide, and I still haven't figured out what is closing it. It doesn't look like RemoteAddonsChild.jsm is being triggered as the target popup being hidden is the xul:panel not the xul:browser.

Adding debugging to the various events and panel states results in the copy panel "popupshown" with the popup state of "open" then immediately "popuphiding" with state "hiding". But this only happens sometimes intermittently.

The reason this caused problems is that the test relied on the popup being hidden to continue, but if it's already closed, it ends up timing out.

To avoid this issue of the popup sometimes closing early, I added a callback that indicates when the test should continue.

Comment 6

[Mark Banner (:standard8)]

Comment on attachment 8741728 [details] [review]
[loop] Mardak:bug-1263954-copytest > mozilla:master

Looks good. r=Standard8

Comment 7

[Mark Banner (:standard8)]

I landed this to aid the 1.3 release work:

https://github.com/mozilla/loop/commit/eda16b5fb40d2deb6e01824d8ce0aff3879fd8bd