Land version 1.3.0 of the Loop system add-on in mozilla-central

RESOLVED FIXED in Firefox 47

Status

defect
P1
normal
Rank:
1
RESOLVED FIXED
3 years ago
3 years ago

People

(Reporter: standard8, Assigned: standard8)

Tracking

unspecified
mozilla48
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(firefox47 fixed, firefox48 fixed)

Details

(Whiteboard: [btpp-fix-now], )

Attachments

(2 attachments)

Assignee

Comment 2

3 years ago
Comment on attachment 8742966 [details] [diff] [review]
Land version 1.3.0 of the Loop system add-on in mozilla-central, rs=Standard8 for already reviewed code.

Review of attachment 8742966 [details] [diff] [review]:
-----------------------------------------------------------------

rs=me. Summary of changes & bug dependencies will happen tomorrow.
Attachment #8742966 - Flags: review+
Assignee

Comment 4

3 years ago
Summary of changes:

- Better messaging on the infobar when tab sharing.
- e10s fixes (note: e10s only enabled for 47 & later)
- Ending a room session prompts the user to name the room
- Added experimental feature to prompt to create a room when copying the room name (disabled by default, but has a roll-out plan controlled from outside FF)

Comment 5

3 years ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/f4ab4fd96f8e
Status: NEW → RESOLVED
Last Resolved: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla48
Depends on: 1145733
Assignee

Updated

3 years ago
Blocks: 1271260
Assignee

Updated

3 years ago
Blocks: 1274226
Assignee

Comment 6

3 years ago
Posted patch Beta versionSplinter Review
Beta version that fixes slight bitrot in en-US/loop.properties

Approval Request Comment
[Feature/regressing bug #]: Firefox Hello 1.3.2
[User impact if declined]: Firefox 47 users won't have the same version as Firefox 46.
[Describe test coverage new/current, TreeHerder]: Landed in central & aurora. Shipped via go faster to beta 47 and now release 46
[Risks and why]: Landing shipped code.
[String/UUID change made/needed]: None
Attachment #8755575 - Flags: approval-mozilla-aurora?
Assignee

Comment 7

3 years ago
Comment on attachment 8755575 [details] [diff] [review]
Beta version

Ahem, I meant that request for beta.
Attachment #8755575 - Flags: approval-mozilla-aurora? → approval-mozilla-beta?
Comment on attachment 8755575 [details] [diff] [review]
Beta version

Makes sense, Beta47+
Attachment #8755575 - Flags: approval-mozilla-beta? → approval-mozilla-beta+
You need to log in before you can comment on or make changes to this bug.