Closed Bug 1264060 Opened 4 years ago Closed 4 years ago

Nexus 5 L and Aries builds (eng/debug) (including blobfree) are not pushed to Taskcluster artifacts repo correctly.

Categories

(Firefox OS Graveyard :: General, defect)

ARM
Gonk (Firefox OS)
defect
Not set

Tracking

(firefox48 fixed)

RESOLVED FIXED
2.6 S12 - 4/22
Tracking Status
firefox48 --- fixed

People

(Reporter: nhirata, Assigned: nhirata)

References

Details

(Whiteboard: fixed-in-pine)

Attachments

(1 file, 3 obsolete files)

1. see https://treeherder.mozilla.org/#/jobs?repo=pine&selectedJob=13224&filter-searchStr=B2G%20Device%20Image%20opt%20Aries%20Device%20Image%20[TC]%20B2G%20Aries%20Eng%20Aries%28Be%29 

Errors received:
The directory '/home/worker/.cache/pip/http' or its parent directory is not owned by the current user and the cache has been disabled. Please check the permissions and owner of that directory. If executing pip with sudo, you may want sudo's -H flag.
Return code: 0
rm: cannot remove `out/target/product/aries/aries.blobfree-dist.zip': No such file or directory
Summary: Aries build is not pushed to Taskcluster repo correctly. → Aries build (including blobfree) is not pushed to Taskcluster repo correctly.
No longer depends on: 1264065
(In reply to Naoki Hirata :nhirata (please use needinfo instead of cc) from comment #0)

[...]

> rm: cannot remove `out/target/product/aries/aries.blobfree-dist.zip': No
> such file or directory

This is harmless, we print this as part of the building process of blobfree.
Thanks for letting me know.  That's good to know; at the same time the build is failing still:

11:02:20    DEBUG - Copying /home/worker/objdir-gecko/objdir/dist/b2g-48.0a1.en-US.linux-androideabi-arm.tar.gz to /home/worker/workspace/B2G/upload-public/b2g-48.0a1.en-US.linux-androideabi-arm.tar.gz
...
mv: cannot stat `/home/worker/workspace/B2G/upload/b2g-*.android-arm.tar.gz': No such file or directory

It looks like the wrong directory was used and this might be the reason for the failure?
Summary: Aries build (including blobfree) is not pushed to Taskcluster repo correctly. → Nexus 5 L and Aries builds (eng/debug) (including blobfree) are not pushed to Taskcluster artifacts repo correctly.
Turns out that Nexus 5 L on MC are affected as well.
Not sure if this is the appropriate patch, need to test...
Woops.  The old way of building doesn't work.  need to talk to taskcluster team to find out how to test my patch.
The try graph is here : https://tools.taskcluster.net/task-graph-inspector/#cJglsQ8bRsaQCwSE5btpgQ

Having said that, I found out from garndt that Bug 1220704 — FIXED, wcosta@mozilla.com — Remove docker-worker:image:taskclusterprivate/phone-builder:* from moz-tree:level:1 role

So I wouldn't be able to see my results there. Wander is on PTO so I don't know how to test my patch.
Comment on attachment 8741077 [details] [diff] [review]
0001-bug-1264060-Nexus-5-L-and-Aries-builds-are-not-pushe.patch

Review of attachment 8741077 [details] [diff] [review]:
-----------------------------------------------------------------

Alexandre, could you review the patch?  I think the rename and relocation of the android tar ball is causing the issue with the build failure.
Attachment #8741077 - Flags: review?(lissyx+mozillians)
Comment on attachment 8741077 [details] [diff] [review]
0001-bug-1264060-Nexus-5-L-and-Aries-builds-are-not-pushe.patch

Review of attachment 8741077 [details] [diff] [review]:
-----------------------------------------------------------------

I guess this is the proper path forward and we can even fix things that were broken for a long time. So it's okay for me with those changes included.

Wander (:wcosta) could also have a look at this (but he seems to be PTO until 18/04) :)

::: testing/taskcluster/scripts/phone-builder/post-build.sh
@@ +13,4 @@
>  DEVICE=${TARGET%%-*}
>  
>  mv $WORKSPACE/B2G/upload/sources.xml $HOME/artifacts/sources.xml
> +mv $WORKSPACE/B2G/upload-public/b2g-*.android*-arm.tar.gz $HOME/artifacts/b2g-android*-arm.tar.gz

I guess we want to move to artifacts-public since this tarball only contains free software?

@@ +17,2 @@
>  mv $WORKSPACE/B2G/upload/${TARGET}.zip $HOME/artifacts/${TARGET}.zip
>  mv $WORKSPACE/B2G/upload/gaia.zip $HOME/artifacts/gaia.zip

We could do the same for gaia.zip
Attachment #8741077 - Flags: review?(lissyx+mozillians) → review+
Assignee: nobody → nhirata.bugzilla
Ya, I agree; we can make the other parts public.  I'll do that in another bug.

Since the builds are blocked for try, I can't test.  The scope in taskcluster doesn't allow for it ( see  Bug 1220704 ).  Since the builds are broken, you're right. I don't see too much harm in pushing.

Wes, could you checkin please?
Flags: needinfo?(wkocher)
Keywords: checkin-needed
Let's use MozReview to land it ...
Flags: needinfo?(wkocher)
Attachment #8743371 - Flags: review?(lissyx+mozillians) → review+
Comment on attachment 8743371 [details]
MozReview Request: Bug 1264060 - Update arch triplet for B2G builds r?gerard-majax

https://reviewboard.mozilla.org/r/47727/#review44525
https://hg.mozilla.org/mozilla-central/rev/ab5be7357e53
Status: NEW → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → 2.6 S12 - 4/22
Okay that patch is not good, I missed the fact that the tarball is named "b2g-48.0a1-..." :/
backed out in https://hg.mozilla.org/mozilla-central/rev/4e3ad95d689a
Status: RESOLVED → REOPENED
Flags: needinfo?(nhirata.bugzilla)
Resolution: FIXED → ---
I am handling this.
Flags: needinfo?(nhirata.bugzilla)
So, in the past, we had:
> mv $WORKSPACE/B2G/upload/b2g-*.android-arm.tar.gz $HOME/artifacts/b2g-android-arm.tar.gz

And the build system was producing:
> 19:19:36    DEBUG - Copying /home/worker/objdir-gecko/objdir/dist/b2g-48.0a1.en-US.android-arm.tar.gz to /home/worker/workspace/B2G/upload-public/b2g-48.0a1.en-US.android-arm.tar.gz

Today, we have:
> 19:27:45    DEBUG - Copying /home/worker/objdir-gecko/objdir/dist/b2g-48.0a1.en-US.linux-androideabi-arm.tar.gz to /home/worker/workspace/B2G/upload-public/b2g-48.0a1.en-US.linux-androideabi-arm.tar.gz

So it becomes obvious that |b2g-*.android-arm.tar.gz| cannot match |b2g-48.0a1.en-US.linux-androideabi-arm.tar.gz|, since the |android-arm| string became a standard triplet |linux-androideabi-arm|.
Attachment #8741077 - Attachment is obsolete: true
Attachment #8743371 - Attachment is obsolete: true
Comment on attachment 8743371 [details]
MozReview Request: Bug 1264060 - Update arch triplet for B2G builds r?gerard-majax

https://reviewboard.mozilla.org/r/47727/#review44819
Attachment #8743371 - Flags: review+
Comment on attachment 8743371 [details]
MozReview Request: Bug 1264060 - Update arch triplet for B2G builds r?gerard-majax

https://reviewboard.mozilla.org/r/47727/#review44821
Attachment #8743371 - Flags: review+
Comment on attachment 8743782 [details] [diff] [review]
Update arch triplet for B2G builds

Sorry for this, but I am unable to repush to mozreview to and the fix :/
Flags: needinfo?(cbook)
Comment on attachment 8743371 [details]
MozReview Request: Bug 1264060 - Update arch triplet for B2G builds r?gerard-majax

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/47727/diff/1-2/
Attachment #8743371 - Attachment description: MozReview Request: bug 1264060 - Nexus 5 L and Aries builds are not pushed to Taskcluster artifacts repo correctly. r?gerard-majax → MozReview Request: Bug 1264060 - Update arch triplet for B2G builds r?gerard-majax
Attachment #8743371 - Attachment is obsolete: false
Attachment #8743782 - Attachment is obsolete: true
Flags: needinfo?(cbook)
Re-uploading because we need to land directly on m-c
Attachment #8743804 - Flags: review+
Flags: needinfo?(cbook)
checkin-needed since mozreview cannot handle it
Keywords: checkin-needed
relanded as relanded as https://hg.mozilla.org/mozilla-central/rev/1152d99d8c53
Status: REOPENED → RESOLVED
Closed: 4 years ago4 years ago
Flags: needinfo?(cbook)
Resolution: --- → FIXED
Attachment #8743371 - Attachment is obsolete: true
You need to log in before you can comment on or make changes to this bug.