Closed Bug 1264138 Opened 4 years ago Closed 4 years ago

Sync settings top bar styling is wrong

Categories

(Firefox for Android :: Settings and Preferences, defect)

defect
Not set

Tracking

()

VERIFIED FIXED
Firefox 48
Tracking Status
firefox47 + verified
firefox48 --- verified

People

(Reporter: Grisha, Assigned: ahunt)

Details

Attachments

(3 files)

See screenshot.

Margaret, I'm cc-ing you because I wasn't sure who's currently working on relevant code.
Sounds like a theme issue. Cc'ing the usual suspects.
Flags: needinfo?(michael.l.comella)
Flags: needinfo?(ahunt)
Most likely a regression caused by Bug 1205124. I should look into this!
Assignee: nobody → ahunt
Flags: needinfo?(michael.l.comella)
Flags: needinfo?(ahunt)
Our theming inheritance around Preferences still seems quite messy, however given we'll
need to uplift this I'm planning to tackle this in a separate bug.

Review commit: https://reviewboard.mozilla.org/r/46451/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/46451/
Attachment #8741390 - Flags: review?(s.kaspari)
I'm not happy with how split up our theming is for our various preference activites, so I filed Bug 1264665 to fix that. We'll probably want to uplift this Bug to Aurora (Bug 1205124 needs to get uplifted to Aurora), so I'd prefer to avoid doing that as part of this bug.
Status: NEW → ASSIGNED
Comment on attachment 8741390 [details]
MozReview Request: Bug 1264138 - Upgrade FxAccountStatusActivity to use AppCompatActivity too r?sebastian

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/46451/diff/1-2/
Comment on attachment 8741390 [details]
MozReview Request: Bug 1264138 - Upgrade FxAccountStatusActivity to use AppCompatActivity too r?sebastian

https://reviewboard.mozilla.org/r/46451/#review43317
Attachment #8741390 - Flags: review?(s.kaspari) → review+
https://hg.mozilla.org/integration/fx-team/rev/52e570214af308e604b413645136f340ad412711
Bug 1264138 - Upgrade FxAccountStatusActivity to use AppCompatActivity too r=sebastian
[Tracking Requested - why for this release]: If Bug 1205124 gets uplifted this regression will affect 47. We need to uplift that since it's a crash-fix.
https://hg.mozilla.org/mozilla-central/rev/52e570214af3
Status: ASSIGNED → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 48
Verified as fixed using:
Device: HTC Desire 820 (Android 5.0.2)
Build: Firefox for Android 48.0a1 (2016-04-17)
Comment on attachment 8741390 [details]
MozReview Request: Bug 1264138 - Upgrade FxAccountStatusActivity to use AppCompatActivity too r?sebastian

Approval Request Comment
[Feature/regressing bug #]: Bug 1205124
[User impact if declined]: Sync settings have different appearance on older (2.3) devices, have no title on newer (>= 4.0) devices.
[Describe test coverage new/current, TreeHerder]: Manual testing on: 2.3 phone, 4.3 phone, 5.0 tablet, 6.0 tablet. Tested on nightly.
[Risks and why]: Low risk - upgrades our sync settings activity to use AppCompatActivity, to mirror the rest of settings.
[String/UUID change made/needed]: none.

This needs approval together with Bug 1205124 (which fixes the master password dialog crash on aurora).
Attachment #8741390 - Flags: approval-mozilla-aurora?
Comment on attachment 8741390 [details]
MozReview Request: Bug 1264138 - Upgrade FxAccountStatusActivity to use AppCompatActivity too r?sebastian

Regression fix that was verified on Nightly, Aurora47+
Attachment #8741390 - Flags: approval-mozilla-aurora? → approval-mozilla-aurora+
Verified as fixed using:
Device: HTC Desire 820 (Android 5.0.2)
Build: Firefox for Android 47 Beta 1
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.