1264138 - Sync settings top bar styling is wrong

Status: VERIFIED FIXED

(Firefox for Android Graveyard :: Settings and Preferences, defect)

Description

[:Grisha Kruglov]

Attachment: Screenshot_20160412-170113.png

See screenshot.

Margaret, I'm cc-ing you because I wasn't sure who's currently working on relevant code.

Comment 1

[:Margaret Leibovic]

Sounds like a theme issue. Cc'ing the usual suspects.

Comment 2

[Andrzej Hunt :ahunt]

Most likely a regression caused by Bug 1205124. I should look into this!

Comment 3

[Andrzej Hunt :ahunt]

Attachment: MozReview Request: Bug 1264138 - Upgrade FxAccountStatusActivity to use AppCompatActivity too r?sebastian

Our theming inheritance around Preferences still seems quite messy, however given we'll
need to uplift this I'm planning to tackle this in a separate bug.

Review commit: https://reviewboard.mozilla.org/r/46451/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/46451/

Comment 4

[Andrzej Hunt :ahunt]

I'm not happy with how split up our theming is for our various preference activites, so I filed Bug 1264665 to fix that. We'll probably want to uplift this Bug to Aurora (Bug 1205124 needs to get uplifted to Aurora), so I'd prefer to avoid doing that as part of this bug.

Comment 5

[Andrzej Hunt :ahunt]

Comment on attachment 8741390 [details]
MozReview Request: Bug 1264138 - Upgrade FxAccountStatusActivity to use AppCompatActivity too r?sebastian

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/46451/diff/1-2/

Comment 6

[Sebastian Kaspari (:sebastian; :pocmo)]

Comment on attachment 8741390 [details]
MozReview Request: Bug 1264138 - Upgrade FxAccountStatusActivity to use AppCompatActivity too r?sebastian

https://reviewboard.mozilla.org/r/46451/#review43317

Comment 7

[Andrzej Hunt :ahunt]

https://hg.mozilla.org/integration/fx-team/rev/52e570214af308e604b413645136f340ad412711
Bug 1264138 - Upgrade FxAccountStatusActivity to use AppCompatActivity too r=sebastian

Comment 8

[Andrzej Hunt :ahunt]

[Tracking Requested - why for this release]: If Bug 1205124 gets uplifted this regression will affect 47. We need to uplift that since it's a crash-fix.

Comment 9

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/52e570214af3

Comment 10

[Teodora Vermesan (:TeoVermesan)]

Attachment: Screenshot_2016-04-18-11-28-37.png

Verified as fixed using:
Device: HTC Desire 820 (Android 5.0.2)
Build: Firefox for Android 48.0a1 (2016-04-17)

Comment 11

[Andrzej Hunt :ahunt]

Comment on attachment 8741390 [details]
MozReview Request: Bug 1264138 - Upgrade FxAccountStatusActivity to use AppCompatActivity too r?sebastian

Approval Request Comment
[Feature/regressing bug #]: Bug 1205124
[User impact if declined]: Sync settings have different appearance on older (2.3) devices, have no title on newer (>= 4.0) devices.
[Describe test coverage new/current, TreeHerder]: Manual testing on: 2.3 phone, 4.3 phone, 5.0 tablet, 6.0 tablet. Tested on nightly.
[Risks and why]: Low risk - upgrades our sync settings activity to use AppCompatActivity, to mirror the rest of settings.
[String/UUID change made/needed]: none.

This needs approval together with Bug 1205124 (which fixes the master password dialog crash on aurora).

Comment 12

[Ritu Kothari (:ritu) (Inactive, please n-i to RyanVM, jcristau, or pascal)]

Comment on attachment 8741390 [details]
MozReview Request: Bug 1264138 - Upgrade FxAccountStatusActivity to use AppCompatActivity too r?sebastian

Regression fix that was verified on Nightly, Aurora47+

Comment 13

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/releases/mozilla-aurora/rev/cf45e4c41f1f

Comment 14

[Teodora Vermesan (:TeoVermesan)]

Verified as fixed using:
Device: HTC Desire 820 (Android 5.0.2)
Build: Firefox for Android 47 Beta 1