1264665 - Simplify ActionBar setup and theming inheritance for GeckoPreferences and FxAccountStatusActivity

Status: RESOLVED INCOMPLETE

(Firefox for Android Graveyard :: Theme and Visual Design, defect, P4)

Description

[Andrzej Hunt :ahunt]

We're doing unnecessary actionbar initialisation in code which we should be able to avoid by setting up our theming correctly. We also have our theming split across default, v11, v14 and v21 theme files - we should be able to simplify this now that we (A) only support >= 4.0 and (B) are using AppCompatActivity.

GeckoPreferences:
http://mxr.mozilla.org/mozilla-central/source/mobile/android/base/java/org/mozilla/gecko/preferences/GeckoPreferences.java#414

FxAccountStatusActivity:
http://mxr.mozilla.org/mozilla-central/source/mobile/android/services/src/main/java/org/mozilla/gecko/fxa/activities/FxAccountStatusActivity.java#70

We can probably avoid having a separate theme/style file (fxaccount_styles) too, let's look into cleaning that up (we can probably just use Gecko.Preferences directly).

Comment 1

[BMO Automation]

We have completed our launch of our new Firefox on Android. The development of the new versions use GitHub for issue tracking. If the bug report still reproduces in a current version of [Firefox on Android nightly](https://play.google.com/store/apps/details?id=org.mozilla.fenix) an issue can be reported at the [Fenix GitHub project](https://github.com/mozilla-mobile/fenix/). If you want to discuss your report please use [Mozilla's chat](https://wiki.mozilla.org/Matrix#Connect_to_Matrix) server https://chat.mozilla.org and join the [#fenix](https://chat.mozilla.org/#/room/#fenix:mozilla.org) channel.