1264152 - Create a tag for OriginAttribute mochitests

Status: NEW

(Core :: DOM: Security, defect, P3)

Description

[Paul Theriault [:pauljt] (no longer reading bugmail)]

We want to tag all the containers/origin attributes related tests, so that we can selectively run these tests as we work through the backlog of origin attributes bugs.

Comment 1

[Andrea Marchesini [:baku]]

Attachment: tag.patch

Comment 2

[Andrea Marchesini [:baku]]

This patch is more about ContextIdentity UI or ContextIdentity features starting from an UI iteration.
I don't know where all the other tests are located.

Comment 3

[Paul Theriault [:pauljt] (no longer reading bugmail)]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=c205da222174

Comment 4

[Paul Theriault [:pauljt] (no longer reading bugmail)]

Attachment: MozReview Request: Bug 1264152 - Create a tag for OriginAttribute mochitests

Review commit: https://reviewboard.mozilla.org/r/47965/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/47965/

Comment 5

[Paul Theriault [:pauljt] (no longer reading bugmail)]

I'm still looking for other relevant tests. I don't see any others but I'll check with some more people before i submit this.

Comment 6

[Paul Theriault [:pauljt] (no longer reading bugmail)]

Tanvi/Dave, what was your thinking on this. Did we only want to tag new tests? Or do we want to go back and tag all the tests were changed as part of the origin attribute work. If that latter, I think the following is a comprehensive list of tests changed by origin related bugs which block bug 1191418. 

Would we want to tag all of these? Some are very relevant, like the caps ones, but others less so. 


caps/tests/mochitest/test_addonMayLoad.html 
caps/tests/mochitest/test_principal_jarprefix_origin_appid_appstatus.html
caps/tests/unit/test_origin.js
dom/apps/tests/test_bug_1168300.html
dom/apps/tests/unit/test_moziapplication.js
dom/indexedDB/test/bug839193.js
dom/indexedDB/test/unit/test_idle_maintenance.js
dom/indexedDB/test/unit/xpcshell-head-parent-process.js
dom/workers/test/gtest/TestReadWrite.cpp
extensions/cookie/test/unit/test_permmanager_defaults.js
extensions/cookie/test/unit/test_permmanager_migrate_4-5.js
image/test/unit/test_private_channel.js
js/xpconnect/tests/components/js/xpctest_params.js
js/xpconnect/tests/components/native/xpctest_params.cpp
js/xpconnect/tests/unit/test_params.js
netwerk/test/unit/test_cache_jar.js
netwerk/test/unit/test_cacheflags.js
netwerk/test/unit/test_predictor.js
netwerk/test/unit_ipc/child_app_offline.js
xpcom/tests/gtest/TestTokenizer.cpp

Comment 7

[Yoshi Cheng-Hao Huang [:allstars.chh][:allstarschh][:yoshi]]

Have we discussed which tests should have the tag [OA]?
Gijs mentioned in  https://bugzilla.mozilla.org/show_bug.cgi?id=1237077#c43
He said [OA] is confusing maybe we should use [originattributes] for this?

Comment 8

[Tanvi Vyas[:tanvi]]

We should have two tags, 'contextualidentity' and 'originattributes'.

Then we can go about this in two ways:
1) All originattributes tests would also be flagged for contextualidentity.  So to test containers, we'd only need to do './mach test contextualidentity'.

2) OriginAttribute tests would be flagged by 'originattribute'.  Tests that test usercontextid specifically and the containers user experience would be marked 'contextualidentity'.  So to test containers, we'd need to do './mach test contextualidentity && ./mach test originattribute'.

For tor isolation patches that are not originattribute specific, we should create a third tag 'tor-isolation'.  We'd end up with the same question we have now... should all originattributes tests also be marked 'tor-isolation'.  This will become quite a lot of tags for some tests, but I suppose there is no harm in that:
tags=originattributes contextualidentity tor-isolation

I lean towards method 1), since a long tag may help better explain the purpose of the test.  This might help if a test is about to be disabled in the future for intermittent failures.

So, create two tags.  Tag everything that has to do with originattributes as originattributes and contextualidentity.  Tag everything that has to do with usercontext and containers UI as contextualidentity.

For the bugs you have listed Paul, you will need to look at each one and see how to appropriately tag them.  Without knowing the bug number corresponding to the test you listed, its hard to say how they should be tagged.  For example, I'm not sure why js/xpconnect/tests/components/native/xpctest_params.cpp is on the list.  We can of course help you out with this and can discuss more in our Tuesday meeting.

Comment 9

[Daniel Veditz [:dveditz]]

Tim: this was listed as "domsecurity-active" but doesn't appear to be actively worked on. Are you going to work on this in the next quarter or should we put it in the backlog?

Comment 10

[Tim Huang[:timhuang]]

Let's put this into backlog.