Closed
Bug 1264213
Opened 9 years ago
Closed 9 years ago
WebGL 1.0.3 conformance/extensions/oes-vertex-array-object.html
Categories
(Core :: Graphics: CanvasWebGL, defect)
Core
Graphics: CanvasWebGL
Tracking
()
RESOLVED
FIXED
People
(Reporter: mtseng, Assigned: mtseng)
References
(Blocks 1 open bug)
Details
(Whiteboard: webgl-conformance gfx-noted)
Attachments
(1 obsolete file)
Testing using deleted buffers referenced by VAOs
PASS should be 255,0,0,255
PASS should be 0,255,0,255
FAIL at (0, 0) expected: 0,0,255,255 was 0,255,0,255
PASS should be 0,255,255,255
Testing that buffer bindings on VAOs don't affect default VAO ARRAY_BUFFER binding.
FAIL at (0, 0) expected: 255,0,0,255 was 0,255,255,255
FAIL at (0, 0) expected: 0,255,0,255 was 0,255,255,255
FAIL getError expected: NO_ERROR. Was INVALID_OPERATION : there should be no errors
Assignee | ||
Comment 1•9 years ago
|
||
Quote from OpenGL ES spec 3.0.4 page 315
"When a buffer, texture, or renderbuffer object is deleted, it is unbound from any
bind points it is bound to in the current context, as described for DeleteBuffers,
DeleteTextures, and DeleteRenderbuffers. Bind points in other contexts are not
affected. Attachments to unbound container objects, such as deletion of a buffer
attached to a vertex array object which is not bound to the context, are not affected
and continue to act as references on the deleted object, as described in the following
section."
So we should not clear the reference here.
Attachment #8740816 -
Flags: review?(jgilbert)
Assignee | ||
Updated•9 years ago
|
OS: Windows 7 → All
Hardware: x86_64 → All
Comment 2•9 years ago
|
||
(In reply to Morris Tseng [:mtseng] from comment #1)
> Created attachment 8740816 [details] [diff] [review]
> Don't reset the buffer reference of vao when deleting buffer.
>
> Quote from OpenGL ES spec 3.0.4 page 315
> "When a buffer, texture, or renderbuffer object is deleted, it is unbound
> from any
> bind points it is bound to in the current context, as described for
> DeleteBuffers,
> DeleteTextures, and DeleteRenderbuffers. Bind points in other contexts are
> not
> affected. Attachments to unbound container objects, such as deletion of a
> buffer
> attached to a vertex array object which is not bound to the context, are not
> affected
> and continue to act as references on the deleted object, as described in the
> following
> section."
>
> So we should not clear the reference here.
We *should not* clear references for any *unbound* vertex array object.
We *should* clear the references for the *bound* vertex array object only.
Otherwise this:
"Attachments to unbound container objects, such as deletion of a buffer
attached to a vertex array object which is not bound to the context, are not affected"
Should be just:
"Attachments to container objects, such as deletion of a buffer
attached to a vertex array object, are not affected"
It would not surprise me if the test was wrong here.
Updated•9 years ago
|
Attachment #8740816 -
Flags: review?(jgilbert) → review-
Assignee | ||
Comment 3•9 years ago
|
||
Ah, thanks for clarification. I think there is a bug in test. I'll upload a pr to upstream.
Assignee | ||
Updated•9 years ago
|
Attachment #8740816 -
Attachment is obsolete: true
Assignee | ||
Comment 4•9 years ago
|
||
PR is here: https://github.com/KhronosGroup/WebGL/pull/1608
Assignee | ||
Comment 5•9 years ago
|
||
https://github.com/KhronosGroup/WebGL/commit/3be09cca48233d4a1f2a84bdca46bacd0fb2676b
Fix by upstream.
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•