1264221 - Correctly scale/modify home screen shortcut icons

Status: RESOLVED INCOMPLETE

(Firefox for Android Graveyard :: General, defect, P5)

Description

[Sebastian Kaspari (:sebastian; :pocmo)]

Attachment: icons.png

If you compare our home screen shortcuts to Chrome's (see attached screenshot) then you can see that they modify the icon provided by the page to look more like an Android app icon. This is a nice effect and the icon fits better into the system's look and feel.

Comment 1

[Nevin Chen(Not active on Bugzilla)]

I think this is done so this bug could be closed?

Comment 2

[Sebastian Kaspari (:sebastian; :pocmo)]

Attachment: amazon-icon.png

I don't think this is done yet. I attached a screenshot: This is not the best example but you can see that we always use a full-sized icon if available. This looks odd compared to icons of native apps. Chrome seems to at least adjust the size of the icon. I thought I saw them even round corners in the past, but this doesn't seem to happen with the Amazon icon at least.

Comment 3

[Nevin Chen(Not active on Bugzilla)]

I think antlam had plan for this (bug 1307621).
And maybe it also related to bug 1234558.
Maybe we can mark this bug related?
Or may be I can work on the round corners on the icon first?

Comment 4

[Sebastian Kaspari (:sebastian; :pocmo)]

Yeah, the decision in bug 1307621 might influence what we do here or if we do anything at all.

Comment 5

[Andreas Bovens [:abovens]]

Attachment: twitter-lite.png

I've noticed that we end up with a lower quality version of the available icon than Chrome.  

See attached twitter-lite.png: on the left, the Twitter Lite icon generated by Firefox, on the right, Chrome's version.

Comment 6

[Nevin Chen(Not active on Bugzilla)]

Previously we don't use the value in the manifest as icon, so we'll have this problem. After bug 1409191 lands, this problem could be solved. 
Just one edge case, if the manifest provide a super small png, there's nothing we can do :)

Comment 7

[Nevin Chen(Not active on Bugzilla)]

Comment 6 is for PWA.
For normal browser shortcut (comment 0), we can defintely add some improvement there. Like round corner... maybe we need some UX input here.

Comment 8

[Carol Huang [:Carol]]

hi Nevin,
Please try xxxhdpi - 192x192dp ; 4dp rounded corner.
Let's see if it works better! thank you!!

Comment 9

[Nevin Chen(Not active on Bugzilla)]

Hi Wesly, this bug is for normal shortcut , not pwa shortcut. Would you please prioritize this in sprint planing?

Comment 10

[Nevin Chen(Not active on Bugzilla)]

remove whiteboard since comment 9

Comment 11

[Wesly Huang (EPM)]

this is now PWA irrelevant thus remove the whiteboard tag.

1. comment 0 is for normal shortcut, not PWA (since it's reported 2 years ago)
2. the concern in comment 5 for PWA is addressed by bug 1409191 (comment 6)

keep P2.

Comment 12

[Firefox Bug Husbandry Bot]

Re-triaging per https://bugzilla.mozilla.org/show_bug.cgi?id=1473195

Needinfo :susheel if you think this bug should be re-triaged.

Comment 14

[BMO Automation]

We have completed our launch of our new Firefox on Android. The development of the new versions use GitHub for issue tracking. If the bug report still reproduces in a current version of [Firefox on Android nightly](https://play.google.com/store/apps/details?id=org.mozilla.fenix) an issue can be reported at the [Fenix GitHub project](https://github.com/mozilla-mobile/fenix/). If you want to discuss your report please use [Mozilla's chat](https://wiki.mozilla.org/Matrix#Connect_to_Matrix) server https://chat.mozilla.org and join the [#fenix](https://chat.mozilla.org/#/room/#fenix:mozilla.org) channel.