1264225 - Unverified accounts are syncing on exit

Status: VERIFIED FIXED

(Firefox for iOS :: Sync, defect)

Description

[Catalin Suciu [:csuciu]]

Attachment: Screen Shot 2016-04-13 at 11.25.46.png

Build: 4.0.0b1

1. Go to Settings > Sync and create a new FxA
2. Don't verify the email address
3. Background Firefox
4. Immediately, foreground Firefox and check the 'Sync' button
 
Result: The Sync button says 'Syncing' 

Please note that the unverified accounts can also be synced manually by tapping on the Sync Now button.

Comment 1

[Robin Andersen [:tecgirl]]

Should/can we disable Sync and the manual functionality until the account is verified?

If so, let's — and print 'Sync disabled' in grey until the account is verified. If the user goes to a panel that would normally ping Sync, we can enable statusbar messaging: "Verify your email address to enable sync".

Comment 2

[James Hugman [:jhugman] [@jhugman]]

Syncing should not be green lit unless the account is verified.

i.e. it'll be started, but quickly finished abnormally (same as if the device is offline).

Comment 3

[Stephan Leroux [:sleroux]]

Attachment: Link to Github pull-request: https://github.com/mozilla/firefox-ios/pull/1800

Comment 4

[Emily Toop (:fluffyemily)]

Comment on attachment 8750966 [details] [review]
Link to Github pull-request: https://github.com/mozilla/firefox-ios/pull/1800

Just one comment, otherwise LGTM

Comment 5

[Stephan Leroux [:sleroux]]

master 85c582ef41a376b6c3a18ae4e58e79da1d3ac6e7

Comment 6

[Simon Basca [:SimonB]]

Tested on build afdbc70.
The unverified accounts are no longer syncing on exit.