Closed Bug 1267205 Opened 9 years ago Closed 9 years ago

Display current sync status in Settings

Categories

(Firefox for iOS :: Sync, defect)

Product:
Firefox for iOS
Component:
Sync
Platform:
Other
iOS
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED FIXED
Tracking Flags:
Tracking Status
fxios 5.0+ ---

People

(Reporter: fluffyemily, Assigned: fluffyemily)

References

Details

User Story

Only surface if the action taking place is at risk: when attempting to manage
If state is good (connected, stable) — no message, hooray!
If state is stale (connected but unable to sync) — provide messaging and SUMO link on first action instance and update Sync status in Settings
Do not let user update synced data 
If state is bad (no successful sync) disable all record editing capabilities — provide messaging on first action instance and update Sync status in Settings — this is the Read Only state — we can’t allow record changes if they risk being overwritten if a successful sync ends up taking place. 

Statusbar notification message 
Show on action, first instance only, auto-dismissal

STRINGS WIP — SUGGESTIONS WELCOME
“Firefox is unable to sync”
“Firefox is experiencing issues”
“Updating bookmarks is currently disabled”
“Firefox is unable to sync your bookmarks at this time”
“Sync currently unavailable”
“Bookmark sync currently unavailable”
“Firefox Sync is unavailable”
“Sync failed”

Attachments

(7 files)

Bookmarks on iOS
85 bytes, text/x-google-doc
Details
Pull Request
48 bytes, text/x-github-pull-request
sleroux
: review+
tecgirl
: ui-review+
sleroux
: feedback+
tecgirl
: feedback+
Details | Review
Caution.zip
9.29 KB, application/zip
Details
Sync Status Fail
50.27 KB, image/png
Details
Sync Status Stale
54.17 KB, image/png
Details
Sync Status Stale Long Text
59.45 KB, image/png
Details
Pull request
48 bytes, text/x-github-pull-request
flod
: review+
Details | Review
Attached file Bookmarks on iOS —
No description provided.
Depends on: 1223162
Depends on: 1267265
Assignee: nobody → etoop
Status: NEW → ASSIGNED
:tecgirl the designs here call for a 'warning' symbol on the settings page in both amber and red. Do you have an asset for that? Also, what are the exact colours for amber and red?
Flags: needinfo?(randersen)
Blocks: 1264225
Attached file Pull Request —
Attachment #8750894 - Flags: review?(sleroux)
Comment on attachment 8750894 [details] [review] Pull Request Left some comments mostly around the BrowerProfile changes. Front end stuff looks good!
Attachment #8750894 - Flags: feedback+
(In reply to Emily Toop (:fluffyemily) from comment #1) > :tecgirl the designs here call for a 'warning' symbol on the settings page > in both amber and red. Do you have an asset for that? > > Also, what are the exact colours for amber and red? Amber: R245 G166 B35 A100 Red: R255 G0 B26 A100
Flags: needinfo?(randersen)
Attached file Caution.zip —
Caution assets in amber and red.
We need a link to the SUMO page for troubleshooting sync issue on iOS. I've been told that you are the person to ask Joni. If you could provide the link to where it will be we can add it to the code before the page is ready. Thanks.
Flags: needinfo?(jsavage)
Attachment #8750894 - Flags: ui-review?(randersen)
Comment on attachment 8750894 [details] [review] Pull Request :fluffyemily – what's the best way to test this with the errors?
Attached image Sync Status Fail —
Attached image Sync Status Stale —
(In reply to Robin Andersen [:tecgirl] from comment #7) > Comment on attachment 8750894 [details] [review] > WIP Pull Request > > :fluffyemily – what's the best way to test this with the errors? :tecgirl I've attached some screenshots of the different states to demo it.
Attachment #8750894 - Flags: ui-review?(randersen)
Attachment #8750894 - Flags: ui-review+
Attachment #8750894 - Flags: feedback+
(In reply to Emily Toop (:fluffyemily) from comment #6) > We need a link to the SUMO page for troubleshooting sync issue on iOS. I've > been told that you are the person to ask Joni. If you could provide the link > to where it will be we can add it to the code before the page is ready. > Thanks. Hi Emily, here's the link you can use in the code: https://support.mozilla.org/1/firefox/%VERSION%/%OS%/%LOCALE%/sync-status-ios It will redirect to an upcoming support article.
Flags: needinfo?(jsavage)
Attachment #8750894 - Attachment description: WIP Pull Request → Pull Request
Attachment #8750894 - Flags: review?(sleroux)
Attachment #8750894 - Flags: review?(sleroux)
Comment on attachment 8750894 [details] [review] Pull Request Left some additional feedback and talking points on the PR.
Attachment #8750894 - Flags: review?(sleroux) → review+
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
> > My first question is why singular, "Bookmark" vs "Bookmarks"? This was because all of the other syncs are referred to in the singlular (tab, history, reading list) and so I felt it would be consistent to refer to bookmark sync in the same way. This can be changed. > > Besides that, it should be specified in each of the 4 strings (module names) > that they will be used in SyncState.Partial.Title. I will update these comments > > SyncState.Partial.Title is almost impossible to localize as it is, it's a > natural sounding sentence only in English. It might be worth providing an > alternative in the comment, e.g. "Sync's module for %@ is experiencing > issues", or "There are issues with the module Sync - %@". > > One final question: > * "Sync is offline", "Sync is unavailable": Sync is the feature name. > * "Sync failed", it sounds more like "sync", as an abbreviation for > synchronization. > > Does that make any sense? It doesn't help that "sync" is always spelled > lowercase in the comments, in past comments the feature was called out as > Sync. I understand. I will ask :tecgirl if she has any preferences for how the language should change
Flags: needinfo?(etoop) → needinfo?(randersen)
(In reply to Emily Toop (:fluffyemily) from comment #15) > > > > My first question is why singular, "Bookmark" vs "Bookmarks"? > > This was because all of the other syncs are referred to in the singlular > (tab, history, reading list) and so I felt it would be consistent to refer > to bookmark sync in the same way. This can be changed. Sorry, I should have specified that my doubt is for (boormark, tab, login), while it obviously make sense to have singular for History.
There are a few localization issues with the strings landed in this bug. Since we're close to the string extraction, I think it would be important to at least improve the localization comments. > SyncState.Partial.Title = %@ Sync is experiencing issues And then use Bookmark, Tab, Login, History to replace the variable. My first question is why singular, "Bookmark" vs "Bookmarks"? Besides that, it should be specified in each of the 4 strings (module names) that they will be used in SyncState.Partial.Title. SyncState.Partial.Title is almost impossible to localize as it is, it's a natural sounding sentence only in English. It might be worth providing an alternative in the comment, e.g. "Sync's module for %@ is experiencing issues", or "There are issues with the module Sync - %@". One final question: * "Sync is offline", "Sync is unavailable": Sync is the feature name. * "Sync failed", it sounds more like "sync", as an abbreviation for synchronization. Does that make any sense? It doesn't help that "sync" is always spelled lowercase in the comments, in past comments the feature was called out as Sync.
Flags: needinfo?(etoop)
(In reply to Francesco Lodolo [:flod] from comment #14) > There are a few localization issues with the strings landed in this bug. > Since we're close to the string extraction, I think it would be important to > at least improve the localization comments. > > > SyncState.Partial.Title = %@ Sync is experiencing issues > > And then use Bookmark, Tab, Login, History to replace the variable. > > My first question is why singular, "Bookmark" vs "Bookmarks"? > > Besides that, it should be specified in each of the 4 strings (module names) > that they will be used in SyncState.Partial.Title. > > SyncState.Partial.Title is almost impossible to localize as it is, it's a > natural sounding sentence only in English. It might be worth providing an > alternative in the comment, e.g. "Sync's module for %@ is experiencing > issues", or "There are issues with the module Sync - %@". > > One final question: > * "Sync is offline", "Sync is unavailable": Sync is the feature name. > * "Sync failed", it sounds more like "sync", as an abbreviation for > synchronization. > > Does that make any sense? It doesn't help that "sync" is always spelled > lowercase in the comments, in past comments the feature was called out as > Sync. I am unsure how to proceed with these strings. Yes, Sync is the feature name, but that is because it synchronizes your account and so is a synchronizer. When you are unable to synchronize, Sync is unavailable. When synchronizing your account fails, Sync has failed. I am struggling to come up with phrasing that separates the two. How about, * "Sync has failed to complete" * "Sync is experiencing issues syncing %@" (i.e. Sync is experiencing issues with Bookmarks) I've made the component names plural for consistency.
Flags: needinfo?(francesco.lodolo)
Attached file Pull request —
Attachment #8758181 - Flags: review?(francesco.lodolo)
(In reply to Emily Toop (:fluffyemily) from comment #17) > I am unsure how to proceed with these strings. Yes, Sync is the feature > name, but that is because it synchronizes your account and so is a > synchronizer. When you are unable to synchronize, Sync is unavailable. When > synchronizing your account fails, Sync has failed. I am struggling to come > up with phrasing that separates the two. I think for "Sync is offline/unavailable" is quite easy to understand that the reference is to the feature name, not the action. I'm mostly asking to be consistent in the comments. For example, for "Sync is unavailable" the comment is "Title sync status message when sync failed to start.", it should be something like "Title for Sync status message when Sync failed to start." > * "Sync has failed to complete" What about "Syncing has failed"? As I said, it sounds more like the action than the feature. Try imagining that the feature name is "Persona" (internal joke intended…) instead of "Sync": does the sentence still work? If it does, then it's good. In this case, I don't think "Persona has failed to complete" sounds great. > * "Sync is experiencing issues syncing %@" (i.e. Sync is experiencing issues > with Bookmarks) As long as you specify in the comments how strings are used, and they're not reused elsewhere, it's good. About reuse: in this case %@ is accusative "sync bookmarks", some languages might need a different form for "bookmarks are syncing" (nominative).
Comment on attachment 8758181 [details] [review] Pull request A couple of notes on the comments but it looks good to me, with the only doubt about "Sync failed to complete".
Flags: needinfo?(francesco.lodolo)
Attachment #8758181 - Flags: review?(francesco.lodolo) → review+
Flags: needinfo?(randersen)
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: