Closed
Bug 1264483
Opened 8 years ago
Closed 8 years ago
Hide Widevine CDM download on unsupported systems
Categories
(Firefox :: General, defect, P1)
Tracking
()
VERIFIED
FIXED
Firefox 48
People
(Reporter: cpearce, Assigned: bytesized)
References
(Blocks 1 open bug)
Details
Attachments
(1 file)
58 bytes,
text/x-review-board-request
|
spohl
:
review+
ritu
:
approval-mozilla-aurora+
|
Details |
We're not pushing out the Widevine CDM on Windows XP, so we should not show it in the plugin download manager on Windows XP. We used to do this with Adobe EME, up until bug 1234099, so we can copy the implementation removed in bug 1234099.
Assignee | ||
Comment 3•8 years ago
|
||
https://treeherder.mozilla.org/#/jobs?repo=try&revision=48a9d70ef829
Assignee | ||
Comment 4•8 years ago
|
||
Review commit: https://reviewboard.mozilla.org/r/46477/diff/#index_header See other reviews: https://reviewboard.mozilla.org/r/46477/
Assignee | ||
Updated•8 years ago
|
Assignee: nobody → ksteuber
Assignee | ||
Updated•8 years ago
|
Attachment #8741440 -
Flags: review?(spohl.mozilla.bugs)
Comment 5•8 years ago
|
||
Henri suggests that we hide Widevine by default and show it on Vista+ and Mac instead of defaulting to showing and hiding it in particular situations. This approach should be simpler and has a fail-safe default (i.e. hidden).
Assignee | ||
Updated•8 years ago
|
Summary: Hide Widevine CDM download on Windows XP → Hide Widevine CDM download on unsupported systems
Assignee | ||
Updated•8 years ago
|
Attachment #8741440 -
Flags: review?(spohl.mozilla.bugs)
Assignee | ||
Comment 7•8 years ago
|
||
Comment on attachment 8741440 [details] MozReview Request: Bug 1264483 - Hide Widevine on unsupported systems Review request updated; see interdiff: https://reviewboard.mozilla.org/r/46477/diff/1-2/
Reporter | ||
Updated•8 years ago
|
Blocks: widevine-uplift
Assignee | ||
Updated•8 years ago
|
Attachment #8741440 -
Flags: review?(spohl.mozilla.bugs)
Comment 8•8 years ago
|
||
Comment on attachment 8741440 [details] MozReview Request: Bug 1264483 - Hide Widevine on unsupported systems https://reviewboard.mozilla.org/r/46477/#review43907 ::: toolkit/modules/GMPUtils.jsm:88 (Diff revision 2) > + // and Mac > + if (Services.appinfo.OS == "WINNT" && > + Services.sysinfo.getPropertyAsInt32("version") >= 6) { > + return true; > + } > + if (Services.appinfo.OS == "Darwin") { Please combine these two |if| statements for Windows Vista+ and Mac
Attachment #8741440 -
Flags: review?(spohl.mozilla.bugs) → review+
Assignee | ||
Comment 9•8 years ago
|
||
Comment on attachment 8741440 [details] MozReview Request: Bug 1264483 - Hide Widevine on unsupported systems Review request updated; see interdiff: https://reviewboard.mozilla.org/r/46477/diff/2-3/
Attachment #8741440 -
Attachment description: MozReview Request: Bug 1264483 - Hide Widevine on Windows XP → MozReview Request: Bug 1264483 - Hide Widevine on unsupported systems
Reporter | ||
Comment 10•8 years ago
|
||
https://hg.mozilla.org/integration/mozilla-inbound/rev/60bd274b9c7c8bcb491111f38d1e7210c09b4c10 Bug 1264483 - Hide Widevine on unsupported systems. r=spohl
Comment 11•8 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/60bd274b9c7c
Status: NEW → RESOLVED
Closed: 8 years ago
status-firefox48:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 48
Reporter | ||
Comment 12•8 years ago
|
||
bugherder uplift |
https://hg.mozilla.org/releases/mozilla-aurora/rev/8259d94f2e54
status-firefox47:
--- → fixed
Reporter | ||
Comment 13•8 years ago
|
||
Comment on attachment 8741440 [details] MozReview Request: Bug 1264483 - Hide Widevine on unsupported systems Requesting uplift for Firefox 47. Approval Request Comment [Feature/regressing bug #]: Widevine EME support [User impact if declined]: Widevine CDM will appear in add-on manager and be downloaded on Windows XP, even though it can't be used there. [Describe test coverage new/current, TreeHerder]: We have test coverage for this feature [Risks and why]: Low. [String/UUID change made/needed]: None.
Attachment #8741440 -
Flags: approval-mozilla-aurora?
Comment on attachment 8741440 [details] MozReview Request: Bug 1264483 - Hide Widevine on unsupported systems Widevine related uplifts were pre-approved.
Attachment #8741440 -
Flags: approval-mozilla-aurora? → approval-mozilla-aurora+
Comment 15•8 years ago
|
||
Verified as fixed on Windows XP and on Ubuntu 15.04 - the "Widevine Content Decryption Module provided by Google Inc." plugin is not shown or installed in the Add-ons Manager under the Plugins section. Verified on the latest Nightly 49 (Build ID: 20160524073714), on the latest Firefox Developer Edition 48.0a2 (Build ID: 20160524004015) and latest Firefox 47 beta 8 (Build ID: 20160523113146).
You need to log in
before you can comment on or make changes to this bug.
Description
•