1264483 - Hide Widevine CDM download on unsupported systems

Status: VERIFIED FIXED

(Firefox :: General, defect, P1)

Description

[Chris Pearce [:cpearce (Not reading bugmail)]]

We're not pushing out the Widevine CDM on Windows XP, so we should not show it in the plugin download manager on Windows XP. We used to do this with Adobe EME, up until bug 1234099, so we can copy the implementation removed in bug 1234099.

Comment 1

[Chris Pearce [:cpearce (Not reading bugmail)]]

Kirk: Can you handle this please?

Comment 2

[Robin Steuber (she/her) [:bytesized]]

On it.

Comment 3

[Robin Steuber (she/her) [:bytesized]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=48a9d70ef829

Comment 4

[Robin Steuber (she/her) [:bytesized]]

Attachment: MozReview Request: Bug 1264483 - Hide Widevine on unsupported systems

Review commit: https://reviewboard.mozilla.org/r/46477/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/46477/

Comment 5

[Chris Peterson [:cpeterson]]

Henri suggests that we hide Widevine by default and show it on Vista+ and Mac instead of defaulting to showing and hiding it in particular situations. This approach should be simpler and has a fail-safe default (i.e. hidden).

Comment 7

[Robin Steuber (she/her) [:bytesized]]

Comment on attachment 8741440 [details]
MozReview Request: Bug 1264483 - Hide Widevine on unsupported systems

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/46477/diff/1-2/

Comment 8

[Stephen A Pohl [:spohl]]

Comment on attachment 8741440 [details]
MozReview Request: Bug 1264483 - Hide Widevine on unsupported systems

https://reviewboard.mozilla.org/r/46477/#review43907

::: toolkit/modules/GMPUtils.jsm:88
(Diff revision 2)
> +      // and Mac
> +      if (Services.appinfo.OS == "WINNT" &&
> +          Services.sysinfo.getPropertyAsInt32("version") >= 6) {
> +        return true;
> +      }
> +      if (Services.appinfo.OS == "Darwin") {

Please combine these two |if| statements for Windows Vista+ and Mac

Comment 9

[Robin Steuber (she/her) [:bytesized]]

Comment on attachment 8741440 [details]
MozReview Request: Bug 1264483 - Hide Widevine on unsupported systems

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/46477/diff/2-3/

Comment 10

[Chris Pearce [:cpearce (Not reading bugmail)]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/60bd274b9c7c8bcb491111f38d1e7210c09b4c10
Bug 1264483 - Hide Widevine on unsupported systems. r=spohl

Comment 11

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/60bd274b9c7c

Comment 12

[Chris Pearce [:cpearce (Not reading bugmail)]]

https://hg.mozilla.org/releases/mozilla-aurora/rev/8259d94f2e54

Comment 13

[Chris Pearce [:cpearce (Not reading bugmail)]]

Comment on attachment 8741440 [details]
MozReview Request: Bug 1264483 - Hide Widevine on unsupported systems

Requesting uplift for Firefox 47.

Approval Request Comment
[Feature/regressing bug #]: Widevine EME support
[User impact if declined]: Widevine CDM will appear in add-on manager and be downloaded on Windows XP, even though it can't be used there.
[Describe test coverage new/current, TreeHerder]: We have test coverage for this feature
[Risks and why]: Low.
[String/UUID change made/needed]: None.

Comment 14

[Ritu Kothari (:ritu) (Inactive, please n-i to RyanVM, jcristau, or pascal)]

Comment on attachment 8741440 [details]
MozReview Request: Bug 1264483 - Hide Widevine on unsupported systems

Widevine related uplifts were pre-approved.

Comment 15

[Simona Badau, Desktop QA]

Verified as fixed on Windows XP and on Ubuntu 15.04 - the "Widevine Content Decryption Module provided by Google Inc." plugin is not shown or installed in the Add-ons Manager under the Plugins section.

Verified on the latest Nightly 49 (Build ID: 20160524073714), on the latest Firefox Developer Edition 48.0a2 (Build ID: 20160524004015) and latest Firefox 47 beta 8 (Build ID: 20160523113146).