Closed Bug 1264483 Opened 4 years ago Closed 4 years ago

Hide Widevine CDM download on unsupported systems

Categories

(Firefox :: General, defect, P1)

x86
Windows XP
defect

Tracking

()

VERIFIED FIXED
Firefox 48
Tracking Status
firefox47 --- verified
firefox48 --- verified

People

(Reporter: cpearce, Assigned: bytesized)

References

(Blocks 1 open bug)

Details

Attachments

(1 file)

We're not pushing out the Widevine CDM on Windows XP, so we should not show it in the plugin download manager on Windows XP. We used to do this with Adobe EME, up until bug 1234099, so we can copy the implementation removed in bug 1234099.
Kirk: Can you handle this please?
Flags: needinfo?(ksteuber)
On it.
Flags: needinfo?(ksteuber)
See Also: → 1264879
Assignee: nobody → ksteuber
Attachment #8741440 - Flags: review?(spohl.mozilla.bugs)
Henri suggests that we hide Widevine by default and show it on Vista+ and Mac instead of defaulting to showing and hiding it in particular situations. This approach should be simpler and has a fail-safe default (i.e. hidden).
Summary: Hide Widevine CDM download on Windows XP → Hide Widevine CDM download on unsupported systems
Duplicate of this bug: 1264879
Attachment #8741440 - Flags: review?(spohl.mozilla.bugs)
Comment on attachment 8741440 [details]
MozReview Request: Bug 1264483 - Hide Widevine on unsupported systems

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/46477/diff/1-2/
Attachment #8741440 - Flags: review?(spohl.mozilla.bugs)
Comment on attachment 8741440 [details]
MozReview Request: Bug 1264483 - Hide Widevine on unsupported systems

https://reviewboard.mozilla.org/r/46477/#review43907

::: toolkit/modules/GMPUtils.jsm:88
(Diff revision 2)
> +      // and Mac
> +      if (Services.appinfo.OS == "WINNT" &&
> +          Services.sysinfo.getPropertyAsInt32("version") >= 6) {
> +        return true;
> +      }
> +      if (Services.appinfo.OS == "Darwin") {

Please combine these two |if| statements for Windows Vista+ and Mac
Attachment #8741440 - Flags: review?(spohl.mozilla.bugs) → review+
Comment on attachment 8741440 [details]
MozReview Request: Bug 1264483 - Hide Widevine on unsupported systems

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/46477/diff/2-3/
Attachment #8741440 - Attachment description: MozReview Request: Bug 1264483 - Hide Widevine on Windows XP → MozReview Request: Bug 1264483 - Hide Widevine on unsupported systems
https://hg.mozilla.org/mozilla-central/rev/60bd274b9c7c
Status: NEW → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 48
Comment on attachment 8741440 [details]
MozReview Request: Bug 1264483 - Hide Widevine on unsupported systems

Requesting uplift for Firefox 47.

Approval Request Comment
[Feature/regressing bug #]: Widevine EME support
[User impact if declined]: Widevine CDM will appear in add-on manager and be downloaded on Windows XP, even though it can't be used there.
[Describe test coverage new/current, TreeHerder]: We have test coverage for this feature
[Risks and why]: Low.
[String/UUID change made/needed]: None.
Attachment #8741440 - Flags: approval-mozilla-aurora?
Comment on attachment 8741440 [details]
MozReview Request: Bug 1264483 - Hide Widevine on unsupported systems

Widevine related uplifts were pre-approved.
Attachment #8741440 - Flags: approval-mozilla-aurora? → approval-mozilla-aurora+
Verified as fixed on Windows XP and on Ubuntu 15.04 - the "Widevine Content Decryption Module provided by Google Inc." plugin is not shown or installed in the Add-ons Manager under the Plugins section.

Verified on the latest Nightly 49 (Build ID: 20160524073714), on the latest Firefox Developer Edition 48.0a2 (Build ID: 20160524004015) and latest Firefox 47 beta 8 (Build ID: 20160523113146).
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.