Unhide Adobe GMP on Windows XP

RESOLVED FIXED in Firefox 46

Status

()

Firefox
General
RESOLVED FIXED
3 years ago
2 years ago

People

(Reporter: cpearce, Assigned: cpearce)

Tracking

(Blocks: 1 bug)

unspecified
Firefox 46
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(firefox46 fixed)

Details

Attachments

(1 attachment, 1 obsolete attachment)

(Assignee)

Description

3 years ago
We've determined that the Adobe GMP can be used to decode H.264/AAC for non-EME HTML5 <video> on Windows XP.

So we the GMPProvider to enable the GMP on Windows XP, so Firefox will download and use the GMP on WinXP, so that users can have MP4 video playback.

We'll need to unhide the GMP in about:addons > plugins.

Note that playback of EME encrypted video doesn't work yet with the Adobe CDM on Windows XP, so we'd be enabling the Primetime Content Decryption Module entry in about:addons > plugins, but the user would not be able to play EME video on WinXP. This may be confusing to users, but we should provide a way for users to turn off decoding unencrypted video using Adobe's plugin.
(Assignee)

Comment 1

3 years ago
Created attachment 8700450 [details]
MozReview Request: Bug 1234099 - Unhide Adobe GMP on Windows XP. r?spohl

Review commit: https://reviewboard.mozilla.org/r/28711/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/28711/
Attachment #8700450 - Flags: review?(spohl.mozilla.bugs)
Attachment #8700450 - Flags: review?(spohl.mozilla.bugs)
Comment on attachment 8700450 [details]
MozReview Request: Bug 1234099 - Unhide Adobe GMP on Windows XP. r?spohl

https://reviewboard.mozilla.org/r/28711/#review25509

::: toolkit/modules/GMPUtils.jsm
(Diff revision 1)
> -  _isPluginSupported: function(aPlugin) {

Removing this function wouldn't just unhide the Adobe EME GMP on Windows XP, but on *all* platforms. You should be able to achieve what you want by simply dropping the |Services.sysinfo.getPropertyAsInt32("version")| check in this function.
(Assignee)

Updated

3 years ago
Attachment #8700450 - Flags: review?(spohl.mozilla.bugs)
(Assignee)

Comment 3

3 years ago
Comment on attachment 8700450 [details]
MozReview Request: Bug 1234099 - Unhide Adobe GMP on Windows XP. r?spohl

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/28711/diff/1-2/
Comment on attachment 8700450 [details]
MozReview Request: Bug 1234099 - Unhide Adobe GMP on Windows XP. r?spohl

https://reviewboard.mozilla.org/r/28711/#review25545
Attachment #8700450 - Flags: review?(spohl.mozilla.bugs) → review+
(Assignee)

Updated

3 years ago
Depends on: 1234100
(Assignee)

Comment 8

3 years ago
Created attachment 8704050 [details] [diff] [review]
Patch v2: With test fixed

(For some reason, I can't push a re-review to mozreview for this...)

I need to change the test to not assume WinXP doesn't have Adobe EME any more.

https://treeherder.mozilla.org/#/jobs?repo=try&revision=5f60787fef8a
Attachment #8700450 - Attachment is obsolete: true
Flags: needinfo?(cpearce)
Attachment #8704050 - Flags: review?(spohl.mozilla.bugs)
Attachment #8704050 - Flags: review?(spohl.mozilla.bugs) → review+

Comment 10

3 years ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/34460cc654ca
Status: NEW → RESOLVED
Last Resolved: 3 years ago
status-firefox46: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 46
(Assignee)

Comment 12

3 years ago
Backed out because we've determined that the Adobe GMP is unable to play video in the Facebook news stream.
Status: RESOLVED → REOPENED
Keywords: leave-open
Resolution: FIXED → ---
Blocks: 1229904
(Assignee)

Comment 16

2 years ago
Comment on attachment 8704050 [details] [diff] [review]
Patch v2: With test fixed

Requesting uplift to Firefox 46, in support of Bug 1250766.

Approval Request Comment
[Feature/regressing bug #]: Unencrypted decoding of MP4/AAC/H.264 files on Windows XP.
[User impact if declined]: Firefox users on WinXP will not be able to see the Adobe GMP in their Plugins user interface, and Firefox will not download the GMP, and so such users won't get MP4/H.264/AAC decoding routed through the Adobe GMP and will not get MP4/H.264/AAC playback and will be stuck with Flash.
[Describe test coverage new/current, TreeHerder]: We have mochitests and xpcshell covering this feature.
[Risks and why]: Low, code path used elsewhere.
[String/UUID change made/needed]: None.
Attachment #8704050 - Flags: approval-mozilla-aurora?
Comment on attachment 8704050 [details] [diff] [review]
Patch v2: With test fixed

Since we're re-enabling GMP we need to show the user the plugin in the UI. 
Includes tests, please uplift to aurora.
Attachment #8704050 - Flags: approval-mozilla-aurora? → approval-mozilla-aurora+
(Assignee)

Updated

2 years ago
Keywords: leave-open
(Assignee)

Updated

2 years ago
Status: REOPENED → RESOLVED
Last Resolved: 3 years ago2 years ago
Resolution: --- → FIXED
Looks like we need to revert this. Can you do that in a new bug so we can track it and uplift easily?
Flags: needinfo?(cpearce)
(Assignee)

Updated

2 years ago
See Also: → bug 1265928
Comment hidden (typo)
(Assignee)

Comment 21

2 years ago
(In reply to Chris Pearce (:cpearce) from comment #20)
> (In reply to Liz Henry (:lizzard) (needinfo? me) from comment #19)
> > Looks like we need to revert this. Can you do that in a new bug so we can
> > track it and uplift easily?
> 
> Sure, filed bug 1265815.

Copy paste error, I meant bug 1265928.
You need to log in before you can comment on or make changes to this bug.