Closed Bug 1264593 Opened 4 years ago Closed 3 years ago

test Isolation on SharedWorker by first party domain (Tor 15564)

Categories

(Core :: DOM: Security, defect, P2)

defect

Tracking

()

RESOLVED FIXED
mozilla52
Tracking Status
firefox52 --- fixed

People

(Reporter: allstars.chh, Assigned: timhuang)

References

(Depends on 2 open bugs, Blocks 2 open bugs)

Details

(Whiteboard: [tor-testing][OA-testing][domsecurity-active][ETA 10/10])

Attachments

(1 file, 1 obsolete file)

We need to have some tests for verifying ShareWorker isolation by first party domain.


TOR commit:
https://gitweb.torproject.org/tor-browser.git/patch/?id=c1c8969
https://gitweb.torproject.org/tor-browser.git/patch/?id=0c04c06
Whiteboard: [tor][OA] → [tor][OA][domsecurity-backlog]
Here's a link that tracks the Tor Browser SharedWorker patches as they are rebased to new versions of Firefox:
https://torpat.ch/15564
Summary: Isolation on ShareWorker by first party domain → Isolation on ShareWorker by first party domain (Tor 15664)
Whiteboard: [tor][OA][domsecurity-backlog] → [tor][OA-testing][domsecurity-backlog]
Summary: Isolation on ShareWorker by first party domain (Tor 15664) → test Isolation on ShareWorker by first party domain (Tor 15664)
Whiteboard: [tor][OA-testing][domsecurity-backlog] → [tor-testing][OA-testing][domsecurity-backlog]
Summary: test Isolation on ShareWorker by first party domain (Tor 15664) → test Isolation on SharedWorker by first party domain (Tor 15664)
Priority: -- → P1
Depends on: 1289319
Priority: P1 → P3
Whiteboard: [tor-testing][OA-testing][domsecurity-backlog] → [tor-testing][OA-testing][domsecurity-backlog1]
Assignee: nobody → tihuang
Status: NEW → ASSIGNED
Priority: P3 → P1
Whiteboard: [tor-testing][OA-testing][domsecurity-backlog1] → [tor-testing][OA-testing][domsecurity-active]
Whiteboard: [tor-testing][OA-testing][domsecurity-active] → [tor-testing][OA-testing][domsecurity-active][ETA 10/10]
Priority: P1 → P2
Comment on attachment 8778056 [details]
Bug 1264593 - Add a test case for the isolation on the shared worker by first party domain.

https://reviewboard.mozilla.org/r/69448/#review72526

Looks good to me. Thanks!
Attachment #8778056 - Flags: review?(arthuredelstein) → review+
Comment on attachment 8778056 [details]
Bug 1264593 - Add a test case for the isolation on the shared worker by first party domain.

https://reviewboard.mozilla.org/r/69448/#review74816

::: browser/components/originattributes/test/browser/browser_sharedworker.js:12
(Diff revision 3)
> +const TEST_PAGE = TEST_PATH + "file_sharedworker.html";
> +
> +function* getResultFromSharedworker(aBrowser) {
> +  let response = yield ContentTask.spawn(aBrowser, null, function* () {
> +    let message = "isolationSharedWorkerTest";
> +    let worker = new content.SharedWorker("file_sharedworker.js", message);

you are not using message. Just pass "isolationSharedWorkerTest as second argument here.
Comment on attachment 8778056 [details]
Bug 1264593 - Add a test case for the isolation on the shared worker by first party domain.

https://reviewboard.mozilla.org/r/69448/#review74818
Attachment #8778056 - Flags: review?(amarchesini) → review+
Depends on: 1268726
Summary: test Isolation on SharedWorker by first party domain (Tor 15664) → test Isolation on SharedWorker by first party domain (Tor 15564)
Depends on: 1302566
Attachment #8746849 - Attachment is obsolete: true
Try looks good.
Keywords: checkin-needed
Pushed by manishearth@gmail.com:
https://hg.mozilla.org/integration/autoland/rev/515984420e41
Add a test case for the isolation on the shared worker by first party domain. r=arthuredelstein,baku
Keywords: checkin-needed
https://hg.mozilla.org/mozilla-central/rev/515984420e41
Status: ASSIGNED → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla52
Depends on: 1335678
See Also: → 1495241
You need to log in before you can comment on or make changes to this bug.