1264593 - test Isolation on SharedWorker by first party domain (Tor 15564)

Status: RESOLVED FIXED

(Core :: DOM: Security, defect, P2)

Description

[Yoshi Cheng-Hao Huang [:allstars.chh][:allstarschh][:yoshi]]

We need to have some tests for verifying ShareWorker isolation by first party domain.


TOR commit:
https://gitweb.torproject.org/tor-browser.git/patch/?id=c1c8969
https://gitweb.torproject.org/tor-browser.git/patch/?id=0c04c06

Comment 1

[Arthur Edelstein [:arthur]]

Here's a link that tracks the Tor Browser SharedWorker patches as they are rebased to new versions of Firefox:
https://torpat.ch/15564

Comment 2

[Dave Huseby [:huseby]]

Attachment: the Tor Browser tests patch (WIP)

Comment 3

[Tim Huang[:timhuang]]

Attachment: Bug 1264593 - Add a test case for the isolation on the shared worker by first party domain.

Review commit: https://reviewboard.mozilla.org/r/69448/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/69448/

Comment 4

[Tim Huang[:timhuang]]

Comment on attachment 8778056 [details]
Bug 1264593 - Add a test case for the isolation on the shared worker by first party domain.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/69448/diff/1-2/

Comment 5

[Tim Huang[:timhuang]]

Comment on attachment 8778056 [details]
Bug 1264593 - Add a test case for the isolation on the shared worker by first party domain.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/69448/diff/2-3/

Comment 6

[Arthur Edelstein [:arthur]]

Comment on attachment 8778056 [details]
Bug 1264593 - Add a test case for the isolation on the shared worker by first party domain.

https://reviewboard.mozilla.org/r/69448/#review72526

Looks good to me. Thanks!

Comment 7

[Andrea Marchesini [:baku]]

Comment on attachment 8778056 [details]
Bug 1264593 - Add a test case for the isolation on the shared worker by first party domain.

https://reviewboard.mozilla.org/r/69448/#review74816

::: browser/components/originattributes/test/browser/browser_sharedworker.js:12
(Diff revision 3)
> +const TEST_PAGE = TEST_PATH + "file_sharedworker.html";
> +
> +function* getResultFromSharedworker(aBrowser) {
> +  let response = yield ContentTask.spawn(aBrowser, null, function* () {
> +    let message = "isolationSharedWorkerTest";
> +    let worker = new content.SharedWorker("file_sharedworker.js", message);

you are not using message. Just pass "isolationSharedWorkerTest as second argument here.

Comment 8

[Andrea Marchesini [:baku]]

Comment on attachment 8778056 [details]
Bug 1264593 - Add a test case for the isolation on the shared worker by first party domain.

https://reviewboard.mozilla.org/r/69448/#review74818

Comment 9

[Tim Huang[:timhuang]]

Comment on attachment 8778056 [details]
Bug 1264593 - Add a test case for the isolation on the shared worker by first party domain.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/69448/diff/3-4/

Comment 10

[Tim Huang[:timhuang]]

Comment on attachment 8778056 [details]
Bug 1264593 - Add a test case for the isolation on the shared worker by first party domain.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/69448/diff/4-5/

Comment 11

[Tim Huang[:timhuang]]

Try looks good.

Comment 12

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/515984420e41
Add a test case for the isolation on the shared worker by first party domain. r=arthuredelstein,baku

Comment 13

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/515984420e41