Closed
Bug 1264679
Opened 9 years ago
Closed 8 years ago
[rep tests] Add tests for date-time rep
Categories
(DevTools :: Shared Components, enhancement, P1)
DevTools
Shared Components
Tracking
(firefox50 fixed)
Tracking | Status | |
---|---|---|
firefox50 | --- | fixed |
People
(Reporter: linclark, Assigned: linclark)
References
Details
(Whiteboard: [devtools-html])
Attachments
(1 file, 2 obsolete files)
3.51 KB,
patch
|
linclark
:
review+
|
Details | Diff | Splinter Review |
See Bug 1257552
Updated•9 years ago
|
Severity: normal → enhancement
Whiteboard: [devtools-html]
Updated•9 years ago
|
Blocks: devtools-html-2
Updated•8 years ago
|
Flags: qe-verify-
Priority: -- → P2
Assignee | ||
Updated•8 years ago
|
Assignee: nobody → lclark
Updated•8 years ago
|
Status: NEW → ASSIGNED
Iteration: --- → 49.3 - Jun 6
Priority: P2 → P1
Updated•8 years ago
|
Status: ASSIGNED → NEW
Iteration: 49.3 - Jun 6 → ---
Priority: P1 → P2
Assignee | ||
Comment 1•8 years ago
|
||
The webconsole uses toISOString for datetime instead of toString. (See https://dxr.mozilla.org/mozilla-central/source/devtools/client/webconsole/console-output.js#2726)
Would it be ok to change this?
Flags: needinfo?(odvarko)
Assignee | ||
Comment 2•8 years ago
|
||
Honza confirmed in meeting, it's fine to use ISO.
Flags: needinfo?(odvarko)
Assignee | ||
Comment 3•8 years ago
|
||
Attachment #8763622 -
Flags: review?(odvarko)
Updated•8 years ago
|
Status: NEW → ASSIGNED
Iteration: --- → 50.1
Priority: P2 → P1
Comment 4•8 years ago
|
||
Lin, the patch doesn't include the test_reps_date-time.html test file.
Honza
Flags: needinfo?(lclark)
Assignee | ||
Comment 5•8 years ago
|
||
Sorry about that. This one includes it
Attachment #8763622 -
Attachment is obsolete: true
Attachment #8763622 -
Flags: review?(odvarko)
Flags: needinfo?(lclark)
Attachment #8763845 -
Flags: review?(odvarko)
Comment 6•8 years ago
|
||
Comment on attachment 8763845 [details] [diff] [review]
Bug1264679.patch
Review of attachment 8763845 [details] [diff] [review]:
-----------------------------------------------------------------
One inline comment, but otherwise looks good to me!
Honza
::: devtools/client/shared/components/test/mochitest/test_reps_date-time.html
@@ +16,5 @@
> +<script type="application/javascript;version=1.8">
> +window.onload = Task.async(function* () {
> + try {
> + let ReactDOM = browserRequire("devtools/client/shared/vendor/react-dom");
> + let React = browserRequire("devtools/client/shared/vendor/react");
I think you can remove these two dependencies.
Honza
Attachment #8763845 -
Flags: review?(odvarko) → review+
Assignee | ||
Comment 7•8 years ago
|
||
You are correct, thanks!
Attachment #8763845 -
Attachment is obsolete: true
Attachment #8763950 -
Flags: review+
Assignee | ||
Updated•8 years ago
|
Keywords: checkin-needed
Pushed by ryanvm@gmail.com:
https://hg.mozilla.org/integration/fx-team/rev/edcca1bcdb79
[rep tests] Add tests for date-time rep. r=mayhemer
Comment 10•8 years ago
|
||
The commit message is still wrong. The reviewer should be Honza (not mayhemer)
Honza
Comment 11•8 years ago
|
||
bugherder |
Status: ASSIGNED → RESOLVED
Closed: 8 years ago
status-firefox50:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 50
Updated•6 years ago
|
Product: Firefox → DevTools
You need to log in
before you can comment on or make changes to this bug.
Description
•