1264679 - [rep tests] Add tests for date-time rep

Status: RESOLVED FIXED

(DevTools :: Shared Components, enhancement, P1)

Description

[Lin Clark [:linclark]]

See Bug 1257552

Comment 1

[Lin Clark [:linclark]]

The webconsole uses toISOString for datetime instead of toString. (See https://dxr.mozilla.org/mozilla-central/source/devtools/client/webconsole/console-output.js#2726) 


Would it be ok to change this?

Comment 2

[Lin Clark [:linclark]]

Honza confirmed in meeting, it's fine to use ISO.

Comment 3

[Lin Clark [:linclark]]

Attachment: Bug1264679.patch

Comment 4

[Jan Honza Odvarko [:Honza] (always need-info? me)]

Lin, the patch doesn't include the test_reps_date-time.html test file.

Honza

Comment 5

[Lin Clark [:linclark]]

Attachment: Bug1264679.patch

Sorry about that. This one includes it

Comment 6

[Jan Honza Odvarko [:Honza] (always need-info? me)]

Comment on attachment 8763845 [details] [diff] [review]
Bug1264679.patch

Review of attachment 8763845 [details] [diff] [review]:
-----------------------------------------------------------------

One inline comment, but otherwise looks good to me!

Honza

::: devtools/client/shared/components/test/mochitest/test_reps_date-time.html
@@ +16,5 @@
> +<script type="application/javascript;version=1.8">
> +window.onload = Task.async(function* () {
> +  try {
> +    let ReactDOM = browserRequire("devtools/client/shared/vendor/react-dom");
> +    let React = browserRequire("devtools/client/shared/vendor/react");

I think you can remove these two dependencies.
Honza

Comment 7

[Lin Clark [:linclark]]

Attachment: Bug1264679.patch

You are correct, thanks!

Comment 8

[Ryan VanderMeulen [:RyanVM]]

This patch had the wrong commit message on it...

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/fx-team/rev/edcca1bcdb79
[rep tests] Add tests for date-time rep. r=mayhemer

Comment 10

[Jan Honza Odvarko [:Honza] (always need-info? me)]

The commit message is still wrong. The reviewer should be Honza (not mayhemer)

Honza

Comment 11

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/edcca1bcdb79