[rep tests] Add tests for document rep

RESOLVED FIXED in Firefox 50

Status

P1
enhancement
RESOLVED FIXED
3 years ago
3 months ago

People

(Reporter: linclark, Assigned: linclark)

Tracking

unspecified
Firefox 50
Dependency tree / graph
Bug Flags:
qe-verify -

Firefox Tracking Flags

(firefox50 fixed)

Details

(Whiteboard: [devtools-html])

Attachments

(2 obsolete attachments)

(Assignee)

Description

3 years ago
See Bug 1257552
(Assignee)

Updated

3 years ago
Blocks: 1257552

Updated

3 years ago
Severity: normal → enhancement
Whiteboard: [devtools-html]

Updated

3 years ago
Blocks: 1263741

Updated

2 years ago
Flags: qe-verify-
Priority: -- → P2
(Assignee)

Updated

2 years ago
Assignee: nobody → lclark
(Assignee)

Comment 1

2 years ago
Created attachment 8764876 [details] [diff] [review]
Bug1264681.patch

I noticed one thing that I also noticed when writing the stylesheets test. It looks like we're getting only the path, not the absolute url, for all of these things. Couldn't the consumer possibly be inspecting objects that do not have the same host name?
Flags: needinfo?(odvarko)
Attachment #8764876 - Flags: review?(odvarko)

Updated

2 years ago
Status: NEW → ASSIGNED
Iteration: --- → 50.2
Priority: P2 → P1
Comment on attachment 8764876 [details] [diff] [review]
Bug1264681.patch

Review of attachment 8764876 [details] [diff] [review]:
-----------------------------------------------------------------

(In reply to Lin Clark [:linclark] from comment #1)
> I noticed one thing that I also noticed when writing the stylesheets test.
> It looks like we're getting only the path, not the absolute url, for all of
> these things. Couldn't the consumer possibly be inspecting objects that do
> not have the same host name?
Yes this could happen.

Originally, full path was displayed as a tooltip (now removed) since full URL often takes too much space.

Honza

::: devtools/client/shared/components/test/mochitest/test_reps_document.html
@@ +25,5 @@
> +      "actor": "server1.conn17.obj115",
> +      "extensible": true,
> +      "frozen": false,
> +      "sealed": false,
> +      "ownPropertyLength": 5,

This should be 1 (learned from your review :)

Honza
Attachment #8764876 - Flags: review?(odvarko) → review+
(replied in comment #2)
Flags: needinfo?(odvarko)

Updated

2 years ago
Iteration: 50.2 - Jul 4 → 50.3 - Jul 18
(Assignee)

Comment 4

2 years ago
Created attachment 8771957 [details]
Bug 1264681 - [rep tests] Add tests for document rep.

Review commit: https://reviewboard.mozilla.org/r/64922/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/64922/
Attachment #8771957 - Flags: review?(odvarko)
(Assignee)

Updated

2 years ago
Attachment #8764876 - Attachment is obsolete: true
(Assignee)

Updated

2 years ago
Attachment #8771957 - Flags: review+
(Assignee)

Comment 5

2 years ago
Comment on attachment 8771957 [details]
Bug 1264681 - [rep tests] Add tests for document rep.

https://reviewboard.mozilla.org/r/64922/#review61874

Carrying over the r+ from the patch

Comment 6

2 years ago
Pushed by lclark@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/102f746a6474
[rep tests] Add tests for document rep. r=me
Lin, the review request is left over?

Honza
Flags: needinfo?(lclark)
(Assignee)

Updated

2 years ago
Attachment #8771957 - Attachment is obsolete: true
Flags: needinfo?(lclark)
Attachment #8771957 - Flags: review?(odvarko)

Comment 8

2 years ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/102f746a6474
Status: ASSIGNED → RESOLVED
Last Resolved: 2 years ago
status-firefox50: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 50

Updated

3 months ago
Product: Firefox → DevTools
You need to log in before you can comment on or make changes to this bug.