Closed
Bug 1264681
Opened 8 years ago
Closed 8 years ago
[rep tests] Add tests for document rep
Categories
(DevTools :: Shared Components, enhancement, P1)
DevTools
Shared Components
Tracking
(firefox50 fixed)
| Tracking | Status | |
|---|---|---|
| firefox50 | --- | fixed |
People
(Reporter: linclark, Assigned: linclark)
References
Details
(Whiteboard: [devtools-html])
Attachments
(2 obsolete files)
See Bug 1257552
|
||
Updated•8 years ago
|
Severity: normal → enhancement
Whiteboard: [devtools-html]
|
|
||
Updated•8 years ago
|
Blocks: devtools-html-2
|
|
||
Updated•8 years ago
|
Flags: qe-verify-
Priority: -- → P2
|
Assignee | |
Updated•8 years ago
|
Assignee: nobody → lclark
|
|
Assignee | |
Comment 1•8 years ago
|
||
I noticed one thing that I also noticed when writing the stylesheets test. It looks like we're getting only the path, not the absolute url, for all of these things. Couldn't the consumer possibly be inspecting objects that do not have the same host name?
Flags: needinfo?(odvarko)
Attachment #8764876 -
Flags: review?(odvarko)
|
|
||
Updated•8 years ago
|
Status: NEW → ASSIGNED
Iteration: --- → 50.2
Priority: P2 → P1
|
||
Comment 2•8 years ago
|
||
Comment on attachment 8764876 [details] [diff] [review] Bug1264681.patch Review of attachment 8764876 [details] [diff] [review]: ----------------------------------------------------------------- (In reply to Lin Clark [:linclark] from comment #1) > I noticed one thing that I also noticed when writing the stylesheets test. > It looks like we're getting only the path, not the absolute url, for all of > these things. Couldn't the consumer possibly be inspecting objects that do > not have the same host name? Yes this could happen. Originally, full path was displayed as a tooltip (now removed) since full URL often takes too much space. Honza ::: devtools/client/shared/components/test/mochitest/test_reps_document.html @@ +25,5 @@ > + "actor": "server1.conn17.obj115", > + "extensible": true, > + "frozen": false, > + "sealed": false, > + "ownPropertyLength": 5, This should be 1 (learned from your review :) Honza
Attachment #8764876 -
Flags: review?(odvarko) → review+
|
|
||
Updated•8 years ago
|
Iteration: 50.2 - Jul 4 → 50.3 - Jul 18
|
|
Assignee | |
Comment 4•8 years ago
|
||
Review commit: https://reviewboard.mozilla.org/r/64922/diff/#index_header See other reviews: https://reviewboard.mozilla.org/r/64922/
Attachment #8771957 -
Flags: review?(odvarko)
|
|
Assignee | |
Updated•8 years ago
|
Attachment #8764876 -
Attachment is obsolete: true
|
|
Assignee | |
Updated•8 years ago
|
Attachment #8771957 -
Flags: review+
|
|
Assignee | |
Comment 5•8 years ago
|
||
Comment on attachment 8771957 [details] Bug 1264681 - [rep tests] Add tests for document rep. https://reviewboard.mozilla.org/r/64922/#review61874 Carrying over the r+ from the patch
Pushed by lclark@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/102f746a6474 [rep tests] Add tests for document rep. r=me
|
|
Assignee | |
Updated•8 years ago
|
Attachment #8771957 -
Attachment is obsolete: true
Flags: needinfo?(lclark)
Attachment #8771957 -
Flags: review?(odvarko)
|
||
Comment 8•8 years ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/102f746a6474
Status: ASSIGNED → RESOLVED
Closed: 8 years ago
status-firefox50:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 50
|
||
Updated•6 years ago
|
Product: Firefox → DevTools
You need to log in
before you can comment on or make changes to this bug.
Description
•