Closed Bug 1264681 Opened 4 years ago Closed 3 years ago

[rep tests] Add tests for document rep

Categories

(DevTools :: Shared Components, enhancement, P1)

enhancement

Tracking

(firefox50 fixed)

RESOLVED FIXED
Firefox 50
Iteration:
50.3 - Jul 18
Tracking Status
firefox50 --- fixed

People

(Reporter: linclark, Assigned: linclark)

References

Details

(Whiteboard: [devtools-html])

Attachments

(2 obsolete files)

See Bug 1257552
Blocks: 1257552
Severity: normal → enhancement
Whiteboard: [devtools-html]
Flags: qe-verify-
Priority: -- → P2
Assignee: nobody → lclark
Attached patch Bug1264681.patch (obsolete) — Splinter Review
I noticed one thing that I also noticed when writing the stylesheets test. It looks like we're getting only the path, not the absolute url, for all of these things. Couldn't the consumer possibly be inspecting objects that do not have the same host name?
Flags: needinfo?(odvarko)
Attachment #8764876 - Flags: review?(odvarko)
Status: NEW → ASSIGNED
Iteration: --- → 50.2
Priority: P2 → P1
Comment on attachment 8764876 [details] [diff] [review]
Bug1264681.patch

Review of attachment 8764876 [details] [diff] [review]:
-----------------------------------------------------------------

(In reply to Lin Clark [:linclark] from comment #1)
> I noticed one thing that I also noticed when writing the stylesheets test.
> It looks like we're getting only the path, not the absolute url, for all of
> these things. Couldn't the consumer possibly be inspecting objects that do
> not have the same host name?
Yes this could happen.

Originally, full path was displayed as a tooltip (now removed) since full URL often takes too much space.

Honza

::: devtools/client/shared/components/test/mochitest/test_reps_document.html
@@ +25,5 @@
> +      "actor": "server1.conn17.obj115",
> +      "extensible": true,
> +      "frozen": false,
> +      "sealed": false,
> +      "ownPropertyLength": 5,

This should be 1 (learned from your review :)

Honza
Attachment #8764876 - Flags: review?(odvarko) → review+
(replied in comment #2)
Flags: needinfo?(odvarko)
Iteration: 50.2 - Jul 4 → 50.3 - Jul 18
Attachment #8764876 - Attachment is obsolete: true
Attachment #8771957 - Flags: review+
Comment on attachment 8771957 [details]
Bug 1264681 - [rep tests] Add tests for document rep.

https://reviewboard.mozilla.org/r/64922/#review61874

Carrying over the r+ from the patch
Pushed by lclark@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/102f746a6474
[rep tests] Add tests for document rep. r=me
Lin, the review request is left over?

Honza
Flags: needinfo?(lclark)
Attachment #8771957 - Attachment is obsolete: true
Flags: needinfo?(lclark)
Attachment #8771957 - Flags: review?(odvarko)
https://hg.mozilla.org/mozilla-central/rev/102f746a6474
Status: ASSIGNED → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 50
Product: Firefox → DevTools
You need to log in before you can comment on or make changes to this bug.